#1001399 lintian: adjust backports-upload-has-incorrect-version-number for ubuntu

#1001399#3
Date:
2021-12-09 15:20:59 UTC
From:
To:
Hi,

So, I have this:

E: debhelper changes: backports-upload-has-incorrect-version-number 13.5.2ubuntu1~bpo20.04.1

However, in Ubuntu we just started up again the process, and the new
policy says to append ~bpo$UBU_VERSION.1, with $UBU_VERSION 20.04,
18.04, 20.10, etc.

See https://wiki.ubuntu.com/UbuntuBackports#Preparing_the_Backported_Package

Do you think you could adjust the value of this tag when run under
ubuntu (so, I suppose, run with the ubuntu profile)?

TIA!

#1001399#6
Date:
2021-12-09 16:37:34 UTC
From:
To:
So, that's one approach, but considering your other proposals first.

I wouldn't be opposed to this, however I'd like to generally be warned
if I'm obviously running lintian on my debian systems against an ubuntu
packages.  Is there already a tag for this?
If this is already covered by a different tag, then
backports-upload-has-incorrect-version-number could just accept both
variants.
what distribution is a given release.  I believe we shouldn't concern
ourselves too much with UNRELEASED (what's the current behaviour here
anyway?)

#1001399#11
Date:
2021-12-09 15:41:44 UTC
From:
To:
Hi,

Right now, Lintian's profiles just enable or disable tags. I am not
opposed to expanding their capabilities, but is it the right approach?

Should the version string for a Ubuntu package also be acceptable even
if Lintian ran on Debian?

Can Lintian tell the target OS without looking at the version string?
Maybe the changelog (except that would not work for UNRELEASED)?

Thanks!

Kind regards
Felix Lechner

#1001399#16
Date:
2021-12-09 16:59:33 UTC
From:
To:
Hi,

For the majority of tags, the release is not considered but having
less concern for UNRELEASED would negatively affect the quality of
hints issued on Salsa. [1] I expect that to be the primary Lintian
platform for contributors in the future.

Kind regards
Felix Lechner

[1] sample, https://lechner.pages.debian.net/-/mdadm/-/jobs/2004554/artifacts/debian/output/lintian.html

#1001399#19
Date:
2022-01-27 10:48:23 UTC
From:
To:
Sorry, this topic seems to have slipped my mind.

That might even be so, but I don't think it's an interesting concern
when we are talking about the final version string of a package.

I also had a look at the current Distribution.pm which is what is doing
the current check, and that's already skipping UNRELEASED for
everything, special casing squeeze, wheezy and jessie, and doing all
sorts of very target-specific checks.

I think what lintian is currently doing in this check is perfectly fine,
and it should keep doing that.

Different distributions have different version requirements, so tying
the two together only makes sense, and I see no reason why you shouldn't
do that.


You talk about running lintian in CI, which is fine, but then when run
in CI (with UNRELEASED) it's also true that there is no reason for
contributors to bother about the version string, as that's something for
the maintainer/uploader to check, so I think it's kind of out of scope.