#1002485 Source package dependency broken in nodejs package

Package:
nodejs
Source:
nodejs
Description:
evented I/O for V8 javascript - runtime executable
Submitter:
TheAssassin
Date:
2023-01-20 17:45:03 UTC
Severity:
normal
#1002485#5
Date:
2021-12-23 00:58:19 UTC
From:
To:
The control file requires libuv1-dev 1.33.0 or better. While working on
backporting that sid package to Ubuntu focal, I hit the following build
error:

../src/api/environment.cc: In function 'void
node::DefaultProcessExitHandler(node::Environment*, int)':
../src/api/environment.cc:718:3: error: 'uv_library_shutdown' was not
declared in this scope
   718 |   uv_library_shutdown();
       |   ^~~~~~~~~~~~~~~~~~~

The function was introduced in 1.38.0. I suppose the version should be
updated.

Just for the record, during the backport, I patched two lines in the
control file which I suppose are unrelated to this issue:

I lowered the libnghttp2-dev dependency to 1.40.0.
I also lowered the debhelper-compat dependency to 11.
#1002485#10
Date:
2023-01-20 17:42:49 UTC
From:
To:
It takes time to handle precise versioning of dependencies,
and you gave us the solution:
I'm sorry we didn't apply it in the latest security update.
Did all the tests pass with these changes ?

For debhelper-compat, that's a patch you have to carry in ubuntu, though.

Don't hesitate to ping me again in the future (bookworm...).