#1003271 lintian: skip-systemd-native-flag-missing-pre-depends still relevant?

#1003271#5
Date:
2022-01-07 10:35:11 UTC
From:
To:
The tag says:
" The named maintainer script uses the --skip-systemd-native flag to invoke-rc.d
but does not declare a Pre-Depends prerequisite on a recent version of
init-system-helpers.

When set, the flag helps to defer systemd actions until deb-systemd-invoke(1p)
is called, but the functionality was added only in init-system-helpers version
1.52.

Please add Pre-Depends: ${misc:Pre-Depends} to your debian/control file."


However, the init-system-helpers version 1.52 requirment is already fulfilled in oldstable.

Can/Should this tag be dropped?

#1003271#10
Date:
2022-01-07 10:46:56 UTC
From:
To:
Additional I noted that the description of the tag has a bug:

While
https://lintian.debian.org/tags/skip-systemd-native-flag-missing-pre-depends?version=2.114.123
says the version must be "1.52"

The code seems to check against 1.54~

const my $SYSTEMD_NATIVE_PREREQUISITES => 'init-system-helpers (>= 1.54~)';

#1003271#15
Date:
2022-01-07 12:36:26 UTC
From:
To:
Hi,

I just made these changes:

https://salsa.debian.org/lintian/lintian/-/commit/f5107b60f4c7bbb9762dd375e3513cf54b3bac0d

From the commit message:

The tag combines two checks in one. First, it requires that a Pre-Depends on
was declared and, second, that the version is sufficient. The reporting party
pointed out that the version requirement is satisfied in oldstable, so the
version requirement was dropped from both the code and from the description.

The overall check that a Pre-Depends was declared, however, may still be
sensible to keep.

On the website 73 sources currently provoke the tag, but we cannot if the
declaration is missing or just does not satisfy the minimum version requirement.
Let's see how the tag performs after this change.

Thanks to Tobias Frost for bringing the matter to our attention!

Kind regards
Felix Lechner