#1003395 plfit FTBFS on s390x

Package:
plfit
Source:
plfit
Description:
fitting power-law distributions to empirical data -- interfaces
Submitter:
Peter Michael Green
Date:
2024-08-05 09:15:05 UTC
Severity:
important
Tags:
#1003395#5
Date:
2022-01-09 13:34:40 UTC
From:
To:
tags: ftbfs

plfit FTBFS on s390x with test failures.

While this is not rc for plfit because plfit has never built on s390x,
it is blocking the migration of a rc bug fix in igraph to testing as
igraph recently switched from using an embedded copy of plfit to
using the plfit package..

#1003395#10
Date:
2022-01-10 09:48:10 UTC
From:
To:
The issue is actually discussed upstream even before this bug was filed.
#1003395#19
Date:
2022-02-25 14:41:54 UTC
From:
To:
As already indicated in https://github.com/ntamas/plfit/issues/38 the
problem is related to the size of long double.

The appended debdiff solved the problem on Ubuntu Jammy by forcing long
double to 64bit.

Best regards

Heinrich

#1003395#26
Date:
2024-08-03 16:07:08 UTC
From:
To:
close 1003395 0.9.5+ds-1
thanks

Hello.

This was fixed upstream and there is apparently no need to apply
any patch anymore.

I've written the long explanation in the github issue:

https://github.com/ntamas/plfit/issues/38

TLDR: It was fixed by the line in src/CMakeLists.txt saying this:

target_link_libraries(plfit ${MATH_LIBRARY})

Cc:ing all relevant parties.

Thanks.

#1003395#37
Date:
2024-08-03 21:24:34 UTC
From:
To:
reopen 1003395
retitle plfit: under-the-radar numerical issue


Hi,

I am re-opening the issue because
it has simply gone under the radar but it is still there.

The issue is a numerical issue that deserves an appropriate numerical analysis.
The upstream code currently workarounds by using at some point `long double`.
This is a very bad numerical practice: all the computation must be made with `double`.
The issue is actually not numerically trivial. I am on my way to elaborate a numerical fix.

Best wishes,
Jerome

#1003395#48
Date:
2024-08-05 09:13:42 UTC
From:
To:
tags 1003395 - ftbfs
tags 1003395 - patch
thanks

El 3/8/24 a las 23:31, Jerome BENOIT escribió:

Ok, I would have used a different bug for that myself, but if you want to use
the same bug for the underlying issue, so be it.

Note, however, that the original report said the package FTBFS, which does not
happen anymore, and it had a patch from Ubuntu which will probably not be applied,
so I hope you don't mind if I adjust the metadata accordingly.

Thanks.