#1003430 gkrellm-leds: reproducible-builds: /bin/sh dependent behavior in Makefile

#1003430#5
Date:
2022-01-10 04:10:55 UTC
From:
To:
The path that gkrellm-leds installs plugins into differs depending on
weather /bin/sh points to bash or dash:

https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/gkrellm-leds.html

In the md5sums file you have two different files included in the package:

  usr/lib/gkrellm2/plugins/gkleds.so
vs.
  build/gkrellm-leds-0.8.0/debian/.debhelper/generated/_source/home/.gkrellm2/plugins/gkleds.so


The attached patch fixes this by removing the UID check in the Makefile,
which only behaves "correctly" when run under bash (when run under dash
$UID is unset).

Since the .deb package should always install into
/usr/lib/gkrellm2/plugins, regardless of the running UID, removing the
check seems appropriate, especially as "Rules-Requires-Root: no" is set
in debian/control.


With this patch applied, gkrellm-leds should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining gkrellm-leds!


live well,
  vagrant

#1003430#10
Date:
2022-01-14 19:42:03 UTC
From:
To:
Vagrant Cascadian wrote...

Ups. Thanks for spotting this. Will be fixed in the next upload which
might take some time. Ping me if you want that story resolved faster.

    Christoph