Fabre

#1004048 golang-github-komkom-toml: autopkgtest regression on armhf/i386: -{"hex3":3735928559}, +{"hex3":-559038737} #1004048

Package:: src:golang-github-komkom-toml

Source:: golang-github-komkom-toml

Submitter:: Paul Gevers

Date:: 2022-06-20 10:06:06 UTC

Severity:: serious

#1004048#5

Date:: 2022-01-19 21:23:56 UTC

From:

To:

Dear maintainer(s),

With a recent upload of golang-github-komkom-toml the autopkgtest of
golang-github-komkom-toml fails in testing when that autopkgtest is run
with the binary packages of golang-github-komkom-toml from unstable on
armhf and i386. It passes when run with only packages from testing. In
tabular form:

                           pass            fail
golang-github-komkom-toml from testing    0.0~git20211215.3c8ee9d-1
all others                from testing    from testing

I copied some of the output at the bottom of this report. Seems like a
32 bit issue where some value overflows.

Currently this regression is blocking the migration to testing [1]. Can
you please investigate the situation and fix it?

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul

[1] https://qa.debian.org/excuses.php?package=golang-github-komkom-toml

https://ci.debian.net/data/autopkgtest/testing/armhf/g/golang-github-komkom-toml/18432554/log.gz

[info] Testing github.com/komkom/toml...
[info] Source code installed by binary package, overriding
dh_auto_configure...
dh build --builddirectory=_build --buildsystem=golang --with=golang
    dh_update_autotools_config -O--builddirectory=_build
-O--buildsystem=golang
    dh_autoreconf -O--builddirectory=_build -O--buildsystem=golang
    debian/rules override_dh_auto_configure
make[1]: Entering directory
'/tmp/autopkgtest-lxc.qwkbqa0f/downtmp/autopkgtest_tmp'
mkdir -p "_build"
cp -a /usr/share/gocode/src "_build"
make[1]: Leaving directory
'/tmp/autopkgtest-lxc.qwkbqa0f/downtmp/autopkgtest_tmp'
    dh_auto_build -O--builddirectory=_build -O--buildsystem=golang
	cd _build && go install -trimpath -v -p 160 github.com/komkom/toml
github.com/komkom/toml/internal
unicode/utf8
internal/unsafeheader
internal/goexperiment
math/bits
runtime/internal/sys
internal/itoa
internal/race
internal/abi
internal/cpu
sync/atomic
unicode
runtime/internal/math
math
runtime/internal/atomic
internal/bytealg
runtime
internal/reflectlite
sync
internal/testlog
errors
sort
internal/oserror
path
io
strconv
syscall
bytes
strings
reflect
internal/syscall/execenv
internal/syscall/unix
time
io/fs
internal/poll
internal/fmtsort
os
fmt
github.com/pkg/errors
github.com/komkom/toml/internal
github.com/komkom/toml
    dh_auto_test -O--builddirectory=_build -O--buildsystem=golang
	cd _build && go test -vet=off -v -p 160 github.com/komkom/toml
github.com/komkom/toml/internal
=== RUN   TestReader
     reader_test.go:169: doc a."b".d=2
     reader_test.go:169: doc a.'b.c.d'.d=2
         																	a.b.c.d=2
     reader_test.go:169: doc a."\uFFFF".c=1
     reader_test.go:169: doc a."\UD7FF16".c=1
     reader_test.go:169: doc key = """\uFFFF"""
     reader_test.go:169: doc key = """\UD7FF16"""
     reader_test.go:169: doc key = [0,1,2,3,4]
     reader_test.go:169: doc key = [1,2,3,4,0]
     reader_test.go:169: doc key={a=0}
     reader_test.go:169: doc key-test=1
     reader_test.go:169: doc k.e .y=1
     reader_test.go:169: doc    k  .  e .y=1
     reader_test.go:169: doc    "k"  .  'e'  .y=1
     reader_test.go:169: doc animal = { type.name = "pug"}
     reader_test.go:169: doc key = {v.y=1}
     reader_test.go:169: doc a = "\r"
     reader_test.go:169: doc another = "# test"
     reader_test.go:169: doc 'quoted "value"' = "value"
     reader_test.go:169: doc hex3 = 0x123_123
     reader_test.go:169: doc hex3 = 0xdead_beef
     reader_test.go:184:         	Error Trace:	reader_test.go:184
         	Error:      	Not equal:         	            	expected:
"{\"hex3\":3735928559}"
         	            	actual  : "{\"hex3\":-559038737}"

         	            	Diff:
         	            	--- Expected
         	            	+++ Actual
         	            	@@ -1 +1 @@
         	            	-{"hex3":3735928559}
         	            	+{"hex3":-559038737}
         	Test:       	TestReader
     reader_test.go:169: doc flt9 = -0e0
     reader_test.go:169: doc sf6 = -nan
     reader_test.go:169: doc sf6 = +nan
     reader_test.go:169: doc k = 0e0
     reader_test.go:169: doc sf6 = +inf
     reader_test.go:169: doc sf6 = -inf
     reader_test.go:169: doc sf6 = inf
     reader_test.go:169: doc key = """a b c \
         									ooo"""
     reader_test.go:169: doc key = """value  \
         					                        """
     reader_test.go:169: doc [x.y.z.w] # for this to work
         					[x]
     reader_test.go:169: doc "key\r\n"=1
     reader_test.go:169: doc key="""value\r\n"""
     reader_test.go:169: doc [[arr.x]]
         				[arr.x.table]
         				[[arr.x]]
         				[arr.x.table]
         				[x]
         				[[arr.x]]
--- FAIL: TestReader (0.00s)
=== RUN   TestSpecs_valid
     reader_test.go:207: files 0
--- PASS: TestSpecs_valid (0.00s)
=== RUN   TestSpecs_invalid
--- PASS: TestSpecs_invalid (0.00s)
=== RUN   ExampleReader
--- PASS: ExampleReader (0.00s)
FAIL
FAIL	github.com/komkom/toml	0.013s

#1004048#12

Date:: 2022-06-20 09:38:17 UTC

From:

To:

Hello,

Bug #1004048 in golang-github-komkom-toml reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/go-team/packages/golang-github-komkom-toml/-/commit/29928b19c53475f93d08882504b9722dda3a3b0a
------------------------------------------------------------------------
Fix failing tests on 32 bit architectures

Closes: #1004048
Origin: upstream, https://github.com/komkom/toml/pull/6
Signed-off-by: Benjamin Drung <bdrung@debian.org>
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1004048

#1004048#19

Date:: 2022-06-20 10:04:39 UTC

From:

To:

We believe that the bug you reported is fixed in the latest version of
golang-github-komkom-toml, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1004048@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Benjamin Drung <bdrung@ubuntu.com> (supplier of updated golang-github-komkom-toml package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Mon, 20 Jun 2022 11:34:59 +0200
Source: golang-github-komkom-toml
Built-For-Profiles: noudeb
Architecture: source
Version: 0.0~git20211215.3c8ee9d-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed-By: Benjamin Drung <bdrung@ubuntu.com>
Closes: 1004048
Changes:
 golang-github-komkom-toml (0.0~git20211215.3c8ee9d-2) unstable; urgency=medium
 .
   * Team upload
   * Fix failing tests on 32 bit architectures (Closes: #1004048)
Checksums-Sha1:
 2103a0015811204d1d7225c5cdea5552251093db 2388 golang-github-komkom-toml_0.0~git20211215.3c8ee9d-2.dsc
 9e2f763f5cda23b772c9f403abaceafb89d6982c 4268 golang-github-komkom-toml_0.0~git20211215.3c8ee9d-2.debian.tar.xz
 cb94d24af258ccd94d7413a16d16725d7a1d1d50 6814 golang-github-komkom-toml_0.0~git20211215.3c8ee9d-2_source.buildinfo
Checksums-Sha256:
 5cdb8d3686a5bde0f230b34674c5bdb0d69d39cd0c21b1d34e4dba471e6aabea 2388 golang-github-komkom-toml_0.0~git20211215.3c8ee9d-2.dsc
 26e0f41e6725b945eab890d9455493b5478118b7f726db38d5938ebc5e5c0823 4268 golang-github-komkom-toml_0.0~git20211215.3c8ee9d-2.debian.tar.xz
 ca5c47d5b70e65d17cc25e3abe7dc10c187fa92f0836860ef02c08f862debc55 6814 golang-github-komkom-toml_0.0~git20211215.3c8ee9d-2_source.buildinfo
Files:
 85c82ddd5acd034a03fa19bc70905af9 2388 devel optional golang-github-komkom-toml_0.0~git20211215.3c8ee9d-2.dsc
 c453d958a4a254ca9a0d6635db1ebc5e 4268 devel optional golang-github-komkom-toml_0.0~git20211215.3c8ee9d-2.debian.tar.xz
 790a8237e2dc47cf87aee355ded003ee 6814 devel optional golang-github-komkom-toml_0.0~git20211215.3c8ee9d-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEpi0s+9ULm1vzYNVLFZ61xO/Id0wFAmKwQEsACgkQFZ61xO/I
d0z3HhAAqdc0w880viXvk9dsVRM8n4z/ItiBzcoRDRV3/DvzYtnUMzqNcOJ+RBgK
cM0RinKzrEHvVJXaNRwGnCDlNGD/kaEGN87bWGCLA91CjnSlo0rhURoJ0sc3FsVL
0h9Fc4D4OPgPDEnYjSeOvhShxK/STSb0GE07f3NUJAWIXjg5U6ontaqDW5ijpynl
xE/fNfA0i0oFC+5ZJ9k/2fMwy5J68xeD1wL2KxwDJDnQHvgWMhJ7Plx0KeOFiDEy
Qowobzhkkkz8mjkC1B+72IlnhiwJ78VIcOLK97DzSfmef27iM92bSqfrOCUGJTsA
mSULARvDSrtgJpn2edv4a+RJmWr3iEHlW7uXNxJFvlCgaNVtvR/tuOiUswAv+DEN
0C+z6mRGJ/7GGktI14BH84O8G81sN+rHOMbOEmjfif95IKW6HgVuKIvKyPyt00nR
mB0s0hh0WTLuSrZdL/snTqhLbDTjBwJxjjm/AamN4pW+lqXFb50HsQrT1/AiUePQ
sDq9RyBIz2fs7pIC/cYDnnrnxGwl9HLpfXvUjuoFyhh6njhV8Enh35obp5ZQgtLI
dOi01IgnQzhzcVNiBjQsJomwN5yMA9TtmOnLwnGKzrNV7GJI0+4HhnDM5Hpbqb7t
al7wlfdkV3qhsptXKlWHMcnwNYya1kWEcJyTHYuFRActVNTfx7Q=
=FlMh
-----END PGP SIGNATURE-----

#1004048 golang-github-komkom-toml: autopkgtest regression on armhf/i386: -{"hex3":3735928559}, +{"hex3":-559038737} #1004048

Just Reply to ...

Reply to submitter ...

Send control command (Silently)

Set Architecture Tags (Silently)