#1006389 libdigidoc: FTBFS with OpenSSL 3.0

Package:
src:libdigidoc
Source:
libdigidoc
Submitter:
Sebastian Andrzej Siewior
Date:
2022-07-01 17:39:03 UTC
Severity:
serious
Tags:
#1006389#5
Date:
2022-02-24 20:20:52 UTC
From:
To:
Your package is failing to build using OpenSSL 3.0 with the
following error:

| [ 76%] Building C object libdigidoc/CMakeFiles/digidoc.dir/DigiDocOCSP.c.o
| cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/libdigidoc && /usr/bin/cc -DBUILD_DATE=\"31.12.2020\" -DBUILD_VER=0 -DMAJOR_VER=3 -DMINOR_VER=10 -DRELEASE_VER=5 -DVER_SUFFIX=\"\" -Ddigidoc_EXPORTS -I/<<PKGBUILDDIR>> -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/usr/include/libxml2 -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fvisibility=hidden -MD -MT libdigidoc/CMakeFiles/digidoc.dir/DigiDocOCSP.c.o -MF CMakeFiles/digidoc.dir/DigiDocOCSP.c.o.d -o CMakeFiles/digidoc.dir/DigiDocOCSP.c.o -c /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c
…
| In file included from /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:38:
| /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:983:37: error: ‘OCSP_R_SERVER_RESPONSE_PARSE_ERROR’ undeclared (first use in this function); did you mean ‘OCSP_R_SERVER_READ_ERROR’?
|   983 |     OCSPerr(OCSP_F_OCSP_SENDREQ_BIO,OCSP_R_SERVER_RESPONSE_PARSE_ERROR);
|       |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:983:37: note: each undeclared identifier is reported only once for each function it appears in
| /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:1022:37: error: ‘OCSP_R_SERVER_RESPONSE_ERROR’ undeclared (first use in this function); did you mean ‘OCSP_R_SERVER_READ_ERROR’?
|  1022 |     OCSPerr(OCSP_F_OCSP_SENDREQ_BIO,OCSP_R_SERVER_RESPONSE_ERROR);
|       |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| In file included from /<<PKGBUILDDIR>>/libdigidoc/DigiDocLib.h:36,
|                  from /<<PKGBUILDDIR>>/libdigidoc/DigiDocConfig.h:29,
|                  from /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:23:
| /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c: In function ‘verifyOCSPResponse’:
| /<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c:1603:31: warning: passing argument 1 of ‘ossl_check_X509_type’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
…
| make[3]: *** [libdigidoc/CMakeFiles/digidoc.dir/build.make:317: libdigidoc/CMakeFiles/digidoc.dir/DigiDocOCSP.c.o] Error 1
| make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
| make[2]: *** [CMakeFiles/Makefile2:131: libdigidoc/CMakeFiles/digidoc.dir/all] Error 2
| make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
| make[1]: *** [Makefile:139: all] Error 2
| make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
| dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j1 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2

For more information see:
https://www.openssl.org/docs/man3.0/man7/migration_guide.html

Sebastian
#1006389#14
Date:
2022-06-28 20:18:30 UTC
From:
To:
The following patch resolves the FTBFS:

```
Description: Resolve FTBFS with OpenSSL v3
 This package uses some deprecated OCSP constants. There is a history
 of defining them manually once they are removed from openssl. This
 patch continues that behavior with two additional constants that
 are not defined in openssl v3
Author: William 'jawn-smith' Wilson <jawn-smith@ubuntu.com>
Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1006389
Last-Update: 2022-06-28
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
Index: libdigidoc-3.10.5/libdigidoc/DigiDocOCSP.c
===================================================================
--- libdigidoc-3.10.5.orig/libdigidoc/DigiDocOCSP.c
+++ libdigidoc-3.10.5/libdigidoc/DigiDocOCSP.c
@@ -109,6 +109,8 @@
 # define OCSP_R_NO_CONTENT                                106
 # define OCSP_F_OCSP_SENDREQ_BIO                          112
 # define OCSP_R_SERVER_READ_ERROR                         113
+# define OCSP_R_SERVER_RESPONSE_ERROR                     114
+# define OCSP_R_SERVER_RESPONSE_PARSE_ERROR               115
 # define OCSP_R_SERVER_WRITE_ERROR                        116
 #endif
```
libdigidoc/CMakeFiles/digidoc.dir/DigiDocOCSP.c.o
-DBUILD_DATE=\"31.12.2020\" -DBUILD_VER=0 -DMAJOR_VER=3 -DMINOR_VER=10
-DRELEASE_VER=5 -DVER_SUFFIX=\"\" -Ddigidoc_EXPORTS -I/<<PKGBUILDDIR>>
-I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/usr/include/libxml2 -g -O2
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC
-fvisibility=hidden -MD -MT
libdigidoc/CMakeFiles/digidoc.dir/DigiDocOCSP.c.o -MF
CMakeFiles/digidoc.dir/DigiDocOCSP.c.o.d -o
CMakeFiles/digidoc.dir/DigiDocOCSP.c.o -c
/<<PKGBUILDDIR>>/libdigidoc/DigiDocOCSP.c
‘OCSP_R_SERVER_RESPONSE_PARSE_ERROR’ undeclared (first use in this
function); did you mean ‘OCSP_R_SERVER_READ_ERROR’?
OCSPerr(OCSP_F_OCSP_SENDREQ_BIO,OCSP_R_SERVER_RESPONSE_PARSE_ERROR);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
identifier is reported only once for each function it appears in
‘OCSP_R_SERVER_RESPONSE_ERROR’ undeclared (first use in this function);
did you mean ‘OCSP_R_SERVER_READ_ERROR’?
OCSPerr(OCSP_F_OCSP_SENDREQ_BIO,OCSP_R_SERVER_RESPONSE_ERROR);
‘verifyOCSPResponse’:
argument 1 of ‘ossl_check_X509_type’ discards ‘const’ qualifier
from pointer target type [-Wdiscarded-qualifiers]
libdigidoc/CMakeFiles/digidoc.dir/DigiDocOCSP.c.o] Error 1
libdigidoc/CMakeFiles/digidoc.dir/all] Error 2
"INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2
#1006389#19
Date:
2022-07-01 17:35:24 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
libdigidoc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1006389@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
William 'jawn-smith' Wilson <jawn-smith@ubuntu.com> (supplier of updated libdigidoc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Tue, 28 Jun 2022 15:07:48 -0500
Source: libdigidoc
Built-For-Profiles: noudeb
Architecture: source
Version: 3.10.5-3
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: William 'jawn-smith' Wilson <jawn-smith@ubuntu.com>
Closes: 1006389
Changes:
 libdigidoc (3.10.5-3) unstable; urgency=medium
 .
   * QA upload.
   * Resolve FTBFS with openssl v3 (Closes: #1006389)
   * d/control: Update Standards-Version to 4.6.1, no changes needed
   * d/control: Mark libdigidoc-doc as Multi-Arch: foreign and mark
     libdigidoc-dev as Multi-Arch: same
   * d/patches/fix-national-encoding.patch: Fix national-encoding
     warning by correctly encoding as UTF-8
   * d/rules: Drop override_dh_strip, ddeb migration is complete
Checksums-Sha1:
 023f1b97c818ee1aeb225bd33e9e473bf1f5c70e 2180 libdigidoc_3.10.5-3.dsc
 0193f449be951552c42a8c7b0f4024696439534a 4136 libdigidoc_3.10.5-3.debian.tar.xz
Checksums-Sha256:
 b6c360edc2fee4a6e26a1a3275112031fd728125d7d0d090e099dec0d4bf4c82 2180 libdigidoc_3.10.5-3.dsc
 1adc5f886b69fbf69929b78b5b1ee7dc06526e752cda7f70e6f65c4086100367 4136 libdigidoc_3.10.5-3.debian.tar.xz
Files:
 65b81fa77c9ce8a30481b7d3bbd87bfe 2180 libs optional libdigidoc_3.10.5-3.dsc
 55c57aa08608a2be48cc40f1220a3230 4136 libs optional libdigidoc_3.10.5-3.debian.tar.xz
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEJeP/LX9Gnb59DU5Qr8/sjmac4cIFAmK/LXEACgkQr8/sjmac
4cK+8BAAwELbTemvzvkJ+DgRUDhxjDs1fX7y1O/qltUrvO0EMx5bEoPuc2svIfn4
IoGkr7EN3IG5Uf5BGIuREJvFIbur+zKoqALadzUSDZ+A0+sma9EKCmQgJ9WNeVKC
kCL48fbr4+LaiUJwbilq6IKjXVPqrcEXm2pbb6i8vhlFY3/r2EoHROKoCH0grxwS
e2aafUxpDen92Pmyr+I/0AhTzv/i/Qxp0XlJyZnEYjOYackHvVMjbNA8yNXqbRDA
9pZCunI58pMmku63+Fl+yo2+CQ9H4NstJwlNPATt5LLDfUbPChN1pCRXmqtoyiFd
eBIyFndyAXh6j+oqKVshOPsDTXjze3btbTvvPT2GDPMf/8pF12Y6FbCTWX3khFRI
qWJxfXBarqgXbj/WNVKtL2rnOaAMYi7BeNywp0oOlXw6k9CjlHVkIqSAUl5sksnQ
EV3iKiJK0H55x9mHoGRwOUPy3h5O/Rr2s5eJMqLdlXM6Yi8EQmVddnfpYOK8dDuO
g+S8c4safiv7eGDewUUgiELU8Rn+WpbOhi6MIy+74fzh0IAjpTiIH44t762uOcET
PPPpvLD3Il2uX0UcCzinmb/SjjmEfJJxkgp/UpWofIPDtM0t3zIKHpdA59CP5DIb
P1Gu/kZ6jucmoxFvTXRJh3uAF7JVo2UYPvF5cxcvFYsXwVtJTEc=
=pWJx
-----END PGP SIGNATURE-----