#1006582 xir: FTBFS with OpenSSL 3.0

Package:
src:xir
Source:
xir
Submitter:
Sebastian Andrzej Siewior
Date:
2022-05-22 21:24:03 UTC
Severity:
serious
Tags:
#1006582#5
Date:
2022-02-27 22:52:14 UTC
From:
To:
Your package is failing to build using OpenSSL 3.0 with the
following error:

| [ 21%] Building CXX object src/xir/CMakeFiles/xir.dir/util/tool_function.cpp.o
| cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/xir && /usr/bin/c++ -DGFLAGS_IS_A_DLL=0 -DGOOGLE_GLOG_DLL_DECL="" -DGOOGLE_GLOG_DLL_DECL_FOR_UNITTESTS="" -Dxir_EXPORTS -I/<<PKGBUILDDIR>>/include -I/<<PKGBUILDDIR>>/src -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/xir -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++14 -Wall -Werror -std=c++17 -Wall -Werror -ggdb -O0 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -fno-inline -fPIC -MD -MT src/xir/CMakeFiles/xir.dir/util/tool_function.cpp.o -MF CMakeFiles/xir.dir/util/tool_function.cpp.o.d -o CMakeFiles/xir.dir/util/tool_function.cpp.o -c /<<PKGBUILDDIR>>/src/xir/util/tool_function.cpp
| /<<PKGBUILDDIR>>/src/xir/util/tool_function.cpp: In function ‘const string xir::get_md5_of_file(const string&)’:
| /<<PKGBUILDDIR>>/src/xir/util/tool_function.cpp:46:11: error: ‘int MD5_Init(MD5_CTX*)’ is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|    46 |   MD5_Init(&md5_context);
|       |   ~~~~~~~~^~~~~~~~~~~~~~
| In file included from /<<PKGBUILDDIR>>/src/xir/util/tool_function.cpp:18:
| /usr/include/openssl/md5.h:49:27: note: declared here
|    49 | OSSL_DEPRECATEDIN_3_0 int MD5_Init(MD5_CTX *c);
|       |                           ^~~~~~~~
| /<<PKGBUILDDIR>>/src/xir/util/tool_function.cpp:48:15: error: ‘int MD5_Update(MD5_CTX*, const void*, size_t)’ is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|    48 |     MD5_Update(&md5_context, buffer, read_size);
|       |     ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| In file included from /<<PKGBUILDDIR>>/src/xir/util/tool_function.cpp:18:
| /usr/include/openssl/md5.h:50:27: note: declared here
|    50 | OSSL_DEPRECATEDIN_3_0 int MD5_Update(MD5_CTX *c, const void *data, size_t len);
|       |                           ^~~~~~~~~~
| /<<PKGBUILDDIR>>/src/xir/util/tool_function.cpp:51:12: error: ‘int MD5_Final(unsigned char*, MD5_CTX*)’ is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|    51 |   MD5_Final(md5sum, &md5_context);
|       |   ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
| In file included from /<<PKGBUILDDIR>>/src/xir/util/tool_function.cpp:18:
| /usr/include/openssl/md5.h:51:27: note: declared here
|    51 | OSSL_DEPRECATEDIN_3_0 int MD5_Final(unsigned char *md, MD5_CTX *c);
|       |                           ^~~~~~~~~
| cc1plus: all warnings being treated as errors
| make[3]: *** [src/xir/CMakeFiles/xir.dir/build.make:165: src/xir/CMakeFiles/xir.dir/util/tool_function.cpp.o] Error 1

For more information see:
https://www.openssl.org/docs/man3.0/man7/migration_guide.html

Sebastian

#1006582#14
Date:
2022-05-22 19:37:58 UTC
From:
To:
Dear maintainer,

I've prepared an NMU for xir (versioned as 1.4.1-5.1) and uploaded
it to DELAYED/2. Please feel free to tell me if I should cancel it.

cu
Adrian

#1006582#23
Date:
2022-05-22 20:43:51 UTC
From:
To:
Hi Adrian,

Thank you for the patch and the NMU.
I've had a quick look and don't see an issue with the changes. No need to
cancel the NMU.

I'll also probably port the patch to the new upstream release if it's still
not working with OpenSSL 3.0.

Thanks,
Punit

#1006582#28
Date:
2022-05-22 20:55:21 UTC
From:
To:
Hi Punit,

thanks, rescheduled for immediate upload.

cu
Adrian

#1006582#33
Date:
2022-05-22 21:21:36 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
xir, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1006582@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adrian Bunk <bunk@debian.org> (supplier of updated xir package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sun, 22 May 2022 22:34:37 +0300
Source: xir
Architecture: source
Version: 1.4.1-5.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Xilinx Package Maintainers <team+pkg-xilinx@tracker.debian.org>
Changed-By: Adrian Bunk <bunk@debian.org>
Closes: 1006582
Changes:
 xir (1.4.1-5.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Don't build with -Werror. (Closes: #1006582)
Checksums-Sha1:
 0d6840b4b7cbcb818a6c66a1ef423fd9f8ec4829 2225 xir_1.4.1-5.1.dsc
 83972b0d1fa9c4dab08967eb475647ff351fdcf7 6132 xir_1.4.1-5.1.debian.tar.xz
Checksums-Sha256:
 e76a9d7fce451c746a370d6af155a65b338e62c310e4daf6c0e4e99237ac2015 2225 xir_1.4.1-5.1.dsc
 f080f8c8e1ca3b708268bbe7c95f7fc813b5f6720f05c0d7f1ebd0b0a97c381c 6132 xir_1.4.1-5.1.debian.tar.xz
Files:
 63e1e883238fc508dfe5e4f3afa9abf8 2225 libs optional xir_1.4.1-5.1.dsc
 323cbeb1477e9fbc724f9555c804e41b 6132 libs optional xir_1.4.1-5.1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEOvp1f6xuoR0v9F3wiNJCh6LYmLEFAmKKkPUACgkQiNJCh6LY
mLF5og/8D6OiCbjtvAYIG41o+zwn10pkKAr3fE+OxwJ+YRGoPZz7ecQvTnyf8GCy
Aqq/eU292RLMKaq5fjKSRL55Zylh5SJ+8AUa6Tnor/l3t254WIF7h4dlVbX/3rx0
g3Ww3LDfFKeTRNCFjiwt1pnhpj3xgisHhZpjpcG9Wr25Tk2tt9RaxQNeIx4b3cc8
4MlYVSQnPCOvZPAw1LXE6HV65cgfrbRtLMRPNQQcdEeaxtM+Nj0/AtUt3OLSgWb0
9Mip9sLx4N1QjcyaFTue56uvWJA8KANLVW72M7xpo88M22DYY0KEFekgSZVA3xMR
NT1EjfcQJFZtavUaFvN4IBBqNWwXz51QbXYLkWhq+WO0vUE2yPQMA2VcxJHjQCTd
Hp4JOAUyD7UCoRHj524hd6iGNo8ZTk+w0/bOAe4qbjZo/c4gTAcK1Y4b7tpvxQ71
eZCiCqNnQoKnxEm+i7EVkTYRcoD6RDvhwFcfM3p/UPmgqIErzjjb6rBkjD61dlaL
NhrG8hbPy7SkEjSMwnl1Gh8VugG6rEGx+3mFGZMHjBUTctDvV9+ZQDzLq1TkzpWR
hQDI7y2VvI99E77yBXnuaI3PBxNfBvp5eAmj6aR3qnXTY0E9kk0ONHyEoI5eyd/r
hZLYDbhjdZs1PYed/UyMjrr9cbtFYLu4tbBVl699gPL8si0cVuQ=
=3CJz
-----END PGP SIGNATURE-----