#1006687 libchipcard6: card.c leaks memory

Package:
libchipcard6
Source:
libchipcard
Description:
library for accessing smartcards
Submitter:
Michael Klein
Date:
2022-03-02 20:06:03 UTC
Severity:
normal
Tags:
#1006687#5
Date:
2022-03-02 12:36:56 UTC
From:
To:
Dear Maintainer,

while running a small inhouse application under AddressSanitizer I
stumbled over a few small memory leaks in card.c:

- the LC_CARD struct members readerType and driverType are not freed in
  LC_Card_free()
- LC_Card_Select{Df,Ef,EfById}() leaks a GWEN_BUFFER local to the function

#1006687#10
Date:
2022-03-02 20:02:52 UTC
From:
To:
Hi Michael,

thank you for reporting the issue to the Debian bug tracker. Assuming
your consent to distributing your patch under the LGPL v2.1 license, I
dared to commit it to the upstream Git repository on branch
"libchipcard5", which you can find here:
https://www.aquamaniac.de/rdm/projects/libchipcard/repository/revisions/913b862a8a0678be0a2bd9f85213dea24081e2bf/diff/src/lib/client/base/card.c

Unfortunately the patch didn't apply cleanly to the master branch. The
file card.c was since moved to src/libchipcard/base/card.c, yet changed
substantially so that a careful review would be appropriate.

Nevertheless, thank you to your contribution to Debian and Libchipcard.

Kind regards,
Micha

Am 02.03.22 um 13:36 schrieb Michael Klein: