#1010369 RediSearch Upstream Needs Swapped out from version 1 to version 2

Package:
redis-redisearch
Source:
redisearch
Description:
Full-text and secondary search index engine module for Redis
Submitter:
"Kevin Shenk"
Date:
2023-06-12 20:03:02 UTC
Severity:
normal
#1010369#5
Date:
2022-04-29 16:24:06 UTC
From:
To:
Currently, this package is obviously packaging the now deprecated version 1 source at https://github.com/goodform/RediSearch.git

This should be swapped out for the new version 2 upstream at https://github.com/RediSearch/RediSearch.git


[6c226525-c069-48e9-868b-fcc792609f12]
#1010369#10
Date:
2022-04-30 00:21:03 UTC
From:
To:
Hi Kevin,

Indeed, and I'd love to be able to do that, but the license of this
version is not compatible with the Debian Free Software Guidelines
(DFSG).


Regards,
#1010369#15
Date:
2022-04-30 14:03:31 UTC
From:
To:
I see, that's too bad... is it easy to specify what the Redis Ltd would need to change to make their license compatible?
--
Kevin Shenk
Avunu LLC
Chris Lamb wrote:
Hi Kevin,
Currently, this package is obviously packaging the now deprecated
version 1 source at https://github.com/goodform/RediSearch.git
This should be swapped out for the new version 2 upstream at
https://github.com/RediSearch/RediSearch.git
Indeed, and I'd love to be able to do that, but the license of this
version is not compatible with the Debian Free Software Guidelines
(DFSG).
Regards,
#1010369#20
Date:
2022-05-01 00:17:03 UTC
From:
To:
Hi,

Yes, but that's not quite the issue. They are already aware of the
situation and (to reduce a very long and complex discussion into a
single sentence) the license incompatibility is essentially deliberate
and not an accidental oversight.


Regards,
#1010369#25
Date:
2022-05-02 13:01:36 UTC
From:
To:
Gotcha. That's too bad. Thanks much for your clarifications!


Yes, but that's not quite the issue. They are already aware of the
situation and (to reduce a very long and complex discussion into a
single sentence) the license incompatibility is essentially deliberate
and not an accidental oversight.


Regards,
#1010369#30
Date:
2023-06-10 14:20:33 UTC
From:
To:
Hi,

Redisearch 2 is not compatible with 1.x: v2 dropped support for NOSAVE,
which makes existing code fail. See
https://github.com/RediSearch/RediSearch/issues/1640

Also upstream repo seems to have changed:
https://github.com/goodform/RediSearch points to http://redisearch.io/
which redirects to https://redis.io/docs/stack/search/ which points to
https://github.com/RediSearch/RediSearch.
#1010369#35
Date:
2023-06-12 19:52:34 UTC
From:
To:
Hi,

Since I'm about to build redisearch for Guix, I digged deeper into this
rabbit hole. So here for the records (you, Chris, most probably already
know this):

https://github.com/goodform/RediSearch is a fork based on the old open
source license (AGPL).

Last common commit is
<https://github.com/goodform/RediSearch/commit/cc54f9b6ddcf0b6ef82e9b76e803b184d01d1b02>
which is 179 commits after v1.2.0. This very commit is the last one
before change of the license in https://github.com/RediSearch/RediSearch.

In https://github.com/goodform/RediSearch there is a v1.2.2 dated
2020-04-03. As of today, there is a single commit after that, also dated
2020-04-03, which is a dummy merge.

The test-suite requires https://github.com/RedisLabs/rmtest. which is
deprecated and unmaintained. PyPI has a 0.7.0, which is not tagged in
the repo and which still requires Python-2.  Commit
c0d79ec29461942c11eec86e953cc0a904046230 is what would be version 1.0.0
if that would have been tagged and supports Python3. Since this commit
only a few commits have been added.

For running the test-suite for rmtest, some adjustments need to be made,
esp. one test does not fit the API at all.

Anyhow, running the test-suite for redisearch is not easily possible:
The tests require a python module "reds._compat", which was removed in
python-redis 4.0.