Dear mentors,

I am looking for a sponsor for my package "davegnukem":

 * Package name    : davegnukem
   Version         : 1.0.1-1
   Upstream Author : David Joffe <david at djoffe.com>
 * URL             : https://djoffe.com/gnukem/
 * License         : Expat or GPL-2 or GPL-3, CC0-1.0, CC-BY-3.0
   Section         : games

The source builds the following binary packages:

  davegnukem - Retro-style 2D scrolling platform shooter
  davegnukem-data - Data files for davegnukem

To access further information about this package, please visit the following URL:

https://mentors.debian.net/package/davegnukem/

Alternatively, you can download the package with 'dget' using this command:

  dget -x https://mentors.debian.net/debian/pool/main/d/davegnukem/davegnukem_1.0.1-1.dsc

Changes for the initial release:

 davegnukem (1.0.1-1) unstable; urgency=low
 .
   * Initial release (Closes: #1009780)

Regards,

Hi!
I'm afraid the package fails to build:

In file included from src/sys_log.cpp:22:
src/m_aliases.h:19:17: error: unnamed scoped enum is not allowed
   19 | #define byte    unsigned char
      |                 ^~~~~~~~
src/m_aliases.h:19:17: error: expected identifier before ‘unsigned’
In file included from /usr/include/c++/11/cmath:42,
                 from /usr/include/c++/11/math.h:36,
                 from src/sys_defs.h:37,
                 from src/sys_log.cpp:25:
/usr/include/c++/11/bits/cpp_type_traits.h:404:19: error: expected unqualified-id before ‘:’ token
  404 |   enum class byte : unsigned char
... and so on


Meow!

himself in the m_aliases header.

I noticed this issue Friday and I plan to send a patch to upstream this week.
Then I'll probably patch the package as well. I'll keep you posted.

It turned out that upstream already fixed this bug in a non-released commit, so
all I had to do was patch the package.

Now davegnukem/1.0.1-1 correctly builds on unstable.
Merry Sunday.

Hi Matteo,

Can you please use the sourceforge released files? There are some diffs to the GitHub download fixing the versio number.
Please include gnukem_datasrc as well because we need the source files even if we do not build the Photoshop files
automatically.

Do we really want new libsdl1.2 packages in the archive? I do not have a strong opinion on this. Can you please try to
use the sdl12-compat packages for the build?

Thanks,
Bastian

Hi Bastian.

I've uploaded a new version on mentors, using the SourceForge source but
keeping the GitHub watch file, since it's where there's the most code activity
due to issues and pull requests, and I've included gnukem_datasrc files as
well.

I've tried building with libsdl1.2-compat, however with the compatibility
wrapper the game does not scale to the window size anymore: the window is black
except for the 320x200 top left corner, where the game is running at base
resolution. Besides, even if it would've worked, this package depends on
libsdl-mixer1.2 too which can't be replaced by the compatibility wrapper.

If you think that SDL 1.2 is too old and that new packages shouldn't use it,
I will try to contact upstream to ask to port davegnukem to SDL 2.0.
Thanks for your help!

The watch file is about watching and downloading releases, not code activity.
And this project releases the source packages on Sourceforge. Please use the
attached watch file. That does not repack the data component adding the src component
but has a separate component.

Actually, looking at man uscan I wanted to set the version parameter for the data
component to "same" but that did not work as expected.

Please do not manually repack things when it is not necessary like in this case.
When you have to do that, add a README.source on how to do it.

Please install HISTORY.txt as upstream changelog, not just a plain doc.

d/copyright
===========
I do not see the following license comment represented by the current d/copyright:
"2018-03-22 Add boots sprite made by freepik.com, from flaticon.com, license Creative Commons BY 3.0"

Where do you get the possible GPL license versions from? I cannot find them.

It is usually not a good idea to have debian/* licensed under a license that is only compatible with
a subset of the upstream license. I would really like to see your contribution relicensed to Expat or the exact
combination that upstream is licensed under.

I've switched to the watch file you've attached in the previous email.

I've added another component for the datasrc files.

I'm going to ask upstream about SDL 2.0. It shouldn't be too hard, I've looked
into it a bit by myself.

I do already install HISTORY.txt as upstream changelog. According to
dh_installchangelogs man page [1], files named changelog, changes or history
get installed as changelogs.

I've added the boots sprite license in d/copyright.

According to Dave Gnukem web page [2], the game is licensed under Expat or GPL
version 2 or 3, except for the assets listed in the README.md file:
"The source code is dual-licensed: MIT license, or GPL (GNU General Public
License) version 2 or 3. The data file licenses are all open source but are a
bit more 'mixed' due to being from multiple sources, which have been
documented. Please see the section at the bottom of the included README.md for
finer details, as music, and a few sprites, have slightly varying
origins/terms.".

I've changed the license of the debian dir files to Expat.

That should be all. Thank you again for your support!

We do not need the datasrc binary package; the files in the source package are enough.
I have uploaded the package without it.