#1010764 openafs-modules-dkms: module fails to build for kernel 5.17.0-1-amd64

Package:
openafs-modules-dkms
Source:
openafs
Submitter:
Kai-Martin Knaak
Date:
2022-06-21 00:09:26 UTC
Severity:
serious
Tags:
#1010764#5
Date:
2022-05-09 16:09:56 UTC
From:
To:
Dear Maintainer,

   * What led up to the situation?
   - regular apt upgrade on testing

   * What exactly did you do that was effective?
   - switch to kernel 5.16.0-6-amd64
     The module built fine for this slightly older kernel.

   * What was the outcome of this action?
   - I am unable to use openafs with kernel 5.17

   * What outcome did you expect instead?
   - a working openafs module for kernel 5.17

/var/lib/dkms/openafs/1.8.8.1/build/make.log seems to indicate a problem with
the function complete_and_exit() in afs_call_nfs.c :
-----------------------------------
DKMS make.log for openafs-1.8.8.1 for kernel 5.17.0-1-amd64 (x86_64)
Mon  9 May 17:10:20 CEST 2022
checking for gcc... gcc-11
(...)
  CC [M]
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/osi_proc.o
CC [M]
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/osi_vnodeops.o
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/osi_vnodeops.c:
In function ‘afs_linux_can_bypass’:
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/osi_vnodeops.c:2700:16:
warning: this statement may fall through [-Wimplicit-fallthrough=] 2700
|             if (i_size_read(ip) > cache_bypass_threshold) |
     ^
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/osi_vnodeops.c:2703:9:
note: here 2703 |         default: |         ^~~~~~~ CC [M]
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/osi_pagecopy.o
CC [M]
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/afs_nfsclnt.o
CC [M]
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/afs_nfsdisp.o
CC [M]
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/afs_call_nfs.o
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/afs_call_nfs.c:
In function ‘afsd_thread’:
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/afs_call_nfs.c:331:9:
error: implicit declaration of function ‘complete_and_exit’
[-Werror=implicit-function-declaration] 331 |
complete_and_exit(0, 0); |         ^~~~~~~~~~~~~~~~~ cc1: some warnings
being treated as errors make[4]: ***
[/usr/src/linux-headers-5.17.0-1-common/scripts/Makefile.build:293:
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP/afs_call_nfs.o]
Error 1 make[3]: ***
[/usr/src/linux-headers-5.17.0-1-common/Makefile:1855:
/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP]
Error 2 make[3]: Leaving directory
'/usr/src/linux-headers-5.17.0-1-amd64' FAILURE: make exit code 2
make[2]: *** [Makefile.afs:279: openafs.ko] Error 1 make[2]: Leaving
directory
'/var/lib/dkms/openafs/1.8.8.1/build/src/libafs/MODLOAD-5.17.0-1-amd64-SP'
make[1]: *** [Makefile:186: linux_compdirs] Error 2 make[1]: Leaving
directory '/var/lib/dkms/openafs/1.8.8.1/build/src/libafs' make: ***
[Makefile:15: all] Error 2

#1010764#10
Date:
2022-05-18 01:55:00 UTC
From:
To:
The fix for this appears to have merged upstream in January, so
could probably be backported in Salsa:

https://gerrit.openafs.org/14882

#1010764#17
Date:
2022-06-20 17:38:49 UTC
From:
To:
tags 1010764 upstream fixed-upstream pending
thanks

Indeed, upstream has been getting the needed fixes for new linux versions
into git, but getting them actually into a release has been "probably next
week" for ... well, quite a few weeks.  I will go ahead and just take the
patches as debian patches for now, and my apologies for taking so long to
get to it.

#1010764#24
Date:
2022-06-21 00:04:25 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
openafs, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1010764@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Benjamin Kaduk <kaduk@mit.edu> (supplier of updated openafs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Mon, 20 Jun 2022 15:54:55 -0700
Source: openafs
Architecture: source
Version: 1.8.8.1-3
Distribution: unstable
Urgency: low
Maintainer: Benjamin Kaduk <kaduk@mit.edu>
Changed-By: Benjamin Kaduk <kaduk@mit.edu>
Closes: 1010764
Changes:
 openafs (1.8.8.1-3) unstable; urgency=low
 .
   [ Andreas Beckmann ]
   * Switch to B-D: dh-dkms.
   * Declare Testsuite: autopkgtest-pkg-dkms.
 .
   [ Benjamin Kaduk ]
   * Import upstream patches to support linux through 5.18 (Closes: #1010764)
     - This will change kernels from 5.8 through 5.17 to use the "readahead"
       interface rather than "readpages".
     - This imports some code from autoconf-archive and updates
       debian/copyright to list the new license/files.
   * Bump Standards-Version to 4.6.1 (no changes needed)
Checksums-Sha1:
 ab5c3934e69a0c1737bfaa8cec3a8a0c8002f5fe 3607 openafs_1.8.8.1-3.dsc
 a746d002af245a8b854ccaf093dfe4eb1d666e56 158744 openafs_1.8.8.1-3.debian.tar.xz
 744dad91684844ddfa2f7af60e68201792937a35 16622 openafs_1.8.8.1-3_amd64.buildinfo
Checksums-Sha256:
 1f3a313c78fec7a3ac75831dc936f80426720df803e4cc462b889e2ae198e4f5 3607 openafs_1.8.8.1-3.dsc
 e397931c322d46400832082bba6ff2e529b8d720e44c0c285beafd4e6b4b4913 158744 openafs_1.8.8.1-3.debian.tar.xz
 7efed83e0f670ae1589d8bcb20f9c75ce45626619af3f59f736f36b8bf3b4fd6 16622 openafs_1.8.8.1-3_amd64.buildinfo
Files:
 f7e481b459cdc5a1810137b369665b1a 3607 net optional openafs_1.8.8.1-3.dsc
 f284667be89eecefce15e40b8ebe9c04 158744 net optional openafs_1.8.8.1-3.debian.tar.xz
 52fde8c5645575d002681dc1cd0355eb 16622 net optional openafs_1.8.8.1-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQHGBAEBCgAsFiEE2WGV4E2ARf9BYP0XKNmm82TrdRIFAmKxBXYOHGthZHVrQG1p
dC5lZHUACgkQKNmm82TrdRKxIQwgif+Kv9vS6xazl3wMfwwOsAzLxYask4cR2Mv7
TzsXstSSLt7lzHu853n6NMaP1I6TdwXSHbFpf5deuYOj3LPtvcasUNk/WloUBA2a
FC+AQtH8UXt+L30CoeAHrDRkiTpc5TAP1DhetdDGjm7PfloCDU45v6ERlmitkFC9
zGPbdc+kcDoTGB5EBohst+Kf09pEIEfP2LcZAXiPhr7KwDpYDTPIW6mb+MIZdk2J
saW619cjLzyhRjbDwsSc2sCu2RUny6ZAgMPx74erlvauGb+g2Psl3Qrnvw0IYxwh
g2sdF28RqJYSXlGh6gMwiBwHHYw8nrktJE73L5bNT0KLw5MJUq4aDCk6SBgoxLBR
OOANJQn2EajkkMG8DQv77P3FL1cMfn0ndZ07p8BIZucC5Wel8tJdkCIrYx+5Encu
KsKBO3SJZsa30/9uHBg84Dmni87UhuGXvfVft4KYmHZjeseSEjR9P1loQ5U1zlUJ
nH+LS2LdfUFWhEaTjTyqkj+7ayMg3H88aw==
=ajIC
-----END PGP SIGNATURE-----