Hello.
The attached suggestions may simplify the use of dh-octave, especially
for source packages building several binary packages.

Hello,

Bug #1011556 in dh-octave reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/pkg-octave-team/dh-octave/-/commit/d70f37306e735d16f343f7ff03778e3485e16d7a
------------------------------------------------------------------------
d/control: let dh-octave provide dh-sequence-octave

Debhelper recognizes this special formal packages in Build-Depends and
adds --with=octave to the dh parameters.

This is quite convenient when the dependency is restricted to
architecture-independent builds or by profiles.  In such scenarios,
several non-trivial conditionals can be avoided in debian/rules.

Closes: #1011556
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1011556

Thanks for this bug report and for the patch, Nicolas.

I integrated your commits into the Git repository of the dh-package at
Salsa, on a side branch called bug-1011556 [1].

I had to make a series of adjustments to your code, in order to have it
working correctly, namely :

  * buildsystem.pm: use Debian::Debhelper::Dh_Lib [2]
  * buildsystem.pm: Avoid wildcards in doit calls [3]
  * dh_octave_make.in: Use dh-sequence-octave in Build-Depends [4]
  * buildsystem.pm: Check whether directories exist before acting on them [5]

Please, check whether this changes suit you.

I tested the resulting dh-octave, by building a couple of Octave-Forge
packages against it, after changing the Buidl-Depends from dh-octave to
dh-sequence-octave and removing "--with=octave" from debian/rules.
Everything seems to work. However, since the changes are quite
substantial in relation to the previously released version of dh-octave,
It would be great if other members of the DOG can revise them before
releasing a new version of the package.

Best,

Rafael

  [1] https://salsa.debian.org/pkg-octave-team/dh-octave/-/tree/bug-1011556
  [2] https://salsa.debian.org/pkg-octave-team/dh-octave/-/commit/a5957eb5
  [3] https://salsa.debian.org/pkg-octave-team/dh-octave/-/commit/0b51e820
  [4] https://salsa.debian.org/pkg-octave-team/dh-octave/-/commit/1c8bbf2c
  [5] https://salsa.debian.org/pkg-octave-team/dh-octave/-/commit/d0ff2a4b

* Nicolas Boulenguez <nicolas@debian.org> [2022-05-24 23:11]:

Hello,

Bug #1011556 in dh-octave reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/pkg-octave-team/dh-octave/-/commit/d70f37306e735d16f343f7ff03778e3485e16d7a
------------------------------------------------------------------------
d/control: let dh-octave provide dh-sequence-octave

Debhelper recognizes this special formal packages in Build-Depends and
adds --with=octave to the dh parameters.

This is quite convenient when the dependency is restricted to
architecture-independent builds or by profiles.  In such scenarios,
several non-trivial conditionals can be avoided in debian/rules.

Closes: #1011556
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1011556

We believe that the bug you reported is fixed in the latest version of
dh-octave, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1011556@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Rafael Laboissière <rafael@debian.org> (supplier of updated dh-octave package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Tue, 31 May 2022 08:14:25 -0300
Source: dh-octave
Architecture: source
Version: 1.2.0
Distribution: unstable
Urgency: medium
Maintainer: Debian Octave Group <team+pkg-octave-team@tracker.debian.org>
Changed-By: Rafael Laboissière <rafael@debian.org>
Closes: 1011556
Changes:
 dh-octave (1.2.0) unstable; urgency=medium
 .
   [ Nicolas Boulenguez ]
   * d/control: let dh-octave provide dh-sequence-octave (Closes: #1011556)
   * install-pkg.m: implement non-octave parts with perl’s Dh_Lib
   * buildsystem.pm: use debhelper’s tmpdir instead of debian/sourcepackage
   * dh scripts: document how which script is enabled
 .
   [ Rafael Laboissière ]
   * buildsystem.pm:
     + Use Debian::Debhelper::Dh_Lib
     + Avoid wildcards in doit calls
     + Check whether directories exist before acting on them
   * dh_octave_make.in: Use dh-sequence-octave in Build-Depends
   * d/control: Bump Standards-Version to 4.6.1 (no changes needed)
   * Update copyright years
   * README.md: Document the use of the virtual package dh-sequence-octave
Checksums-Sha1:
 f04881f4d17ce2283562db73775b1998b0631f67 2007 dh-octave_1.2.0.dsc
 fd651f73a309a8e50704fb3910baa3bef7cef03c 14780 dh-octave_1.2.0.tar.xz
Checksums-Sha256:
 e5209062957b97279bba7f9f9dc831ce9dc7e2bc233fe102d1b45ece5b138db0 2007 dh-octave_1.2.0.dsc
 e53b1126efa15ef02fa079e9c24909bde9e9bf5bb2a70d31fbc359c18ce108d8 14780 dh-octave_1.2.0.tar.xz
Files:
 b4faa1312773c42adbaaf4dfb124f819 2007 devel optional dh-octave_1.2.0.dsc
 9f60b0120cc09f56ecacd31fafe5886c 14780 devel optional dh-octave_1.2.0.tar.xz
-----BEGIN PGP SIGNATURE-----

iQJGBAEBCAAwFiEEP0ZDkUmP6HS9tdmPISSqGYN4XJAFAmKWOA8SHHJhZmFlbEBk
ZWJpYW4ub3JnAAoJECEkqhmDeFyQUmMP/3lraMNOJI8hNEdDyqfiyOcY/yrLcwfN
4+T6bU+hoqiaGKRb/AmclHasr/Y+pCY2AF9GX2t/wftFYbqRwvDfWtlcJ+c2Edgr
KM3U2oowxzOSxwWzI43EByd34tGT4yqVGle6QcpeNK2vL/NiwbX0ATK0mpLZMO7N
3KwHY2SL12mmvIYa0gEDBm+n/5wn0mDaksfK5ySa3uCWQ3U72s1Ndfxx7x6P9Gdj
fxLnPPVZsENtxAd5PozZbvsp25Onb1UGQrCIOSvpIkL3OgjLgbrNyNeXuqv0QiZA
HQSV3vXhtHLrf3dzLPKlHnyDK7s1T/bSor9dI/KmFEjbtCCRtr7p9MUvpgBcXojw
GE790NizQwR26i5ERoql69eUz8k7IsIzoqY0i7BxRCucVh5x/fTMgsO2RzonfuNX
9W+aRFkC/GtH6G6742fgoNyjmqUzT7UJvclAw7ClQSYpC5F7Vsti/coH9nnMdMj0
9T/JgU5NRjtHNZdw4GIM+JvZVLSJV/OroRIJsuJwNQX8v2H5GOngRqZvF19fhe9U
U4IGC1S9Jl2GvI43zbpjU+4Kd4tldpcEMkIsSH1A96Xg/piLGLHomF/rg+gBqodp
tshYo/64hq9YdRHOgYXd0H8Bzoi+O08NU7qXYELutyPwNlkQcR4WRU/D5snrqMnw
QDYeixcovdCV
=BBZ2
-----END PGP SIGNATURE-----