Hi Bastian,

thanks for writing and maintaining python-popcon, it's a nice and
useful library. Also having a /usr/bin/popcon is helpful.

I just noticed that the output of the script is a bit terse (both the
format and that it only shows the totals), so I thought it might be
worth to have a some more verbose variant.

I came up with a first draft, but as I hardly speak any Python, I
asked for help, and mapreri kindly sat down and integrated my ideas
into something which supposedly matches what other Python code and
packages in Debian do :) [Thanks again!]

What the diff does is to add a '-v' option to the script in
popcon/__main__.py, which outputs, optionally coloured, the total and
separate popcon values of a package.

The rest is housekeeping for the package (recommends).

I hope you like the idea and can either apply our work or use it as a
base.


Cheers,
gregor
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmKORFFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgbEvA//aGgG383gTb7dn1aM1dDW1oz6BGZuv/pLUAh5E7DOtLlM716yLY7DQ8gK
mzySVAWy0L6bFAwNQDnppBcovbBjpydCvht4IBXGAzR/mBxDeI0h3btDIBZpP9u9
iyyY8Pv6ccxGYWj5rINdR8WfIudYNkn/qQGc3+Wh/7v4tSaqLx30mC1cdamXsf/A
A/bYkKAEaMfvDqoDtzheo0v54yT0feTfqjf4hzygpwH1BC1Vp5CbZNqKIug0Htuf
DWSdOePzBlKxmkK9YiMQC4Em4ewwe3MOtu7sAh2bpgMrCvr5VELJDg753ibd3TsB
ICeEIkbGwGZl4WmhcFkvh3EuTQk203I+JL1Hk4CzaWQjqrag6gF/SzrPxUHk2vVi
Ep80wkl0zJGWrgrPHHCtcXRqtx+vHEuCuF20J0Z6d+wrB9HKrLkIRxliy6KqxF9u
2kqE0324kvitONKRzbiMPzU0cIN2yl4oQbN+3k9jraIqgvKV1FMM7e87pP3eUnf5
cuAgwJjZBDWiAYdrFEn+Qk0JVZTyplyDxC6aQgKxJliuOJynzvTorG6b3zD7yPgm
3ALpPuRNp46N4+slIWeGDFsuZZ3dxD1zQf9sXzH2MakRAAqHUReClhoez+1MvGSj
HxnUAZT5eiPPOIrFlAsGx4hUwXMrkAgoTYX839/IqIc4pCQY1y8=
=U90f
-----END PGP SIGNATURE-----

We believe that the bug you reported is fixed in the latest version of
python-popcon, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1011634@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Venthur <venthur@debian.org> (supplier of updated python-popcon package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sun, 29 May 2022 11:01:08 +0200
Source: python-popcon
Binary: python3-popcon
Architecture: source all
Version: 3.0.0
Distribution: unstable
Urgency: medium
Maintainer: Bastian Venthur <venthur@debian.org>
Changed-By: Bastian Venthur <venthur@debian.org>
Description:
 python3-popcon - Python interface to Debian's Popularity Contest (popcon)
Closes: 1011634
Changes:
 python-popcon (3.0.0) unstable; urgency=medium
 .
   * Removed functions deprecated since 2.0.1
   * bumped minimim Python version to 3.7
   * Added Python 3.10 to test suite
   * use HTTPS everywhere
   * updated dev dependencies
   * Improved output and added verbose output (Closes: #1011634) Thanks Gregor
     Herrmann for the patch, I ended up using a different solution.
   * Use argparse for CLI
   * test the CLI
Checksums-Sha1:
 4d533b41dbf7f2f5b303d111aba380dd580528ca 1613 python-popcon_3.0.0.dsc
 7098ff6f5303477ba58f69cfda10ba73e62ae38e 13700 python-popcon_3.0.0.tar.xz
 e970ee42c2aa6211c94a2a350da4d67f5ec6469a 6437 python-popcon_3.0.0_amd64.buildinfo
 d499ef749205b9fc727983990e5c0942baa3dbfd 8160 python3-popcon_3.0.0_all.deb
Checksums-Sha256:
 222d9cb312894f90aaa72bd6f8918f338ab0acc156e24137ddad68fecf079296 1613 python-popcon_3.0.0.dsc
 2dd797a66777365689b9bfbd42db30d93d4232e89ff554a9cafffacc855f3814 13700 python-popcon_3.0.0.tar.xz
 7f6f85216d65a597f4aeeddb699895de62a775d925d7ce57bad7d467c6773d19 6437 python-popcon_3.0.0_amd64.buildinfo
 5a4c9ba403e11fd87fece924fb208cd51cf9c2320baf399200dab03d17fcf1c0 8160 python3-popcon_3.0.0_all.deb
Files:
 e81f633caf89ef8a85f08197945cab70 1613 python optional python-popcon_3.0.0.dsc
 ed43fd2521597c81aa7632191a3e86cb 13700 python optional python-popcon_3.0.0.tar.xz
 d9bfe86c019824332f168638004fe381 6437 python optional python-popcon_3.0.0_amd64.buildinfo
 bf133db18408b8c19e1142f21b3d2ffc 8160 python optional python3-popcon_3.0.0_all.deb
-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEh5WvLkoaTvugaKRJjoiVRNmFAA0FAmKTOHcTHHZlbnRodXJA
ZGViaWFuLm9yZwAKCRCOiJVE2YUADYZ5D/4nyrkOGeDzk1Tr6yEfsTfnF0RI+WLJ
yqeZ1qxGG2OllrrITF4Jamwwy83vkAzGHRSYCarnRR+m6WDJ9uU1/uwpW4iyl9OI
Ijfos/bn8O5xA5hrCBw/bDlzuS4JRBuk7TfKNHtYCASDLE80fr6Y5m8z4SnkCN+D
wP0mCngZNjt5HS+EyRmphq8tj3B6xR7ij+jSnjcOGOpR8GPuHW6VjxG0dxYA6yy1
on6ybdg01H0Y5uebkUlsiVpIWINJ4ELAP56J1IKMgp8phpuZCh9Eq64H7/vmPHgu
GeZN9AG9+5TpLvA0Q21romUQAnCbbCPQ+DnbKPxWnRNDiZNxpHuQzE4xJPGzpJlo
6cP/A9gZpKzAAQr1Kh3PL8oAbI3dOXaQJuL+GFomqwQOkmQjbBwm7NWMNHsztsA2
7PhJFVq8ZNPT9RyR0rsHnacCg+meEkSb9CJ6U8rPMqz4C3foo1Wz9fZjdFXt1q0d
n43bJadhHnQkbap87GrIVbEHha0jaiKm5O3xJRPo483IBe266Yvg8EH/i1m1Ku6d
2Qa7jII0IA0aDUrfZzaJ2NyGA+8VqxEKhwCSpkZ0K2ApAk13RqMf9egvhocAlP6N
94IXF0j1IHCszq1UwAxcQjkdxBMJW+/R/WVK6fgqZnoDm6k7mLnFSeRzdLagI55k
octYpsg7CKD4eg==
=ZWAu
-----END PGP SIGNATURE-----

Thanks alot for this quick and nice improvement!

If I may add two tiny wishlist requests:

1) The tabular format doesn't work so well with long package names:

% popcon libdancer2-plugin-passphrase-perl
             PACKAGE VALUE
libdancer2-plugin-passphrase-perl 8

% popcon -v libdancer2-plugin-passphrase-perl
             PACKAGE VOTE       OLD        RECENT     NO FILES
libdancer2-plugin-passphrase-perl 2          5          1          0

2) Personally I'd find it nice to have to total number / the sum of
the 4 categories in the verbose output as well; what do you think?


Cheers,
gregor

Hi Gregor,

done. Check the latest version 3.0.1, I've updated the tabular output to
accommodate for the length of the longest package name and I've added
the sum in the verbose output.

Thanks for the feedback!


Cheers,

Basti

Am 29.05.22 um 20:20 schrieb gregor herrmann:

This looks great:

% popcon -v libdancer2-plugin-passphrase-perl
                          PACKAGE SUM        VOTE       OLD        RECENT     NO FILES
libdancer2-plugin-passphrase-perl 8          2          5          1          0

Thank you very much for picking up those ideas :)

Cheers,
gregor