#1011688 synaptic: FTBFS: rconfiguration.cc:89:8: error: ‘getuid’ was not declared in this scope; did you mean ‘getpwuid’?

Package:
src:synaptic
Source:
synaptic
Submitter:
Lucas Nussbaum
Date:
2022-07-08 15:39:03 UTC
Severity:
serious
Tags:
#1011688#5
Date:
2022-05-26 06:41:20 UTC
From:
To:
Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
The full build log is available from:
http://qa-logs.debian.net/2022/05/25/synaptic_0.90.2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220525;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220525&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

#1011688#10
Date:
2022-06-27 18:09:15 UTC
From:
To:
Dear maintainer,

I've prepared an NMU for synaptic (versioned as 0.90.2+nmu1) and
uploaded it to DELAYED/14. Please feel free to tell me if I
should delay it longer.

Regards.

diff -Nru synaptic-0.90.2/common/rconfiguration.cc synaptic-
0.90.2+nmu1/common/rconfiguration.cc
--- synaptic-0.90.2/common/rconfiguration.cc	2020-11-16
03:56:34.000000000 -0500
+++ synaptic-0.90.2+nmu1/common/rconfiguration.cc	2022-06-27
14:01:08.000000000 -0400
@@ -30,6 +30,8 @@
 #include <sys/stat.h>
 #include <sys/types.h>

+#include <unistd.h>
+
 #include <apt-pkg/init.h>
 #include <apt-pkg/error.h>
 #include <apt-pkg/configuration.h>
diff -Nru synaptic-0.90.2/configure.ac synaptic-0.90.2+nmu1/configure.ac
--- synaptic-0.90.2/configure.ac	2020-11-16 03:56:34.000000000 -0500
+++ synaptic-0.90.2+nmu1/configure.ac	2022-06-27 14:01:08.000000000 -0400
@@ -1,5 +1,5 @@
 dnl Process this file with autoconf to produce a configure script.
-AC_INIT(synaptic, 0.90.2)
+AC_INIT(synaptic, 0.90.2+nmu1)

 AM_INIT_AUTOMAKE([subdir-objects -Wno-portability])
 AM_CONFIG_HEADER(config.h)
diff -Nru synaptic-0.90.2/debian/changelog synaptic-
0.90.2+nmu1/debian/changelog
--- synaptic-0.90.2/debian/changelog	2020-11-16 03:56:34.000000000 -0500
+++ synaptic-0.90.2+nmu1/debian/changelog	2022-06-27
14:01:08.000000000 -0400
@@ -1,3 +1,12 @@
+synaptic (0.90.2+nmu1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * common/rconfiguration.cc: Include unistd.h to prevent FTBFS
+    due to undefined getuid(2). (Closes: #1011688)
+  * configure.ac: Bump version string.
+
+ -- Boyuan Yang <byang@debian.org>  Mon, 27 Jun 2022 14:01:08 -0400
+
 synaptic (0.90.2) unstable; urgency=medium

   [ Heimen Stoffels ]

#1011688#19
Date:
2022-06-29 18:06:50 UTC
From:
To:
Hey Boyuan Yang,

thank you so much your NMU and the diff. I will merge it into the git tree and may do a new upload with some more pending github fixes merged. Hope that is okay with you.

Thanks again for your help!
 Michael

#1011688#24
Date:
2022-06-29 19:46:28 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
synaptic, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1011688@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Vogt <mvo@debian.org> (supplier of updated synaptic package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Wed, 29 Jun 2022 20:26:48 +0200
Source: synaptic
Built-For-Profiles: noudeb
Architecture: source
Version: 0.91
Distribution: unstable
Urgency: medium
Maintainer: Michael Vogt <mvo@debian.org>
Changed-By: Michael Vogt <mvo@debian.org>
Closes: 1011688
Changes:
 synaptic (0.91) unstable; urgency=medium
 .
   [ Bryan Quigley ]
   * Follow https://wiki.gnome.org/Projects/GnomeCommon/Migration
   * Updated Readme and add initial Contributing.md
   * Update all the home page mentions that appear current
   * drop gtk3-compat
   * Drop gtk_plugin bits that haven't been used since gtk3
   * Remove plug-progress-into option
   * make gtk3.4 the new miniumum
   * Github actions: add a basic make and debuild
   * drop rgvendorswindow*
   * add install/removing the deb
   * "vte_terminal_copy_clipboard has been deprecated since version 0.50 and should not be used in newly-written code.
   * Fully disable the remove dependencies code so we don't get warnngs from it.
   * Update vte min requirements
   * Clean more unused files
   * This really wants to be in a different part of the file
   * Move to using gtk_about_dialog
   * Drop hardcoded browsers
 .
   [ Janvitus ]
   * Updated italian translation.
 .
   [ Federico Grau ]
   * Update default icon size for application
 .
   [ baranzadeoglu ]
   * Update synaptic.8
 .
   [ Fatih Altun ]
   * Update Turkish translations
 .
   [ Emilian Nowak ]
   * Updated polish translation
 .
   [ yusufymz ]
   * Update tr.po
 .
   [ Michael Vogt ]
   * gtk: move from deprecated gtk_menu_popup to gtk_menu_popup_at_pointer
   * gtk: remove fixed-size for status/supported pixmap columns
 .
   [ Boyuan Yang ]
   * c/rconfiguration.cc: include unistd.h to prevent FTBFS (Closes: #1011688)
Checksums-Sha1:
 a8cf08682af1b007d520647eccadf48cb1fdf874 1735 synaptic_0.91.dsc
 64c26b686e89bec32b0bb8d933beb7439fbd71d2 2250320 synaptic_0.91.tar.xz
 b9feb67d15ae3380fc60a025779d3dde7cf2c7e3 17610 synaptic_0.91_source.buildinfo
Checksums-Sha256:
 16fad7261a04a3be6663c1f0599882225799a878ea47395fd9a39dc4526d914b 1735 synaptic_0.91.dsc
 24bcbf970c472bd78a99a1b45e968b360b019cb58339b57c9d6aec7bddd853d6 2250320 synaptic_0.91.tar.xz
 161f2cef6e24c63360a987db7f76dddaa6fa791979fb6356e026a43140a36d23 17610 synaptic_0.91_source.buildinfo
Files:
 ede89a4ed7451403830d974bc21e71dd 1735 admin optional synaptic_0.91.dsc
 3b12b10673685bc45996714a3e2e241c 2250320 admin optional synaptic_0.91.tar.xz
 5b79d7fe0f606075812ba19fc7688c7f 17610 admin optional synaptic_0.91_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE2mxnVNiIdibNBqEomMq7Or1MpZ4FAmK8m5YACgkQmMq7Or1M
pZ691Q//XNOlm3x0voEbzxbPloThvw/Bg6OqFo7zo5otEDRCM40Oha28Y+WYxQuF
epLx02Xv5LQo5On6F+JnwT4aySC3o7r11L1QFW89kUQHxsVRCvdTojyqdpGh5u/1
LpzAlRro5+W2/GTEZEfnVBEf9IJVk5KV3rzOWXkQC4G85+//PxgZ1/NflLX+9Il6
PKlF9HX0aV1GwsxgMC8RZgMW46C0D/v3iJPrudaBO0m3Og6TwFjGQVX5vViCzatS
ArMHFyKINE3nfe76cuDbu5lA1x/oUa0JGOrTW7X6MB17tefbI7sozfjCx7T77kTt
zjiMVGz9X674q/+dyzbh5myV1rl8UgcbFIo+R9A9rp+Rn9oWh9oM2mC4V1Bvwqn6
Pueypj+ZINIOGF7M5GoaitJpaY3UHHE4WpSQkgkSaGJDsd3MBuyNIwdgt9TGsadC
1MsTJWQyn93IFwX2JLBLfJNR7vLr4Tj5gQvoRmPHQYJhA63j2PnPw54ufGv2Lopt
f/1zP20jg/iRxCRwaGGe0UJFCqhPp5Fkf6VSKzr5CBNpUy3phgfcEAap1EO05J7c
IiaKD9nzs6Cn92V+BIfqJHj8vWyE3nV4OGIFM5NlnenCjMDTwcZWnnzYJB/ItcXL
IH92E42l6r7M0NSpjb5mcgu0dN2OpE+UrD25+1oifmP1tcsaiz8=
=BUi9
-----END PGP SIGNATURE-----

#1011688#29
Date:
2022-07-08 11:01:54 UTC
From:
To:
Hey,

just wanted to send a quick THANK YOU note for the NMU diff. I uploaded a new version of synaptic with it and various other collected fixes/changes. But I realized I did not reply with a thank you :)

Cheers,
 Michael

#1011688#34
Date:
2022-07-08 15:36:32 UTC
From:
To:
Hi,

在 2022-07-08星期五的 13:01 +0200,Michael Vogt写道:

My pleasure. Having a quick yet effective fix is beneficial to all users.

Cheers,
Boyuan