Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
The full build log is available from:
http://qa-logs.debian.net/2022/05/25/node-terser_4.1.2-10_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220525;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220525&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Hi,

here is a debdiff (debian part only) to update terser to version 5.13.1.
This fixes also #1011816 (FTBFS)

Cheers,
Yadd

Quoting Yadd (2022-05-30 12:05:41)

Thanks!

It seems you are sharing that patch as a proposal, as you only pushed
some parts of it to git.

...and I disagree with some minor parts of it, so that's good: I will
take a look at it, and when I get a better sense of it reply back here
in more detail which parts I disagree with.


 - Jonas

There is something broken with cjs/mjs. I'm going to fix that.

Cheers,
Yadd

Le Lundi, Mai 30, 2022 13:07 CEST, Jonas Smedegaard <jonas@jones.dk> a écrit:

I fixed:
  * debdiff: diff from debian/latest (still only debian/ directory)
  * commonjs use

Now autopkgtest passed except pure browser test (command2): webpack
produces a bundle unusable for domino test, maybe for browser...

I think mocha test could be added to autopkgtest now

Cheers,
Yadd

"webpack produces..." => in node-source-map ["self is not defined"]

Hi,

all is fixed now with node-source-map 0.7.0++dfsg2+really.0.6.1-11

Cheers,
Yadd

Quoting Yadd (2022-05-31 14:48:19)

Thanks!

 - Jonas

Hi Jonas,

did you have some time to look at this ?

Quoting Yadd (2022-06-25 09:51:05)
off and finalized my work (terser v4.8 will be in unstable shortly).
Thanks again!

Your fixing the issues is great.  The minor issue I had with it
was your sharing fixes for multiple issues as a single patch, making it
hard to follow what exactly is going on, and consequently making it hard
to navigate in it - i.e. adopt only some changes but not others.

Concretely, I am not ready to move to terser v5 yet, and this RC bug
does *not* require bumping to terser v5.  Your sharing a fix for this
issue that goes "first upgrade to terser v5, then patch that different
codebase like this..." made it hard for me to change that *one line*
really related to this bug:

-+if ("ecma" in opts) {
++if ("ecma" in opts && opts.ecma != undefined) {

Let me repeat to emphasize: I truly appreciate your work triaging bugs!

Just please consider making "atomic changes": One git commit (or patch
file) per semantic change - not multiple lesser-related changes lumped
together.

Kind regards,

 - Jonas

Thanks, usually  it seems like you prefer debdiff instead of MR, that's
why I did this. Would you rather I make some MRs this time?

[ drop cross-posting to related but separate bugreport ]

Control: reopen 1004471
Control: done 1011816 4.8.0-3

This bug was solved with release 4.8.0-3 of node-terser.

Quoting Yadd (2022-05-30 12:05:41)

Thanks for solving multiple bugs.
Please pretty please do not lump multiple bugfixes together, however.

Thanks for mentioning when one bugfix relates to another bug as well.
Please do not cross-post to multiple bugreports, however.

Lumping changes together and cross-posting both relaxes focus, which can
intuitively feel convenient when doing it but makes it harder to regain
focus afterwards.

Concretely, I now accidentally closed the wrong bug.  My fault, but my
getting confused likely stems from this loss of focus.


 - Jonas

[ dropping randomly one of the cross-posted bugreports ]

Quoting Yadd (2022-06-25 12:13:48)
play along with a specific model of using git indirectly via a custom
web interface (or a custom REST interface).

But the alternative to MRs is not a debdiff, but a diff.

If it takes 7 changes to fix a bug, then share that as 7 distinct
pieces, either as a git branch somewhere containing 7 commits, or as 7
unified diff patches attached to an email.


Regards,

 - Jonas