#1011913 haskell-devscripts: DEB_ENABLE_TESTS ignored

#1011913#5
Date:
2022-05-26 19:04:50 UTC
From:
To:
Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
The full build log is available from:
http://qa-logs.debian.net/2022/05/25/haskell-swish_0.10.1.0-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220525;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220525&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

#1011913#10
Date:
2022-05-28 12:29:50 UTC
From:
To:
Quoting Lucas Nussbaum (2022-05-26 21:04:50)
[...]

haskell-swish built successfully when released in January, and contains
this in debian/rules:

Perhaps this really is bug#1010179 and the "fix" only papered over the
underlying problem: @Scott, did you test packages _enabling_ tests or
only the default of having tests disabled?

 - Jonas

#1011913#23
Date:
2022-05-29 01:48:43 UTC
From:
To:
Hi Jonas,

Actually, it looks like DEB_ENABLE_TESTS=yes had been broken in
haskell-devscripts for quite some time (even before Felix's changes).  If
you look at the January build log for haskell-swish, the tests were not
run at that time.  In the case of haskell-swish, DEB_ENABLE_TESTS needs to
be defined *before* including hlibrary.mk.  After fixing that, it seems
there are some missing test dependencies.

Scott

#1011913#28
Date:
2022-05-29 08:21:18 UTC
From:
To:
Quoting Scott Talbert (2022-05-29 03:48:43)

Oh!

This means haskell-swish hasn't ever run its tests since initial
packaging in 2013.  Thanks a lot for (indirectly) pointing that out to
me.

The missing build-dependencies was another bug in my rules file - a
silly missing comma in a macro call :-/

 - Jonas

#1011913#37
Date:
2022-05-29 09:20:47 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
haskell-swish, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1011913@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jonas Smedegaard <dr@jones.dk> (supplier of updated haskell-swish package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sun, 29 May 2022 10:41:21 +0200
Source: haskell-swish
Architecture: source
Version: 0.10.2.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Haskell Group <debian-haskell@lists.debian.org>
Changed-By: Jonas Smedegaard <dr@jones.dk>
Closes: 1011913
Changes:
 haskell-swish (0.10.2.0-1) unstable; urgency=medium
 .
   [ upstream ]
   * new release
 .
   [ Jonas Smedegaard ]
   * update git-buildpackage config:
     + use DEP-14 git branches
     + enable automatic DEP-14 branch name handling
     + add usage config
   * declare compliance with Debian Policy 4.6.1
   * relax upper GHC bounds for hashable;
     drop GHC bounds for old-locale
   * update copyright info: update coverage
   * fix enable tests;
     add GHC build-dependencies
     for hunit test-framework test-framework-hunit;
     closes: bug#1011913, thanks to Scott Talbert
   * annotate test-only build-dependencies
Checksums-Sha1:
 9014f3617f556062ddf8aeb0a096b1cce74517cb 2766 haskell-swish_0.10.2.0-1.dsc
 24441fff63b2eaaac22cc1a16bfb7c0a9e0fae03 305819 haskell-swish_0.10.2.0.orig.tar.gz
 3339028c2e4cded97be6fa39d218656b526ee44d 8292 haskell-swish_0.10.2.0-1.debian.tar.xz
 5d36a2b9e725d294b61e72213c1f22c800672287 9856 haskell-swish_0.10.2.0-1_amd64.buildinfo
Checksums-Sha256:
 824e7323aa7efd17704f6f323aca106f9918b9509d37af8e692bd99783a7ea9d 2766 haskell-swish_0.10.2.0-1.dsc
 a82a48b1ddae2956be32ea2f04983e6c6608f7f4f4264a24b6f4539fa6c15a98 305819 haskell-swish_0.10.2.0.orig.tar.gz
 37d90fd6611d43e95681dd30adaa3f2e343c14021c91ece25c35fbf78003eae4 8292 haskell-swish_0.10.2.0-1.debian.tar.xz
 64e4bfd33a6247cd9233dfa9325a023003c740a747748cd653dd1346cb0a8f94 9856 haskell-swish_0.10.2.0-1_amd64.buildinfo
Files:
 a44e8423ec9c5eae59b926367ec1f6f6 2766 haskell optional haskell-swish_0.10.2.0-1.dsc
 894a3e617b58f8133610eb4fcf4d385d 305819 haskell optional haskell-swish_0.10.2.0.orig.tar.gz
 7d70ba805e3d47cd369d871dd603e5c9 8292 haskell optional haskell-swish_0.10.2.0-1.debian.tar.xz
 a5214ac2c912c101a970d6a28e5caf78 9856 haskell optional haskell-swish_0.10.2.0-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAmKTOBEACgkQLHwxRsGg
ASFkjxAApbchU+TIPkE0/RJJmKmT0fn7QFaAcybgdjRZJ4J4UbdUjdBSjK57IkEp
UuFZwjlbzUcAeWPJ77jubUjD41Pl4GbgwtVQYlxNE3WQ1L+n+PAuHPNFfANnGLKI
n+QgJSamy2Ql9s0smATybZZ613+ncEh2+Olyd6etfet64/DDgvjwWh4yiCKdvsWu
SuQTJTESy41jlRH2mhkZ15P/5eIjph6ZUKs08e13SwcSi2jHpZbMSTkZreGfOfnJ
9ErLd19Xl4IhQoBx70egIzhj7uvDPBa9LyTPAYMsahMTXK0ljj88R/p0djo+6nyM
7N67WbcUxWis/TB5DUyttMP9595E9qkZED5cr8ocBd9YKF9dZn8tKzp+1NHAZr6L
YmTD40vsp0jDiyRzYoI+7VyMLkyf9tX7xxtGnzY2DcJPTnN+3JN3xNC+TN5jfhHa
D59vV7sJxZ5dOo4+Tl5jeGveQUm8HcdXkEU5dFSqhvHxpgXbTIj0USrDt8xn9sen
mKtCfAbrrtjywWTi6ziuChODyddoeMwNiE1FkPXcLnW4GvVm05H2CsyPnod2sIA3
HNRltKMwnDmzDYxVeFwTO6boDsTjUrdFblhJmFDgC/YJTGXh2pHQ4CK6/Tg/f/tO
OFSqgQLoyp7fmKNLlx4tNZnv8iu5vhDn0deR2mFbvd4D0UU3R2w=
=WZ3o
-----END PGP SIGNATURE-----