#1012215 gradle-debian-helper: unknown option --add-opens breaks OpenJDK 11 packages

Package:
gradle-debian-helper
Source:
gradle-debian-helper
Submitter:
Markus Koschany
Date:
2022-06-01 21:36:02 UTC
Severity:
serious
#1012215#5
Date:
2022-06-01 12:50:25 UTC
From:
To:
Hi,

The newly added --add-opens option is only valid for OpenJDK 17. I
understand that we switch to it for Debian 12 but it currently breaks
all packages that are built with OpenJDK 11. I am currently in the
process to update gradle to a newer upstream release. We should try to
use a conditional clause depending on the JVM in use.

Markus
#1012215#10
Date:
2022-06-01 13:03:28 UTC
From:
To:
The --add-opens option was introduced in Java 9, so this shouldn't cause an issue with Java 11. What error did you get?
#1012215#15
Date:
2022-06-01 13:03:28 UTC
From:
To:
The --add-opens option was introduced in Java 9, so this shouldn't cause an issue with Java 11. What error did you get?
#1012215#20
Date:
2022-06-01 13:42:38 UTC
From:
To:
Am Mittwoch, dem 01.06.2022 um 15:03 +0200 schrieb Emmanuel Bourg:
The compiler complains about "unknown option --add-opens" when I try to rebuild
kotlin in unstable.

Starting process 'Gradle build daemon'. Working directory:
/<<PKGBUILDDIR>>/.gradle/daemon/4.4.1 Command: /usr/lib/jvm/java-11-openjdk-
amd64/bin/java -Xbootclasspath/a:/usr/share/java/gradle-helper-
hook.jar:/usr/share/java/maven-repo-helper.jar --add-opens
java.base/java.lang=ALL-UNNAMED -Dfile.encoding=UTF-8 -Duser.country -
Duser.language=en -Duser.variant -cp /usr/share/gradle/lib/gradle-launcher-
4.4.1.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 4.4.1

It might be related to the build-dependency on openjdk-8 but the command
mentions java-11 which is strange. In any case we should be more careful when
we force new options to all packages. A conditional is safer and prevents
regressions.
#1012215#25
Date:
2022-06-01 13:42:38 UTC
From:
To:
Am Mittwoch, dem 01.06.2022 um 15:03 +0200 schrieb Emmanuel Bourg:
The compiler complains about "unknown option --add-opens" when I try to rebuild
kotlin in unstable.

Starting process 'Gradle build daemon'. Working directory:
/<<PKGBUILDDIR>>/.gradle/daemon/4.4.1 Command: /usr/lib/jvm/java-11-openjdk-
amd64/bin/java -Xbootclasspath/a:/usr/share/java/gradle-helper-
hook.jar:/usr/share/java/maven-repo-helper.jar --add-opens
java.base/java.lang=ALL-UNNAMED -Dfile.encoding=UTF-8 -Duser.country -
Duser.language=en -Duser.variant -cp /usr/share/gradle/lib/gradle-launcher-
4.4.1.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 4.4.1

It might be related to the build-dependency on openjdk-8 but the command
mentions java-11 which is strange. In any case we should be more careful when
we force new options to all packages. A conditional is safer and prevents
regressions.
#1012215#28
Date:
2022-06-01 16:19:07 UTC
From:
To:
Hello,

Bug #1012215 in gradle-debian-helper reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/java-team/gradle-debian-helper/-/commit/5a3769b9bda5a581a38be6bdd694676bc24b83ed

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1012215
#1012215#35
Date:
2022-06-01 16:34:39 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
gradle-debian-helper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1012215@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Emmanuel Bourg <ebourg@apache.org> (supplier of updated gradle-debian-helper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Wed, 01 Jun 2022 18:17:59 +0200
Source: gradle-debian-helper
Architecture: source
Version: 2.3
Distribution: unstable
Urgency: medium
Maintainer: Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
Changed-By: Emmanuel Bourg <ebourg@apache.org>
Closes: 1012215
Changes:
 gradle-debian-helper (2.3) unstable; urgency=medium
 .
   * Check the JDK specified by the JAVA_HOME environment variable before
     adding --add-opens option to the gradle command line (Closes: #1012215)
Checksums-Sha1:
 14bbcc9803ec5ffff05c0bccb1a2b36c70ed0f25 1821 gradle-debian-helper_2.3.dsc
 b47ef68784162411104f98e1d02f4d5071cc6d9c 15496 gradle-debian-helper_2.3.tar.xz
 baa46a78fb43f54997d380c8acd6c4c4cf53b14f 16733 gradle-debian-helper_2.3_source.buildinfo
Checksums-Sha256:
 5d46acce03b03222fad288826af0edac4d6ff265a632c2f694ebe4f48f6f3cff 1821 gradle-debian-helper_2.3.dsc
 80f3c1e09dac266be25dd94e8db187431fd1409586e0361e8703932cdf9a4a7c 15496 gradle-debian-helper_2.3.tar.xz
 251dda9c0be3ddb965f359f97cd80aded1b63451debfffe8e51a3660a0583247 16733 gradle-debian-helper_2.3_source.buildinfo
Files:
 9ca7864ac0cffabe3cd6a0565c2e6872 1821 java optional gradle-debian-helper_2.3.dsc
 ce7d6a73305efc08ec856cdd17bf07b2 15496 java optional gradle-debian-helper_2.3.tar.xz
 d7b33bac9cbeda3fe05416fbb04c4cc0 16733 java optional gradle-debian-helper_2.3_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEEuM5N4hCA3PkD4WxA9RPEGeS50KwFAmKXkXUSHGVib3VyZ0Bh
cGFjaGUub3JnAAoJEPUTxBnkudCs6eIQAJvUThTkBx94XYQTz8K+9oT5aI23kcBE
Cz70LW4AKh0AusO6bZ3/H0Y2Rm9RgC4Kh3dCwF9F8BJR1FUnXm3dZE/q5MZjk8Gr
8Wpv0pABlv0aTUS2k0qP1apOF4/Bwbw3fZS9rXE908iJ+HcgRuKAkc4ZxQ1TLPSv
fk0TWC7x3fryBUX0JT6h/EgeIVdIENOliU5wFPLqIvPz5aOvw8jaX8ed1IU/Cxck
1pNQiG0Z0rXp4APLETHYQytpb82o25aihhWR2qZA2ykDEaRMN3SxIrUAj5ysHyoN
BNA//oHXb2j/UiR/GneDwds3kQEGrVuQz/ktlBs8PiuQUnAhU5einRlvBNC1AC7w
SK3H0/UOTE3kqhhDoY7lPVebCSXHST0ryREtbH57Otp8ia/nnR8nv+JI3skVV1lN
VjnpG2CT9DP/8XrLza3yFyewNE0ezZK9/MJaXZXSJEGggrZZyb2wKwtWWpuKUTV2
efb1WMlXWfS8g/vuoxSKh+OEi9OUjb7LwL50acvL+WhTqOYkjLXNKQ8KL1Ojfpko
ntCAGWLTELpJmQYdWIa1g1O4LVdUR1FQnWToMmGT0q393b074gLnE+Uju4Dpv3Bw
VuZ2sVGFxkjMvRx31Lmd4ZQurMnsbpfh10FvlLwgvtoiTk0foWcHPy8hfT1HUbGp
SzPKG6QNkwgF
=mbiy
-----END PGP SIGNATURE-----
#1012215#40
Date:
2022-06-01 19:14:17 UTC
From:
To:
Am Mittwoch, dem 01.06.2022 um 17:36 +0200 schrieb Emmanuel Bourg:

ok, cool. Thanks for fixing it!
#1012215#45
Date:
2022-06-01 15:36:43 UTC
From:
To:
gradle-debian-helper/2.2 already checks if the JDK supports modules before adding the --add-opens options, but it checks the default JDK and not the one specified by JAVA_HOME, that's why it fails when OpenJDK 8 is used.
#1012215#50
Date:
2022-06-01 19:14:17 UTC
From:
To:
Am Mittwoch, dem 01.06.2022 um 17:36 +0200 schrieb Emmanuel Bourg:

ok, cool. Thanks for fixing it!
#1012215#55
Date:
2022-06-01 15:36:43 UTC
From:
To:
gradle-debian-helper/2.2 already checks if the JDK supports modules before adding the --add-opens options, but it checks the default JDK and not the one specified by JAVA_HOME, that's why it fails when OpenJDK 8 is used.