#1012808 git-review 2.2 is not compatible with OpenSSH 9.X (scp breaking change)

#1012808#5
Date:
2022-06-14 15:08:41 UTC
From:
To:
Dear Maintainer,

While using git-review on Bookworm, I couldn't perform the initial setup:

    $ git review -s -v
    Running: scp -P29418 username@review.opendev.org:hooks/commit-msg .git/hooks/commit-msg
    Problems encountered installing commit-msg hook
    The following command failed with exit code 255
        "scp -P29418 username@review.opendev.org:hooks/commit-msg .git/hooks/commit-msg"
    -----------------------
    subsystem request failed on channel 0
    scp: Connection closed
    -----------------------

Running the scp command manually yields the same error.

This is likely caused by a breaking change in scp behaviour introduced in OpenSSH 9.X

The upstream project already has a fix for this issue:

https://opendev.org/opendev/git-review/commit/5bfaa4a6f355a6820fe16c1aea77a01ba7b97eaa

Updating the git-review package to version 2.3 should be enough to fix this issue.

Thanks,
Baptiste

#1012808#8
Date:
2022-06-30 15:21:14 UTC
From:
To:
Hello,

Bug #1012808 in git-review reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/openstack-team/third-party/git-review/-/commit/8cf544dbe7d257116f4416a73f611a0ee9b9f08b
------------------------------------------------------------------------
* New upstream release:
    - works with OpenSSH 9.X (Closes: #1012808).
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1012808

#1012808#15
Date:
2022-06-30 16:01:42 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
git-review, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1012808@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Goirand <zigo@debian.org> (supplier of updated git-review package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 30 Jun 2022 17:19:10 +0200
Source: git-review
Architecture: source
Version: 2.3.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenStack <team+openstack@tracker.debian.org>
Changed-By: Thomas Goirand <zigo@debian.org>
Closes: 1012808
Changes:
 git-review (2.3.1-1) unstable; urgency=medium
 .
   * New upstream release:
     - works with OpenSSH 9.X (Closes: #1012808).
Checksums-Sha1:
 df74e192cfabf15d4c33f62614059e0633fa35b7 2232 git-review_2.3.1-1.dsc
 8125d0a755570516d60b9a46b121b784604aad44 46888 git-review_2.3.1.orig.tar.xz
 84871e5555eb287441a933746c0a8ff7ef493312 3884 git-review_2.3.1-1.debian.tar.xz
 03d39ddabf3bda18ab10214544d4e1bcca7e2b7f 9150 git-review_2.3.1-1_amd64.buildinfo
Checksums-Sha256:
 f86dabaf93489d937803078a8581cb5e06fdd83967d4bdb196617da6064d7547 2232 git-review_2.3.1-1.dsc
 092c5cf672d498181fcc87b6ffef8fd371c6fbef03a3ac4edfbc5462bdac3304 46888 git-review_2.3.1.orig.tar.xz
 4acbb43fd3911cbbd1255867fc6d81a93aedd541c6a48af37760fc33f52314c3 3884 git-review_2.3.1-1.debian.tar.xz
 b57ae66d855b083584b95ef2f01f2a876e7a0a6ab38c75fdcf967505592a81de 9150 git-review_2.3.1-1_amd64.buildinfo
Files:
 5feafcc2ea6e025f9bfbfe8d4be8386b 2232 vcs optional git-review_2.3.1-1.dsc
 8a29e2c1a2f3ad65f526a2c18de2632b 46888 vcs optional git-review_2.3.1.orig.tar.xz
 eba9a1ba8f190dc53e79924b86c3d916 3884 vcs optional git-review_2.3.1-1.debian.tar.xz
 1148dce0460ece5f69a4531ebcd871f9 9150 vcs optional git-review_2.3.1-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoLGp81CJVhMOekJc1BatFaxrQ/4FAmK9v2sACgkQ1BatFaxr
Q/69ig//Vkxm2jYuZg4KWDgECdbPOKHuK5+gRcwrAN5SvLFnEJ9KUpoGUaAvzcrY
3RjWI6B5KNVognYLMAOPY/7xnL4Mnc1JwE9IDm/BMT7DrB/qdEN5CsVnl/0V1uU4
cvG8p7F8RqbAi2MCipc/eHThKM5p8N8scPKcOVN0b8ZIuPEqBdzXBRhWFeZHPYGm
lWW+9y6paBu23GZHTi3yHeWQOY36a8p4Acz65gaELJl1DuQlijsu6uNGlKOAi9Ct
Eo4XaTcceiHPP63y1paCP6fc3IE39d4Cxcjb4s1LCfUPF/VL46WXdrahkHQbAzUY
p4van76Jb2dxybV5HZiwzkyneAHF4WpA7vQ04C2keJVond7twUa7ve5XPAQABO3k
Q8riyde1nuF1kcGLFBQoPAzM8mZ5UoJnM/2tc3B+d3srOF5YuchveqlO36e6fFLJ
UuQX1tA8vetVPLXKUvRpQlRB/spvsB6nH1RjtqVS8tgtCYY6itgIbMfcY/fObvQd
NYlNV0XzWPcsplkA17sNyOkut6ypkmPmzSOguG5IgHXxG3NeAATIq1j0oC4PNHkI
aAkihZrhPMjAMzLldFlztB/BC/H7nQnDI2nGyd+b3c5s53/KUAs/xNco7jnX5VU4
RNJ3VDdiikH6KxPBADMLuJ9cLss47UR6t58Oiq0AGVAkHYdJlB8=
=C2GM
-----END PGP SIGNATURE-----