Dear Maintainer, Since Poppler 22.06 made its way into experimental, Scribus will need compatibility changes that are already in upstream to build. I cherry-picked the relevant changes in the attached patches. However, although they apply fine with `patch` on the .orig, the patches won't apply with `debuild`, and I couldn't figure out why. I'm hoping you will spot it faster than I.
Hi, 22.2.0") that is already included in the package, there is little surprise there. And extra problem is that one patch has broken newlines, messing with the new patches (I don't know if that's a quirk of the svn→git export, or what, but I don't care so I replaced it with the proper SVN patch instead). And one change (the one bumping the required poppler version) is not needed. I guess you picked changes from the master branch instead of v15x branch? Also, note that scribus' original VCS is SVN, so please at least point out where those commits where coming from. And it would probably be best to attach them in the form of patches, not plain diffs (so at least they get authorship information, comments, probably also the svn-git connection that would have made my life easier in finding the original svn commits). I'll soon be uploading a version with these changes, however I'd appreciate if somebody else could test-build against poppler 22.06, as I'm kind of overloaded at this time. And if you are involved in poppler, I'd also appreciate if you could work on https://bugs.debian.org/969907 (or point it to somebody (jbicha?)), as it's IMHO being underestimated.
Hi, 22.2.0") that is already included in the package, there is little surprise there. And extra problem is that one patch has broken newlines, messing with the new patches (I don't know if that's a quirk of the svn→git export, or what, but I don't care so I replaced it with the proper SVN patch instead). And one change (the one bumping the required poppler version) is not needed. I guess you picked changes from the master branch instead of v15x branch? Also, note that scribus' original VCS is SVN, so please at least point out where those commits where coming from. And it would probably be best to attach them in the form of patches, not plain diffs (so at least they get authorship information, comments, probably also the svn-git connection that would have made my life easier in finding the original svn commits). I'll soon be uploading a version with these changes, however I'd appreciate if somebody else could test-build against poppler 22.06, as I'm kind of overloaded at this time. And if you are involved in poppler, I'd also appreciate if you could work on https://bugs.debian.org/969907 (or point it to somebody (jbicha?)), as it's IMHO being underestimated.
Hello, Bug #1012850 in scribus reported by you has been fixed in the Git repository and is awaiting an upload. You can see the commit message below and you can check the diff of the fix at: https://salsa.debian.org/debian/scribus/-/commit/75129fce512be46bf81c2129ca07c1538f607fba ------------------------------------------------------------------------ Add a few patches from upstream to fix build with poppler 22.06 Closes: #1012850 Signed-off-by: Mattia Rizzolo <mattia@debian.org> ------------------------------------------------------------------------ (this message was generated automatically) -- Greetings https://bugs.debian.org/1012850
We believe that the bug you reported is fixed in the latest version of
scribus, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1012850@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mattia Rizzolo <mattia@debian.org> (supplier of updated scribus package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sat, 18 Jun 2022 16:08:24 +0200
Source: scribus
Architecture: source
Version: 1.5.8+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Mattia Rizzolo <mattia@debian.org>
Changed-By: Mattia Rizzolo <mattia@debian.org>
Closes: 1012850
Changes:
scribus (1.5.8+dfsg-3) unstable; urgency=medium
.
* Replace the poppler22 patch from the one specific for branch 15x, also
fixing the mangled newlines.
* Add patches from upstream to fix build with poppler 22.04 and 22.06.
Closes: #1012850
* Bump Standards-Version to 4.6.1, no changes needed.
Checksums-Sha1:
5ae314920844bfd0631f0a6e16aaaa9822bfad7d 2505 scribus_1.5.8+dfsg-3.dsc
eeb8e53d378df05e2b68ef8261464173487db8a2 51496 scribus_1.5.8+dfsg-3.debian.tar.xz
70f7a067fc86b651e5ea2aca0976769d61f49a17 21401 scribus_1.5.8+dfsg-3_amd64.buildinfo
Checksums-Sha256:
b98adf8ee7098d63ea16b20926225b52fdde364052c377e8d4467b6c8f76ae34 2505 scribus_1.5.8+dfsg-3.dsc
c60dbe500b10da174efd7a2f63242e7a90568c31c84c84ac0be577dfc81f281e 51496 scribus_1.5.8+dfsg-3.debian.tar.xz
9cf425a4149f7240b7c651a1230c19bbd45aea7b0f3cb4b3138dcc10208460a5 21401 scribus_1.5.8+dfsg-3_amd64.buildinfo
Files:
d7f5cd4db98b76f9690de81f9c802e45 2505 graphics optional scribus_1.5.8+dfsg-3.dsc
ec2562360207ddb3196f0a73061eceb1 51496 graphics optional scribus_1.5.8+dfsg-3.debian.tar.xz
981f6c761d6ecd7ea2cd39e4200a6fa5 21401 graphics optional scribus_1.5.8+dfsg-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAmKt34MACgkQCBa54Yx2
K63gMw//Q47BlP45Km61DhsudMZ0l7DO8rUu7llQ2I00Hy2sU41P/nGiqb5vK1YT
53JEDNcyvGF7a9sVpu4T7cZ8rzaMqBmYgeGQ77BQ1mIYJpUfzvNtm8Zx1RDx3U48
yJypx3vvSW9wOKGSNn6QNnUbSISDRXTqgAKRYi9O5ffGDx1odkG4VehD5B/Nvbwu
JEWQ6Nl75fI3M6Xq1Du+wUmsQxSG3pzJmuY6KR+i9YXysyGP5bGSke30jWCL/tS5
igv1lI+C47NvAKbTlRF/6ADKWXprzavsF6srBdUYckrV4KdTFmoAVGjSLVxjpt98
azsPrOmisXL5/o479FwLQ9MUvYAEaHkYlSxY7VoUQ03QL9tQM3d4qc0xaG1ke4Z1
gLgwQ395yWFpFFVNs/ykvbOu5/VXPnwhvkMHsXSYVndH4iBuSJp+I802T6ODGfeV
pqT9xQ/dM7g0XyJnoP3U0e5FYvded9GJLO8oTFhEuFCyZNC/thzNIuKt0VnkcUFx
8H18QuoT0YoqhR6982tHNSKhZLMJmQ+Q3mqVpjvmXVJut2UXLVCPwlvZxjKHz5KE
Bcx3dw17lwKIM3HQSrmOCp0GWXBE2ltQBIjkdcgURmQ7+A/wRao5Jn6ARBguo+aH
Z/VHqkcrVc+ZDEecNXVDMiz8kyI3+zoGxGfYSyLMOCpdpYDCPIw=
=w4Ii
-----END PGP SIGNATURE-----
I don't know how to fix that issue. Sorry. Thank you, Jeremy Bicha
The patches were retrieved from the master branch and from mirror at <https://github.com/scribusproject/scribus/>. https://github.com/scribusproject/scribus/commit/85c0dff3422fa3c26fbc2e8d8561f597ec24bd92 https://github.com/scribusproject/scribus/commit/f2237b8f0b5cf7690e864a22ef7a63a6d769fa36 https://github.com/scribusproject/scribus/commit/f19410ac3b27e33dd62105746784e61e85b90a1d https://github.com/scribusproject/scribus/commit/e013e8126d2100e8e56dea5b836ad43275429389 The first of which, as you noted, was already included. I apologize for the mistake. I confirm it builds against Poppler 22.06, as tested with Sbuild. Thank you for your work on Scribus. there is little And it would probably be
Great, thank you for checking! :)
I forgot the patch headers in my last submission, here is the same patch with them.
Sorry, disconsider my last message, sent to the wrong bug number. Am 2022/06/30 um 12:09 schrieb Nathan Teodosio: