- Package:
- src:jsonnet
- Source:
- jsonnet
- Submitter:
- Bastian Germann
- Date:
- 2022-07-03 00:09:03 UTC
- Severity:
- serious
- Tags:
jsonnet does not build on several release architecture due to: /<<PKGBUILDDIR>>/third_party/rapidyaml/rapidyaml/ext/c4core/src/c4/ext/debugbreak/debugbreak.h: In function ‘void debug_break()’: /<<PKGBUILDDIR>>/third_party/rapidyaml/rapidyaml/ext/c4core/src/c4/ext/debugbreak/debugbreak.h:111:17: error: ‘trap_instruction’ was not declared in this scope
Hello Bastian, Thanks for reporting this. And apologies for a late reply. To address this FTBFS issue, I uploaded the following changes to s <http://mentors.debian.net>alsa. * fix FTBFS on several release architectures * fix FTBFS error on armel * Remove mipsel, mips64el, s390x as build target For further information, kindly visit the following URL: https://salsa.debian.org/dfukui/jsonnet/-/commits/debian/0.18.0+ds-2 If you don't mind, I would appreciate it if you sponsor and help me upload this package. The following are some technical comments. According to the original source code [0], c4core does not support the following CPU architectures: s390x, mipsel, mips64el Thus, we should drop these ones from the Architecture field on d/control. Meanwhile, debugbreak should have been successfully built by falling back to raising SIGTRAP [1] for several architectures, but build fails due to a bug in upstream. This issue has already been addressed [2], so a patch [3] was created and added to d/patches based on upstream. In a similar story, I fixed FTBFS on armel and filed a patch [4]. Thanks for reading. [0] https://github.com/biojppm/c4core/blob/52f3ff57b287ce57c2bbf80dc091bd21e4d9f977/src/c4/cpu.hpp [1] https://github.com/google/jsonnet/blob/v0.18.0/third_party/rapidyaml/rapidyaml/ext/c4core/src/c4/ext/debugbreak/debugbreak.h#L123 [2] https://github.com/scottt/debugbreak/commit/8b4a755e76717103adc814c0c05ceb3b91befa7d [3] https://salsa.debian.org/dfukui/jsonnet/-/commit/1bea08d549c450b8c9624e686df88f025e1d3d5c [4] https://salsa.debian.org/dfukui/jsonnet/-/commit/efb346e3ec210104897c38979291ab68e1eead73 Best, Fukui
Hello Bastian, Thanks for reporting this. And apologies for a late reply. To address this FTBFS issue, I uploaded the following changes to s <http://mentors.debian.net>alsa. * fix FTBFS on several release architectures * fix FTBFS error on armel * Remove mipsel, mips64el, s390x as build target For further information, kindly visit the following URL: https://salsa.debian.org/dfukui/jsonnet/-/commits/debian/0.18.0+ds-2 If you don't mind, I would appreciate it if you sponsor and help me upload this package. The following are some technical comments. According to the original source code [0], c4core does not support the following CPU architectures: s390x, mipsel, mips64el Thus, we should drop these ones from the Architecture field on d/control. Meanwhile, debugbreak should have been successfully built by falling back to raising SIGTRAP [1] for several architectures, but build fails due to a bug in upstream. This issue has already been addressed [2], so a patch [3] was created and added to d/patches based on upstream. In a similar story, I fixed FTBFS on armel and filed a patch [4]. Thanks for reading. [0] https://github.com/biojppm/c4core/blob/52f3ff57b287ce57c2bbf80dc091bd21e4d9f977/src/c4/cpu.hpp [1] https://github.com/google/jsonnet/blob/v0.18.0/third_party/rapidyaml/rapidyaml/ext/c4core/src/c4/ext/debugbreak/debugbreak.h#L123 [2] https://github.com/scottt/debugbreak/commit/8b4a755e76717103adc814c0c05ceb3b91befa7d [3] https://salsa.debian.org/dfukui/jsonnet/-/commit/1bea08d549c450b8c9624e686df88f025e1d3d5c [4] https://salsa.debian.org/dfukui/jsonnet/-/commit/efb346e3ec210104897c38979291ab68e1eead73 Best, Fukui
Am 01.07.22 um 11:44 schrieb Daichi Fukui: Please first read and address my comments on https://mentors.debian.net/package/jsonnet/
Am 01.07.22 um 11:44 schrieb Daichi Fukui: Please first read and address my comments on https://mentors.debian.net/package/jsonnet/
Hello Bastian, Thanks for pointing this out. https://github.com/biojppm/debugbreak/commit/8b4a755e76717103adc814c0c05ceb3b91befa7d OK, I followed DEP-3 and updated the patches i made accordingly. See: https://salsa.debian.org/dfukui/jsonnet/-/commit/1bea08d549c450b8c9624e686df88f025e1d3d5c https://salsa.debian.org/dfukui/jsonnet/-/commit/efb346e3ec210104897c38979291ab68e1eead73 architectures. Got it. Here is an updated changelog: https://salsa.debian.org/debian/jsonnet/-/commit/21be6a0c840ca38ad002b2a031c7077ecb6fb674 Ah yes, I remembered I was recently granted permission for the Vcs. I've uploaded the latest updates here: https://salsa.debian.org/debian/jsonnet/-/commits/debian/0.18.0+ds-2 Indeed. I'll be careful about this. Best, Fukui
Thanks for the update! For the next version, please fix blhc (see CI pieline fails).
We believe that the bug you reported is fixed in the latest version of jsonnet, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1013310@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Fukui Daichi <a.dog.will.talk@akane.waseda.jp> (supplier of updated jsonnet package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) Format: 1.8 Date: Sat, 02 Jul 2022 13:23:19 +0000 Source: jsonnet Architecture: source Version: 0.18.0+ds-2 Distribution: unstable Urgency: medium Maintainer: Fukui Daichi <a.dog.will.talk@akane.waseda.jp> Changed-By: Fukui Daichi <a.dog.will.talk@akane.waseda.jp> Closes: 1013310 Changes: jsonnet (0.18.0+ds-2) unstable; urgency=medium . * fix FTBFS on several release architectures (Closes: #1013310) * fix FTBFS error on armel * Allow only specific architectures as build targets Checksums-Sha1: 631081b126c15ed3976d7afac6c085827869a322 2193 jsonnet_0.18.0+ds-2.dsc a0018a90bb1f8751632248066523add8315f5c98 7196 jsonnet_0.18.0+ds-2.debian.tar.xz 992e55bf6a0d9c29d5ba40b59b8c5054cd027705 7252 jsonnet_0.18.0+ds-2_source.buildinfo Checksums-Sha256: e1b2c45a1b4c2736ff85bb638c279d7f23911cd0edb3ec3a543cd59c3e433705 2193 jsonnet_0.18.0+ds-2.dsc dfaa8afdc3de75439dd7609ae9f3c0c313f3472cc9c07e82659cd81c2591e1a4 7196 jsonnet_0.18.0+ds-2.debian.tar.xz 9adfce54dd118a633446fe1783412421c2a701364a72b455761440ff8f7f160d 7252 jsonnet_0.18.0+ds-2_source.buildinfo Files: f335c91e6735867193d0cab53de8cb5d 2193 devel optional jsonnet_0.18.0+ds-2.dsc 71aad48a7d0bee4e0a3bc4ab4286665d 7196 devel optional jsonnet_0.18.0+ds-2.debian.tar.xz 65def1e078d056fe3c92e1fb3131a6a4 7252 devel optional jsonnet_0.18.0+ds-2_source.buildinfo -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmLA1+gQHGJhZ2VAZGVi aWFuLm9yZwAKCRAfXHqLRVZDFCHCC/9GBOabzoaZD2JcRKsxeDOdpUAQBppxCRth oCD0yVpc3OCuO8uFaJcLAYAvVbO/9XAMdxbzuuUVyOARojh5Bjdzi78KwBqSSYE/ Z8Rra1nUuOKoSkvmS+DNoeu6aEwqSK7dZgph5L+R7LnerParQITpSY/njuZz1FLo tgzrOc7ILNCmDh4EbtdEngSfwbJSAjLhwNZ8sLLOEEMofb5l+6cJjXY+twzInHPu kYFRbNISMaOteUC6IPu/+PjvEW8NO93cwdnWDRx6wxfFwWdx5Fb2cPnPD8YHk4u0 FUEwm+R/JUxXllHSZDfT+kHrczCztUcnQzI94n6mcTx45uWY6MJogeTbIuOuuvm9 15w/3Dd17aTcitaZbb1hIihd25l6P73UqfGrpU354OCVusDRuH9X5Y2T4j+unSfQ k6KbzkgR6yuAdODzaNYiwSJn4T4TOb1Y9lEdUwnS8nu+nONFmPuk9jlZXrAdadl+ Sjei5aeBP6GO+Xjzdt38t44qbHFejwk= =X2b7 -----END PGP SIGNATURE-----