Dear Maintainer,

With pinentry-qt 1.1.0-4, running

 echo getpin | pinentry-qt --display "Test"

would display a *floating* dialog box under the Sway WM. This is the
desired behavior. As of 1.2.0-1, it instead displays a "full-size"/tiled
window.

I bisected through upstream's later commits, and found that

 dd9f765258230cad6704afb4fab6c3deb4a8de56

fixes the problem. I'm including a patch based on

 8f239a2b133cae8ca9c1876c732d4e00d06c7d26
 7d5c123f802abce11c711d57e8796d58d6ff1a16
 dd9f765258230cad6704afb4fab6c3deb4a8de56

(read top to bottom) that I have confirmed fixes the problem. I'll also
place an MR on Salsa.


 Best,
 Gard

patch from qlyiss on https://dev.gnupg.org/D549 :


Index: qt/pinentrydialog.cpp
===================================================================
--- qt/pinentrydialog.cpp
+++ qt/pinentrydialog.cpp
@@ -280,6 +280,7 @@
     mainLayout->addLayout(hbox);
     mainLayout->addStretch(1);
     mainLayout->addWidget(buttons);
+    mainLayout->setSizeConstraint(QLayout::SetFixedSize);

     auto capsLockWatcher = new CapsLockWatcher{this};
     connect(capsLockWatcher, &CapsLockWatcher::stateChanged,


This seems much more narrowly targeted!  Gard, can you test this against
1.2.0?  If you can confirm that it works for you, i'd be happy to patch
the debian package.

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

Hah, that is indeed a lot simpler – and I can confirm that it works :-)

Thanks!


 Best,
 Gard

We believe that the bug you reported is fixed in the latest version of
pinentry, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1013318@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Kahn Gillmor <dkg@fifthhorseman.net> (supplier of updated pinentry package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Fri, 24 Jun 2022 22:38:56 -0400
Source: pinentry
Architecture: source
Version: 1.2.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian GnuPG Maintainers <pkg-gnupg-maint@lists.alioth.debian.org>
Changed-By: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Closes: 979412 1013318
Changes:
 pinentry (1.2.0-2) unstable; urgency=medium
 .
   * Fix --lc-ctype in manpages (Closes: #979412)
   * wrap-and-sort -ast
   * qt: fix floating dialog under sway (Closes: #1013318)
   * Standards-Version: bump to 4.6.1 (no changes needed).
Checksums-Sha1:
 c13c970a81489325f52d5a761e258e73afc9de4d 2242 pinentry_1.2.0-2.dsc
 0f0ecf865c9152dd394eca9acbc9318363da970e 19160 pinentry_1.2.0-2.debian.tar.xz
 706f476b95b9fa153c2d7c8bdc6053f5d8916892 20302 pinentry_1.2.0-2_amd64.buildinfo
Checksums-Sha256:
 43d974d725f0e261449ea1aa340b00e9e53c0e567f12db7da41942ecc07bd755 2242 pinentry_1.2.0-2.dsc
 628541197becd30a5da77a79b878d9e9df4954334792db7b4f740bc3109bdc4d 19160 pinentry_1.2.0-2.debian.tar.xz
 13fe420564b4437f111c52328f8335d01d8e1efd639689516775190b9aeda383 20302 pinentry_1.2.0-2_amd64.buildinfo
Files:
 339038069d1ccb6487aa77b2a23a8371 2242 utils optional pinentry_1.2.0-2.dsc
 01984786ce1134ef142c15c9fc4bcbb2 19160 utils optional pinentry_1.2.0-2.debian.tar.xz
 de0c37143e46b15127c6b91873268dd3 20302 utils optional pinentry_1.2.0-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQQttUkcnfDcj0MoY88+nXFzcd5WXAUCYrZ2WgAKCRA+nXFzcd5W
XPQmAQCiu3pvqeS/MIIf3xkJiYQ09NY7St4w0AdypTffq6XhQwEAgV8vcITEK+Gu
zatXbFpOKCIDiiJIvT3FgCM2i+5RTAg=
=93Ii
-----END PGP SIGNATURE-----