#1013417 lintian: dkms updates

Package:
lintian
Source:
lintian
Submitter:
Andreas Beckmann
Date:
2023-02-05 11:03:03 UTC
Severity:
normal
Tags:
#1013417#5
Date:
2022-06-23 08:58:13 UTC
From:
To:
Hi,

I recently split a dh-dkms package from the dkms binary package.
Please update lintian's suggestions for the respective B-D:

for 'dh --with dkms', there should be a B-D: dh-dkms (instead of
B-D: dkms)

for 'dh_dkms', there should be a B-D: dh-dkms (instead of B-D: dkms)
or (preferably) B-D: dh-sequence-dkms (lintian already knows about that).

And the I'd like to have all *-dkms binary packages to have
  Testsuite: autopkgtest-pkg-dkms
on their source package. Not sure how to model that in lintian.
Either on the source package: B-D: dh-dkms | B-D: dh-sequence-dkms
or on the binary package relationships: Depends: dkms
or on the binary package content: /usr/src/*/dkms.conf

Andreas
#1013417#10
Date:
2022-06-23 10:12:04 UTC
From:
To:
Hi Andreas,

Andreas Beckmann wrote:
[…]

I'm aware of that. It is partially already supprted in Lintian since
commit cfafa44256133c458011e3f13440de6538dd6045 which is part of the
2.115.0 release already:

https://salsa.debian.org/lintian/lintian/-/commit/cfafa44256133c458011e3f13440de6538dd6045#78b2b372e63b40b17bfc9c37d820cbf5b2ebb24c_103_108

I'm just not sure if such a hard cut is a good way to actually handle
the old and new variant for a transition period. Then again, lintian
is probably the last place which should care about old packages. :-)

I thought that's already done by the change mentioned above, but then
again a quick git grep also found this as of the current git HEAD:

lib/Lintian/Check/Debhelper.pm:    dh_dkms => 'dkms:any | dh-sequence-dkms:any',

Looking for that is how I found the line above. :-)

That's on my TODO list to figure out how it actually works for my own
dkms-based package. :-)

I think I can figure out. :-)

Indeed, package name matches /-dkms$/ is probably not enough.

Will think about it.

Thanks!

		Regards, Axel
#1013417#17
Date:
2023-01-04 10:02:51 UTC
From:
To:
Hi,

attached is a patch that fixes the lintian warning about a missing
dh-dkms dependency for using dh_dkms.

I'm not closing this bug since it does not address the
autopkgtest-pkg-dkms recommendation.


Andreas
#1013417#24
Date:
2023-02-05 11:00:26 UTC
From:
To:
Hi Andreas,

Andreas Beckmann wrote:

Applied without the (IMHO bogus) debian/changelog changes as
https://salsa.debian.org/lintian/lintian/-/commit/d50a732a00a7596d078a9e8f6919cb6362ca0067

Ok. I've allowed myself to nevertheless add a reference to this bug
report as "(See #1013417)" in a way that it will also show up in the
later generated debian/changelog entry.

		Regards, Axel