#1018950 gettext-el: warnings when po-mode.el is compiled with GNU Emacs 28

#1018950#5
Date:
2022-09-02 11:40:47 UTC
From:
To:
When going to po-mode (e.g. "emacs fr.po"), I get the following
warnings when po-mode.el is compiled with GNU Emacs 28:

Warning (comp): po-mode.el:1069:14: Warning: ‘write-contents-hooks’ is an obsolete variable (as of 22.1); use ‘write-contents-functions’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2114:2: Warning: (lambda nil \.\.\.) quoted with ' rather than with #' Disable showing Disable logging
Warning (comp): po-mode.el:2570:37: Warning: ‘goto-line’ is for interactive use only; use ‘forward-line’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2640:10: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2643:13: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2707:36: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer Disable showing Disable logging
Warning (comp): po-mode.el:2736:35: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer Disable showing Disable logging
Warning (comp): po-mode.el:2111:4: Warning: the function ‘ediff-quit’ is not known to be defined. Disable showing Disable logging

#1018950#10
Date:
2024-06-25 17:15:58 UTC
From:
To:
Hi.

There was an update of po-mode in version 0.21-14, so I think this
is very likely to be fixed in such version (present in trixie and above).

Can you please confirm?

Thanks.

#1018950#15
Date:
2024-06-26 01:12:17 UTC
From:
To:
Hi,

With emacs-gtk 1:29.4+1-2 and gettext-el 0.22.5-1 in unstable,
I no longer see any issue, even after removing the .emacs.d/eln-cache
directory.

I've also tried with emacs-nox 1:28.2+1-15+deb12u3 and gettext-el 0.21-12
in stable (bookworm), and the issue is reproducible with this version.
On this machine, if I just replace the po-mode.el file by the one from
gettext-el_0.21-14_all.deb or gettext-el_0.22.5-1_all.deb, the issue is
still reproducible.

#1018950#22
Date:
2024-06-26 11:23:09 UTC
From:
To:
tags 1018950 + bookworm
fixed 1018950 0.21-14
thanks

El 26/6/24 a las 3:12, Vincent Lefevre escribió:

Thanks for the additional testing.

I tried using emacs + po-mode in bookworm and yes, I can see the
warnings myself, but in a random way (don't know yet what triggers them).

However, your last paragraph seems to indicate that the new po-mode by
itself does not fix the problem. I don't see a 100% correct way to handle
the metadata in this bug, so I'm going to consider this fixed in the 0.21-14
version with the meaning that you have to upgrade to trixie (i.e. upgrade
emacs as well) to get the fix. We could alternatively clone this bug
and reassign the clone to emacs, but since everything seems to work
in trixie, I don't think that would improve things a lot.

Thanks.

#1018950#31
Date:
2024-06-26 13:00:22 UTC
From:
To:
Control: tags -1 - bookworm
Control: notfixed -1 gettext/0.21-14
Control: found -1 0.22.5-1
Control: severity -1 minor
Control: retitle -1 gettext-el: warnings when po-mode.el is compiled with GNU Emacs 28+ (hidden with Emacs 29)
to stable with

  aptitude install emacs-gtk/stable emacs-bin-common/stable emacs-common/stable emacs-el/stable

(thus to GNU Emacs 28.2), and... I can now see the warnings:

Warning (comp): po-mode.el:1068:14: Warning: ‘write-contents-hooks’ is an obsolete variable (as of 22.1); use ‘write-contents-functions’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2113:2: Warning: (lambda nil \.\.\.) quoted with ' rather than with #' Disable showing Disable logging
Warning (comp): po-mode.el:2569:37: Warning: ‘goto-line’ is for interactive use only; use ‘forward-line’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2639:10: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2642:13: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2706:36: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer Disable showing Disable logging
Warning (comp): po-mode.el:2735:35: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer Disable showing Disable logging
Warning (comp): po-mode.el:2110:4: Warning: the function ‘ediff-quit’ is not known to be defined. Disable showing Disable logging

So, the bug is not fixed in gettext-el.

I can actually see warnings in the Async-native-compile-log buffer
with GNU Emacs 29 (current Debian/unstable version); see below. So,
what has changed is that Emacs now hides the warnings.

In short:
  * GNU Emacs 28 shows annoying warnings. This should be regarded
    as a bug, but this will probably be never fixed in this version
    for Debian/stable (and Debian/unstable is not affected as it
    has GNU Emacs 29), so I don't think that it is useful to clone
    the bug.
  * The warnings are still present (but hidden), so that the bug is
    actually not fixed. Since GNU Emacs 29 hides them, I've lowered
    the severity to minor.

Here are the details of the warnings (note that the compilation of
the other .el files does not yield any warning; this is specific
to po-mode.el):

In toplevel form:
po-mode.el:180:2: Warning: custom-declare-variable `po-highlight-face' docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:473:2: Warning: custom-declare-variable `po-gzip-uuencode-command' docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:503:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-create-overlay:
po-mode.el:556:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:843:2: Warning: defvar `po-auxiliary-cursor' docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-mode:
po-mode.el:1013:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:1068:14: Warning: ‘write-contents-hooks’ is an obsolete variable (as of 22.1); use ‘write-contents-functions’ instead.

In po-set-msgid:
po-mode.el:1812:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-set-msgstr-form:
po-mode.el:1831:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:2114:13: Warning: (lambda nil \...) quoted with ' rather than with #'

In po-edit-string:
po-mode.el:2238:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-seek-equivalent-translation:
po-mode.el:2408:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-cycle-auxiliary:
po-mode.el:2449:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-select-auxiliary:
po-mode.el:2486:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-show-source-context:
po-mode.el:2570:4: Warning: ‘goto-line’ is for interactive use only; use ‘forward-line’ instead.

In po-tags-search:
po-mode.el:2639:10: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead.
po-mode.el:2643:8: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead.

In po-tags-loop-operate:
po-mode.el:2703:12: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer

In po-mark-found-string:
po-mode.el:2724:6: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer

In po-validate:
po-mode.el:3185:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-msgfmt-version-check:
po-mode.el:3212:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In end of data:
po-mode.el:2110:4: Warning: the function ‘ediff-quit’ is not known to be defined.

#1018950#46
Date:
2024-06-26 13:41:29 UTC
From:
To:
Hello.

Some time ago I received this report from Vincent Lefevre regarding po-mode.
The problem seems not to be fixed in the current version.

I include below a summary of the issue. The full history may be found here:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1018950

Thanks.
-----------------------------------
From: Vincent Lefevre <vincent@vinc17.net>

[...]

On my Debian/unstable machine, I've downgraded the emacs packages
to stable with

   aptitude install emacs-gtk/stable emacs-bin-common/stable emacs-common/stable emacs-el/stable

(thus to GNU Emacs 28.2), and... I can now see the warnings:

Warning (comp): po-mode.el:1068:14: Warning: ‘write-contents-hooks’ is an obsolete variable (as of 22.1); use ‘write-contents-functions’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2113:2: Warning: (lambda nil \.\.\.) quoted with ' rather than with #' Disable showing Disable logging
Warning (comp): po-mode.el:2569:37: Warning: ‘goto-line’ is for interactive use only; use ‘forward-line’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2639:10: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2642:13: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2706:36: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer Disable showing Disable logging
Warning (comp): po-mode.el:2735:35: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer Disable showing Disable logging
Warning (comp): po-mode.el:2110:4: Warning: the function ‘ediff-quit’ is not known to be defined. Disable showing Disable logging

So, the bug is not fixed in gettext-el.

I can actually see warnings in the Async-native-compile-log buffer
with GNU Emacs 29 (current Debian/unstable version); see below. So,
what has changed is that Emacs now hides the warnings.

In short:
   * GNU Emacs 28 shows annoying warnings. This should be regarded
     as a bug, but this will probably be never fixed in this version
     for Debian/stable (and Debian/unstable is not affected as it
     has GNU Emacs 29), so I don't think that it is useful to clone
     the bug.
   * The warnings are still present (but hidden), so that the bug is
     actually not fixed. Since GNU Emacs 29 hides them, I've lowered
     the severity to minor.

Here are the details of the warnings (note that the compilation of
the other .el files does not yield any warning; this is specific
to po-mode.el):

In toplevel form:
po-mode.el:180:2: Warning: custom-declare-variable `po-highlight-face' docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:473:2: Warning: custom-declare-variable `po-gzip-uuencode-command' docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:503:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-create-overlay:
po-mode.el:556:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:843:2: Warning: defvar `po-auxiliary-cursor' docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-mode:
po-mode.el:1013:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:1068:14: Warning: ‘write-contents-hooks’ is an obsolete variable (as of 22.1); use ‘write-contents-functions’ instead.

In po-set-msgid:
po-mode.el:1812:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-set-msgstr-form:
po-mode.el:1831:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:2114:13: Warning: (lambda nil \...) quoted with ' rather than with #'

In po-edit-string:
po-mode.el:2238:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-seek-equivalent-translation:
po-mode.el:2408:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-cycle-auxiliary:
po-mode.el:2449:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-select-auxiliary:
po-mode.el:2486:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-show-source-context:
po-mode.el:2570:4: Warning: ‘goto-line’ is for interactive use only; use ‘forward-line’ instead.

In po-tags-search:
po-mode.el:2639:10: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead.
po-mode.el:2643:8: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead.

In po-tags-loop-operate:
po-mode.el:2703:12: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer

In po-mark-found-string:
po-mode.el:2724:6: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer

In po-validate:
po-mode.el:3185:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-msgfmt-version-check:
po-mode.el:3212:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In end of data:
po-mode.el:2110:4: Warning: the function ‘ediff-quit’ is not known to be defined.

#1018950#49
Date:
2024-06-26 13:41:29 UTC
From:
To:
Hello.

Some time ago I received this report from Vincent Lefevre regarding po-mode.
The problem seems not to be fixed in the current version.

I include below a summary of the issue. The full history may be found here:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1018950

Thanks.
-----------------------------------
From: Vincent Lefevre <vincent@vinc17.net>

[...]

On my Debian/unstable machine, I've downgraded the emacs packages
to stable with

   aptitude install emacs-gtk/stable emacs-bin-common/stable emacs-common/stable emacs-el/stable

(thus to GNU Emacs 28.2), and... I can now see the warnings:

Warning (comp): po-mode.el:1068:14: Warning: ‘write-contents-hooks’ is an obsolete variable (as of 22.1); use ‘write-contents-functions’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2113:2: Warning: (lambda nil \.\.\.) quoted with ' rather than with #' Disable showing Disable logging
Warning (comp): po-mode.el:2569:37: Warning: ‘goto-line’ is for interactive use only; use ‘forward-line’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2639:10: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2642:13: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2706:36: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer Disable showing Disable logging
Warning (comp): po-mode.el:2735:35: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer Disable showing Disable logging
Warning (comp): po-mode.el:2110:4: Warning: the function ‘ediff-quit’ is not known to be defined. Disable showing Disable logging

So, the bug is not fixed in gettext-el.

I can actually see warnings in the Async-native-compile-log buffer
with GNU Emacs 29 (current Debian/unstable version); see below. So,
what has changed is that Emacs now hides the warnings.

In short:
   * GNU Emacs 28 shows annoying warnings. This should be regarded
     as a bug, but this will probably be never fixed in this version
     for Debian/stable (and Debian/unstable is not affected as it
     has GNU Emacs 29), so I don't think that it is useful to clone
     the bug.
   * The warnings are still present (but hidden), so that the bug is
     actually not fixed. Since GNU Emacs 29 hides them, I've lowered
     the severity to minor.

Here are the details of the warnings (note that the compilation of
the other .el files does not yield any warning; this is specific
to po-mode.el):

In toplevel form:
po-mode.el:180:2: Warning: custom-declare-variable `po-highlight-face' docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:473:2: Warning: custom-declare-variable `po-gzip-uuencode-command' docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:503:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-create-overlay:
po-mode.el:556:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:843:2: Warning: defvar `po-auxiliary-cursor' docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-mode:
po-mode.el:1013:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:1068:14: Warning: ‘write-contents-hooks’ is an obsolete variable (as of 22.1); use ‘write-contents-functions’ instead.

In po-set-msgid:
po-mode.el:1812:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-set-msgstr-form:
po-mode.el:1831:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)
po-mode.el:2114:13: Warning: (lambda nil \...) quoted with ' rather than with #'

In po-edit-string:
po-mode.el:2238:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-seek-equivalent-translation:
po-mode.el:2408:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-cycle-auxiliary:
po-mode.el:2449:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-select-auxiliary:
po-mode.el:2486:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-show-source-context:
po-mode.el:2570:4: Warning: ‘goto-line’ is for interactive use only; use ‘forward-line’ instead.

In po-tags-search:
po-mode.el:2639:10: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead.
po-mode.el:2643:8: Warning: ‘tags-loop-continue’ is an obsolete function (as of 27.1); use ‘fileloop-continue’ instead.

In po-tags-loop-operate:
po-mode.el:2703:12: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer

In po-mark-found-string:
po-mode.el:2724:6: Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer

In po-validate:
po-mode.el:3185:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In po-msgfmt-version-check:
po-mode.el:3212:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In end of data:
po-mode.el:2110:4: Warning: the function ‘ediff-quit’ is not known to be defined.