Hi,

This package contains three font files /usr/share/python-qtawesome/fonts/fontawesome5-*-webfont.ttf
which are licensed freely but are not built from source and cannot be built from source
(missing build system). #902981 has the details.

Please repack the package to get rid of these files.

Thanks,
Bastian

Hi Bastian,

I saw you have excluded the files in unreleased 1.2.1+dfsg-1 version of
the package. Are you planning to upload it soon, or are there any blockers?

Best,
Andrius

Hi all,

I have seen this and will deal with it soon.  Have you contacted the
authors of the package to discuss this issue?

I also forgot to push my 1.2.1-1 changes to salsa, unfortunately.
Oops!  But that's history now.

Anyway, a quick check on testing shows that there are three packages
depending on python3-qtawesome: finalcif, openlp, python3-spyder.  I
know about python3-spyder (and it has the same upstream developers as
python3-qtawesome), but finalcif and openlp's maintainers might not
realise the issue and be surprised when they start getting bug reports
about icons missing (or the package failing) - it would be polite to
email their maintainers and uploaders before releasing this DFSG
version of the package.

Best wishes,

   Julian

Ah, I never released that version, so please ignore this comment!
Salsa is fine.

Best wishes,

   Julian

Hi,

No, I did not.

I got the impression that the removed fonts can be drop-in-replaced with
ones from DFSG-compatible fork from fonts-fork-awesome, but I did not
check that. I am in contact with finalcif upstream and could talk to
them, but I would first try the drop-in replacement approach.

Best,
Andrius

Am 09.12.22 um 08:28 schrieb Julian Gilbey:

openlp is not affected. I know the package and have uploaded it several times.

Am 09.12.22 um 07:49 schrieb Andrius Merkys:
https://salsa.debian.org/python-team/packages/python-qtawesome/-/jobs/3625869

Either we patch it or do not run it. I tried not running it but end up with a stack trace in that case.
I will investigate on the weekend.

Hi Andrius,

I've been looking at this a bit this morning - I don't have more time
today, but I think that would be a very sensible thing to do before
releasing a DFSG version of this package.  If the ForkAwesome fonts
can do the job, then great!

Best wishes,

   Julian

forwarded https://github.com/spyder-ide/qtawesome/issues/220
thanks

I've found out from the Spyder developers that Spyder doesn't use
FontAwesome, so it's not a problem to remove it from my perspective.
See the GitHub issue noted above.

I'm also now looking into the Material Design Icon fonts; see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=973617
I also now don't understand why there are two different MDI fonts in
this package.  But that's a separate issue.

Best wishes,

   Julian

finalcif's source has some fa5 prefixes, so the package might be affected.
Andrius, can you please comment on this?

Hi,

Yes, these are calls to qtawesome.icon('fa5.save') and the like. But if
fonts can be drop-in-replaced with ones from fonts-fork-awesome then I
think these icon functions should work as expected.

Andrius

I have replaced Font Awesome 5 with Fork Awesome and have tested it with finalcif.
The icons look a bit different but it works.

We believe that the bug you reported is fixed in the latest version of
python-qtawesome, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1025000@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Germann <bage@debian.org> (supplier of updated python-qtawesome package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Wed, 04 Jan 2023 21:05:15 +0100
Source: python-qtawesome
Architecture: source
Version: 1.2.1+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Team <team+python@tracker.debian.org>
Changed-By: Bastian Germann <bage@debian.org>
Closes: 1025000
Changes:
 python-qtawesome (1.2.1+dfsg-1) unstable; urgency=medium
 .
   * Team upload
   * Exclude fontawesome5 fonts (Closes: #1025000)
   * Replace excluded fonts with Fork Awesome
   * New upstream version 1.2.1+dfsg
   * Disable tests
Checksums-Sha1:
 293e1efb9624e0ff1a57d3ef3708d9ea09656ccb 2365 python-qtawesome_1.2.1+dfsg-1.dsc
 1be2b61583bf96a03788906d6c950a02c6736a44 1552000 python-qtawesome_1.2.1+dfsg.orig.tar.xz
 a82f0696f5e9a138a030d90a839190f9a4589956 11440 python-qtawesome_1.2.1+dfsg-1.debian.tar.xz
 2d85cc71e4795e6b5ad5c561512b242d822f4b92 13967 python-qtawesome_1.2.1+dfsg-1_source.buildinfo
Checksums-Sha256:
 c3b21b1a5b054257e6e34c8088d0eefb74af59b990ce0107ef90246d9b336dea 2365 python-qtawesome_1.2.1+dfsg-1.dsc
 271dfb2e4ab7d3584e644dfa3a928c8b4a9b4a482a2dad157121cbdd1fdb3ccb 1552000 python-qtawesome_1.2.1+dfsg.orig.tar.xz
 b37648eb2e2ad6f1cfd622504aa4dde6bea822ca40a92cbb63f7f057dd9efe01 11440 python-qtawesome_1.2.1+dfsg-1.debian.tar.xz
 3613965056ca73ecb5edc95586cecd2f52498fb6f7a68df907509d4d0f21c5dc 13967 python-qtawesome_1.2.1+dfsg-1_source.buildinfo
Files:
 440fbfc709a9d06d42f999274d000d4a 2365 python optional python-qtawesome_1.2.1+dfsg-1.dsc
 13be8bb5dd7a901eb5643830cf05bda2 1552000 python optional python-qtawesome_1.2.1+dfsg.orig.tar.xz
 5cda409b629cdd6e72e709fd30453187 11440 python optional python-qtawesome_1.2.1+dfsg-1.debian.tar.xz
 c459db81b61033fc2903fe7d1b775e3b 13967 python optional python-qtawesome_1.2.1+dfsg-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmO13bEQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFC/uDACx8LCRCX1nOP/zSdxYmlSnBSzC+yhEZP1Q
FTZorDYgXf3FssZnlvocafcz55l8EdnmLCrnosOjlXcjtK46eLaxfAFFxuzKvPss
ZPBWC1GYex9khk4nS5ySvtNY5b0OPpo6BUr3F0nmke8OLg268nDXbvAL1d58v/dm
97cBNNo43ugHdUgbHOpMiDH+Tko0gNFQ/6W2CqzF9rRVd1QAi5wwgpahMkuVb25l
Pt+Bgr8L/lF0Qs3qUJfCtIcXaN3q3Ji1J37L+pHDG4gbPRYOqZnknVsnxykiPUCv
wr/nb2MZOVnAnlYSPCwh2zOE3nk4OL39muP+jmjqsKPRSc42kRyFtnAwlT+ua5cn
lxExnmFjwPwFo1jSC2SuQQ7Nzu9/RUtdgRqKBoezNDVNEFaJvkuEL58FLLt7FxV+
h7bCF376p0BfR8QhL2p9tXcSO4JcgvVLpzHPj6L7yGmfhwxK3V145ScKWwCIWAJs
lUPO6p3OOqu1DHeN/AAaCKjMjkyzEFM=
=Vwkj
-----END PGP SIGNATURE-----