#1025334 Update binary package and XS-Go-Import-Path to match go.mod

#1025334#5
Date:
2022-12-02 17:37:47 UTC
From:
To:
When building gitaly I get,

src/gitlab.com/gitlab-org/gitlab/vendor/github.com/prometheus/client_golang/prometheus/desc.go:22:2:
cannot find package "github.com/cespare/xxhash/v2" in any of:

/<<PKGBUILDDIR>>/_build/src/gitlab.com/gitlab-org/gitlab/vendor/github.com/cespare/xxhash/v2
(vendor tree)
        /usr/lib/go-1.19/src/github.com/cespare/xxhash/v2 (from $GOROOT)
        /<<PKGBUILDDIR>>/_build/src/github.com/cespare/xxhash/v2 (from
$GOPATH

even though golang-github-cespare-xxhash-dev is installed.

I think the import path and binary package name should be bumped to
match go.mod:
module github.com/cespare/xxhash/v2

so binary package should be golang-github-cespare-xxhash-v2-dev. Though
I'm not 100% sure about the XS-Go-Import-Path as I think it should
match without a change there.

#1025334#10
Date:
2022-12-02 17:54:53 UTC
From:
To:
No. The Go compiler can find it automatically. Please see the detail at

https://lists.debian.org/debian-go/2020/06/msg00009.html

I think you may have done some non-standard magic in your package.

#1025334#15
Date:
2022-12-02 17:57:21 UTC
From:
To:
On Sat, Dec 3 2022 at 01:54:53 AM +08:00:00 +08:00:00, Shengjing Zhu <zhsj@debian.org> wrote:

I just vendored some dependencies till protobuf 1.5 vs 1.3 settle down.
So from a vendored module, it is not able to find this module.

#1025334#20
Date:
2022-12-02 17:59:47 UTC
From:
To:
And you can find there are many packages which use
github.com/cespare/xxhash/v2 in the code.

https://codesearch.debian.net/search?q=filetype%3Ago+github.com%2Fcespare%2Fxxhash%2Fv2&literal=1

But they are built successfully, including the
golang-github-prometheus-client-golang package.

#1025334#25
Date:
2022-12-03 07:18:39 UTC
From:
To:
On Sat, Dec 3, 2022 at 2:00 AM Pirate Praveen <praveen@onenetbeyond.org> wrote:
[...]

I don't think this is cause.

For example, golang-k8s-klog is also a v2 module, and it doesn't have
v2 in XS-Go-Import-Path.
But packages which have vendor library which uses that v2 path, can be
built successfully.
For example,
https://sources.debian.org/src/containerd/1.6.9~ds1-1/vendor/k8s.io/client-go/rest/request.go/#L48

#1025334#30
Date:
2022-12-03 07:41:30 UTC
From:
To:
You can reproduce this issue with
https://salsa.debian.org/ruby-team/gitlab/ (after uncommenting the
manual v2 in rules).

https://people.debian.org/~praveen/staging/ has newer build depends
(gitaly and gitlab-labkit)

#1025334#35
Date:
2022-12-02 18:27:37 UTC
From:
To:
On Sat, Dec 3 2022 at 01:59:47 AM +08:00:00 +08:00:00, Shengjing Zhu <zhsj@debian.org> wrote:

I think the problem comes when a module in vendor tries to find this
module. The following lines fixes the error.

mkdir -p ${BUILDDIR}/vendor/github.com/cespare/xxhash
	ln -s /usr/share/gocode/src/github.com/cespare/xxhash
${BUILDDIR}/vendor/github.com/cespare/xxhash/v2

here github.com/prometheus/client_golang is added in vendor because
gitlab (and gitaly) need golang-github-golang-protobuf-1-5-dev which
currently not possible to get via apt. Yes, this is a work around until
we fix the conflict.

#1025334#40
Date:
2026-10-06 07:43:55 UTC
From:
To:
Dear submitter,

as the package golang-github-cespare-xxhash has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/1149917

The version of this package that was in Debian prior to this removal
can still be found using https://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Thorsten Alteholz (the ftpmaster behind the curtain)