#1026877 opari2: please make the build reproducible

#1026877#5
Date:
2022-12-23 05:32:47 UTC
From:
To:
Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
opari2 could not be built reproducibly.

Patch attached that exports CFLAGS from dpkg-buildflags(1), ensuring
that -fdebug-prefix-map (and similar) to the underlying build system.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

#1026877#10
Date:
2022-12-23 10:53:58 UTC
From:
To:
Hello,

Chris Lamb, le ven. 23 déc. 2022 05:32:47 +0000, a ecrit:

Thanks for the patch!

I'm wondering, though, how it is that the salsa reprotest CI didn't
catch it:

https://salsa.debian.org/debian/opari2/-/jobs/3675809

Is there some salsa-ci option that I should enable to make it more
picky?

Samuel

#1026877#17
Date:
2022-12-23 18:00:37 UTC
From:
To:
Hi Samuel,

That's a good question and I don't actually know the answer. :(

Indeed, I'm not actually that familiar with reprotest myself, so I'm
likely not the best person to ask. Could you quickly try the
reproducible-builds@lists.alioth.debian.org mailing list?


Regards,

#1026877#22
Date:
2022-12-23 23:04:02 UTC
From:
To:
Hello,

Chris Lamb, le ven. 23 déc. 2022 05:32:47 +0000, a ecrit:

I'm wondering how it is that the salsa reprotest CI didn't catch it:

https://salsa.debian.org/debian/opari2/-/jobs/3675809

Is there some salsa-ci option that I should enable to make it more
picky?

Samuel

#1026877#27
Date:
2022-12-24 00:01:48 UTC
From:
To:
https://salsa.debian.org/debian/opari2/-/jobs/3696823#L1036

  INFO:reprotest:build "experiment-1": FIX environment, FIX build_path, ...

Something is telling reprotest to not vary build paths. I also see weird
things suggesting the standard build path reprotest uses is duplicated:

https://salsa.debian.org/debian/opari2/-/jobs/3696823#L473

  make[1]: Entering directory '/tmp/reprotest.57Bwiu/const_build_path/const_build_path'

Normally, there would just be a single "const_build_path" subdir. I
noticed this issue on one of the packages I maintain, but haven't poked
at it yet.

This suggests to me the salsa-ci reprotest jobs are somehow manually
adjusting the build paths in some way above-and-beyond how reprotest
normally varies the build path? We probably should follow-up with the
salsa-ci folks...


The example for the salsa-ci suggests that build paths variations are
enabled by default under the "Adding extra arguments to reprotest":

https://salsa.debian.org/salsa-ci-team/pipeline/-/tree/master#adding-extra-arguments-to-reprotest

  variables:
    SALSA_CI_REPROTEST_ARGS: --variations=-build_path

You could try inverting it, and passing --variations=+build_path


live well,
  vagrant

#1026877#32
Date:
2022-12-24 11:07:45 UTC
From:
To:
Hello,

Vagrant Cascadian, le ven. 23 déc. 2022 16:01:48 -0800, a ecrit:

That seems to be working indeed:

https://salsa.debian.org/debian/opari2/-/jobs/3702025

I let the reproducibility team discuss with CI about really having
--variations=+all enabled by default :)

Samuel

#1026877#37
Date:
2024-03-31 22:44:20 UTC
From:
To:

#1026877#48
Date:
2024-03-31 22:48:23 UTC
From:
To:

#1026877#55
Date:
2024-03-31 22:54:24 UTC
From:
To:
James Addison, le dim. 31 mars 2024 23:44:20 +0100, a ecrit:

Thanks!

#1026877#64
Date:
2026-05-08 22:09:57 UTC
From:
To: