#1031327 gbp-rpm-ch: Wrong changelog header format (missing dash before version)

Package:
git-buildpackage
Source:
git-buildpackage
Submitter:
Samuel Henrique
Date:
2023-02-24 18:12:06 UTC
Severity:
normal
Tags:
#1031327#5
Date:
2023-02-14 23:16:11 UTC
From:
To:
As stated in the title, the changelog header has the wrong format.

Specfile documentation:
https://rpm-packaging-guide.github.io/#working-with-spec-files
...
 Follow this format for the first line:

 * Day-of-Week Month Day Year Name Surname <email> - Version-Release
...

I have provided a patch on Github at
https://github.com/agx/git-buildpackage/pull/89

The patch is also attached to this bug report.

Thank you,
#1031327#10
Date:
2023-02-19 15:43:18 UTC
From:
To:
Hi Samueloph,

https://src.fedoraproject.org/rpms/phosh/blob/rawhide/f/phosh.spec

You need to fixup the tests too though, e.g.:

======================================================================
FAIL: Test set_header() method
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/var/scratch/src/git-buildpackage/git-buildpackage/tests/30_test_rpm_changelog.py", line 99, in test_set_header
    eq_(str(section), "* Thu Jan 30 2014 Jane <u@h> 1.1\n- my change\n\n")
AssertionError: '* Thu Jan 30 2014 Jane <u@h> - 1.1\n- my change\n\n' != '* Thu Jan 30 2014 Jane <u@h> 1.1\n- my change\n\n'

Cheers,
 -- Guido
#1031327#15
Date:
2023-02-21 20:33:34 UTC
From:
To:
Hello Guido,

I have updated the Github PR and also attached the new patch with the
unit tests fixed.

Thank you,
#1031327#20
Date:
2023-02-24 18:10:19 UTC
From:
To:
control: -1 tags +pending

Hi Samuel,

Appied. Thanks!
 -- Guido