#1032948 linux-image-6.1.0-5-amd64: oops in ucsi_acpi_notify

Package:
src:linux
Source:
src:linux
Submitter:
Julien Cristau
Date:
2023-04-08 15:57:22 UTC
Severity:
normal
Tags:
#1032948#5
Date:
2023-03-14 13:55:04 UTC
From:
To:
Hi,

After upgrading to 6.1.12-1 my laptop started hanging regularly (3 times
in a few hours).  Downgraded to 6.1.8-1 and I've not seen this for a
week, so this looks like a recent regression.
Not all the hangs left traces in logs, but I got at least one oops:

Cheers,
Julien
#1032948#10
Date:
2023-03-14 14:29:08 UTC
From:
To:
Testing now has 6.1.15-1, can you test it with that?
There's another update in the pipeline (at least to 6.1.19) and when it
becomes available, it would be useful if you could test that as well.
#1032948#15
Date:
2023-03-16 10:17:19 UTC
From:
To:
Version: 6.1.15-1

I rebooted on 6.1.15-1 last night and things are still looking good so
I'll call this fixed.  Thanks.

Cheers,
Julien
#1032948#20
Date:
2023-03-16 19:39:51 UTC
From:
To:
Bummer.

Since 6.1.8 I found the following 2 commits in drivers/usb/typec/ucsi:

3d7f77e55da3455c8844b651e37779c90e201f48 titled
"usb: ucsi: Ensure connector delayed work items are flushed"

fdd11d7136fd070b3a74d6d8799d9eac28a57fc5 titled
"usb: typec: ucsi: Don't attempt to resume the ports before they exist"

Especially the first one looks 'promising'.
Can you make a patch which reverts that commit and use 'test-patches' from
https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html
to build a kernel and test that?
#1032948#25
Date:
2023-03-16 17:11:27 UTC
From:
To:
Control: reopen -1
Control: found it 6.1.15-1
Spoke too soon:

Cheers,
Julien
#1032948#34
Date:
2023-03-18 20:13:01 UTC
From:
To:
The following looks similar, though it is reported to happen on dock
unplug. I assume your issue is independent on that?

Regards,
Salvatore
#1032948#39
Date:
2023-03-18 20:33:10 UTC
From:
To:
And if you do some bisection/tests with the above questions from
Diederik, might you try as well

https://patchwork.kernel.org/project/linux-usb/patch/20230306103359.6591-2-hdegoede@redhat.com/

(it is not yet applied mainline).

Regards,
Salvatore
#1032948#44
Date:
2023-03-18 22:10:39 UTC
From:
To:
I guess that is https://bugzilla.kernel.org/show_bug.cgi?id=217106 ?
https://lore.kernel.org/all/20230308154244.722337-1-hdegoede@redhat.com/
#1032948#49
Date:
2023-04-03 12:57:02 UTC
From:
To:
doesn't fix the crash, pretty much instant upon unplugging my monitor.

I'll give the patch series you linked in the other reply a go now.

Cheers,
Julien
#1032948#54
Date:
2023-04-03 13:16:42 UTC
From:
To:
#1032948#59
Date:
2023-04-04 11:11:16 UTC
From:
To:
Thanks for letting me know.  I've built 6.1.22 from upstream and it
doesn't seem to crash.

Cheers,
Julien
#1032948#64
Date:
2023-04-04 20:03:28 UTC
From:
To:
You may have seen it on IRC already, but could you test a
Debian 6.1.20-1 kernel with (only) those patches applied?
These are the URLs:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.1.y&id=1c5abcb13491da8c049f20462189c12c753ba978
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.1.y&id=1e8525f37871741a52370627633962f8bdcab15a

If you need help with that, feel free to ask :-)

If we know that fixes the issue too, then we have the option of going for
a 6.1.20-2 release with just those 2 patches (and what's already in -2 now).

TIA,
  Diederik
#1032948#69
Date:
2023-04-05 15:53:58 UTC
From:
To:
Hi,

I'm also affected by this - recent lenovo laptop with a dock that
connects/removes multiple usb devices at the same time. Been getting
the oops after every resumption or every time multiple usb devices got
reset, with 6.1.0-6 and 6.1.0-7.

Built and booted a patched debian 6.1.20 and been using it for ~1hr
now without experiencing any issues. Connected and disconnected the
dock (and its devices) multiple times, suspended/resumed twice as
well.

I'd prefer to keep using it for some more time before calling it a
success, but it certainly feels better. With the normal kernel
disconnecting the dock was triggering a crash almost every time.

Costas
#1032948#74
Date:
2023-04-05 19:04:05 UTC
From:
To:
Hi Costas,

Thanks already for your additional testing!

Regards,
Salvatore
#1032948#79
Date:
2023-04-06 12:10:31 UTC
From:
To:
Control: tag -1 upstream fixed-upstream patch
Testing this now:

linux (6.1.20-1a~test) UNRELEASED; urgency=medium

  * Testing patches ../0001-usb-ucsi-Fix-NULL-pointer-deref-in-
    ucsi_connector_ch.patch ../0001-usb-ucsi_acpi-Increase-the-command-
    completion-timeou.patch
#1032948#86
Date:
2023-04-06 12:48:12 UTC
From:
To:
Still stable throughout the day with the patched kernel. No oopses or
crashes after unplugging the dock or random usb devices and
suspending/resuming multiple times since yesterday.

It seems these patches solve the issue - for my combination of devices at least!

best,
Costas
#1032948#91
Date:
2023-04-06 15:36:27 UTC
From:
To:
Hi Julien,

Great, thanks! Then I'm going to pick those two commits as well for
6.1.20-2 and do that before continuing on 6.1.23.

Regards,
Salvatore
#1032948#98
Date:
2023-04-08 15:55:21 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1032948@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Salvatore Bonaccorso <carnil@debian.org> (supplier of updated linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sat, 08 Apr 2023 17:36:24 +0200
Source: linux
Architecture: source
Version: 6.1.20-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
Changed-By: Salvatore Bonaccorso <carnil@debian.org>
Closes: 925424 1019118 1030200 1031180 1032136 1032948 1033566 1033732
Changes:
 linux (6.1.20-2) unstable; urgency=medium
 .
   [ Hans van Kranenburg ]
   * d/t/control.tools-unversioned.in: version rtla build deps
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: Supply the host pkg-config to the rtla build. (Closes: #1019118)
 .
   [ Francesco Dolcini ]
   * [armhf] Add support for NXP i.MX7 SOC (Closes: #1031180)
 .
   [ Martyn Welch ]
   * [arm64] ti: am62x: Enable support for am625-sk eval board
   * d/salsa-ci.yml: Increase timeout of CI build stage to 3 hours
 .
   [ наб ]
   * Re-instate "KEYS: Make use of platform keyring for module signature verify"
     (Closes: #1030200)
 .
   [ Vincent Blut ]
   * drivers/input/touchscreen: Enable TOUCHSCREEN_SILEAD as module
     (Closes: #925424)
   * [x86] drivers/platform/x86: Enable TOUCHSCREEN_DMI
   * drivers/scsi/mpi3mr: Enable SCSI_MPI3MR as module (Closes: #1033566)
 .
   [ Diederik de Haas ]
   * [arm64,armhf] Enable DRM_PANEL_FEIYANG_FY07024DI26A30D as module
 .
   [ Cyril Brulebois ]
   * udeb: add intel_lpss* (optional) to kernel-image (Closes: #1032136)
     Many laptops have their touchpad accessible over I2C, only visible
     if LPSS is available in the installer.
 .
   [ Salvatore Bonaccorso ]
   * [x86] acpi/boot: Correct acpi_is_processor_usable() check (Closes: #1033732)
   * usb: ucsi: Fix NULL pointer deref in ucsi_connector_change()
     (Closes: #1032948)
   * usb: ucsi_acpi: Increase the command completion timeout (Closes: #1032948)
   * [arm64] hwmon: (xgene) Fix use after free bug in xgene_hwmon_remove due to
     race condition (CVE-2023-1855)
   * net/sched: act_mirred: better wording on protection against excessive stack
     growth
   * act_mirred: use the backlog for nested calls to mirred ingress
     (CVE-2022-4269)
   * [x86] xirc2ps_cs: Fix use after free bug in xirc2ps_detach (CVE-2023-1670)
   * Bluetooth: HCI: Fix global-out-of-bounds (CVE-2023-28866)
 .
   [ Henning Schild ]
   * [x86] drivers/gpio: Enable GPIO_F7188X as module
Checksums-Sha1:
 43988866bbba4b3078bd387019f8ea61af58a57e 276943 linux_6.1.20-2.dsc
 c93d6989e7f5f70bfdbbe4c23c2a6c60bf745df3 4585780 linux_6.1.20-2.debian.tar.xz
 89ac3cacc90d4bf1520933154ff544cd733d405a 6754 linux_6.1.20-2_source.buildinfo
Checksums-Sha256:
 0770faca88ec9da5711fc0d5abdd150d188c56bf8dd19ae0120aa22f5fe69a3e 276943 linux_6.1.20-2.dsc
 8fc1b579ed50f458975aa1d65ae3d513e64a8fd207d192ea8767a58e72dd09b6 4585780 linux_6.1.20-2.debian.tar.xz
 03e4305c5b89cf7ef15affc35dcbaac4bca6df9fcdb58e42a1a02b34d970da85 6754 linux_6.1.20-2_source.buildinfo
Files:
 73cd74091256a472038d9eba264ef69d 276943 kernel optional linux_6.1.20-2.dsc
 d6be3828376d26b9e72d747e09c7439c 4585780 kernel optional linux_6.1.20-2.debian.tar.xz
 28f64e24560ed3fe22e4e1b005963146 6754 kernel optional linux_6.1.20-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQKmBAEBCgCQFiEERkRAmAjBceBVMd3uBUy48xNDz0QFAmQxirJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDQ2
NDQ0MDk4MDhDMTcxRTA1NTMxRERFRTA1NENCOEYzMTM0M0NGNDQSHGNhcm5pbEBk
ZWJpYW4ub3JnAAoJEAVMuPMTQ89EN50QAJD7Wy9uBqCRXZ6dJyC2tmM+fS8zxU/r
NqVhS3CzCKRhDWtRBKl9dzvMbXIKRJeMGvvYcmRGqBTGs3mdHgZ3li04zmcTGWo1
V+EcmFRN90MAdqcxAWC5wTJyxGMroPQVXFkW6IFd4tZQOzLmyc4vU2+f8z63I4XR
J7gLJ4mUfFyadSNq+BllK1F+YQJWwcMGhR6ZKWQ6uBUM+pjagm0ALjZ3j/bkzGvI
qIPhekny/XZ9tjDZ4bq93ddomYXDYH+P3gGfVEs9S5LOHKol6eU7SFnWB1g5aD5m
VatQNIU2Afpfc63uY7+zIsyojqq7rQNBnL4Yp24Cwpkw0ESjiOxeipjFgVQrq+c0
79j7Hyhdv/pnYyqeY8v9IEW9bZvrbhNiJ43UaWj5BmDlZSjeVFBDuAVC6ogWl/vy
nkQO9G6LKa8ZKcIBFlWz5nllCO3lG2dKeHLoRwMCE9gVCG9EuU9DI49KLLx6MDYC
uPyDntSVt5Wjj7ltN/3m8YFsTKpHxHh0F/ly96kH7A1aEv1VG1E5fp0sO3Hq5Z3b
cjbzObwRBjtxTlxOOtZYoteVI6n36T8xRSbN/SehBv1C3+XNe8vq93AxTbABJ1Ip
u9Nr8lGmNvYiTY3M9IBxqIhrPr4z/QHktfEHj4pJ6QnRlawdhdKO5yN/WifO15tf
wnmw9YRegy2j
=fmzO
-----END PGP SIGNATURE-----