#1033103 superficial-tests: false positive when both Testsuite + d/t/control are used

#1033103#5
Date:
2023-03-17 11:53:00 UTC
From:
To:
In the experimental branch of src:esptool, I've defined the following:
  * Testsuite: autopkgtest-pkg-pybuild in debian/control, to test the
    Python module.
  * Three superficial tests in debian/tests/control to test the CLI
    tools using --help.

TTBOMK this is valid configuration. autodep8(1) has a section titled
"COMBINING AUTO-GENERATED TESTS WITH MANUALLY SPECIFIED ONES" to cover
this use case.

Indeed, autodep8 generates a file that has the manual tests combined
with a pybuild-autopkgtest one. The pybuild-autopkgtest one is *not*
marked as as superficial[1], as evident by the autodep8 output.

As another piece of evidence, autopkgtest reports:
  autopkgtest [13:39:27]: @@@@@@@@@@@@@@@@@@@@ summary
  smoke-esptool        PASS (superficial)
  smoke-espefuse       PASS (superficial)
  smoke-espsecure      PASS (superficial)
  pybuild-autopkgtest  PASS

However, lintian is warning about "superficial-tests", and says "The
source package declares tests in the debian/tests/control file but
provides only tests with a superficial restriction.".

It looks to me like a lintian bug, but let me know if I've misunderstood
something.

Regards,
Faidon

1: Debatable in this particular package, but besides the main point.

#1033103#10
Date:
2023-03-17 12:16:08 UTC
From:
To:
In case you go looking at the package to reproduce, note that in the
final upload to experimental I added extra_restrictions=superficial to
debian/tests/autopkgtest-pkg-pybuild.conf, so the autodep8 test will now
also be marked as superficial. In this case the lintian warning is
appropriate.

The bug however stands (it's present when autopkgtest-pkg-pybuild.conf
is not present). It can be reproduced by:
  apt source esptool=4.5.1+dfsg-0.1
  cd esptool*
  rm debian/tests/autopkgtest-pkg-pybuild.conf
  autodep8  # should list a d/t/control with a non-superficial test
  dpkg-buildpackage -S
  lintian ../esptool*dsc

Faidon

#1033103#13
Date:
2026-06-21 01:20:31 UTC
From:
To:
Hello,

Bug #1033103 in lintian reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/lintian/lintian/-/commit/e76f391ce46bb97521b01d47e20891d98c978290

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1033103

#1033103#20
Date:
2026-06-25 17:51:48 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1033103@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nilesh Patra <nilesh@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 25 Jun 2026 19:03:06 +0530
Source: lintian
Architecture: source
Version: 2.137.0
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Nilesh Patra <nilesh@debian.org>
Closes: 140006 1033103
Changes:
 lintian (2.137.0) unstable; urgency=medium
 .
   [ Nilesh Patra ]
   * Summary of tag changes:
     + Added:
       - build-depends-on-dh-sysuser
     + Removed:
       - standards-version-inconsistent
   * Drop tag: standards-version-inconsistent
   * Do not emit `incomplete-creative-commons-license` when the text
     refers to `/usr/share/common-licenses` as CC licenses have been
     added to base-files (See #1139561 and #1136090)
   * Do not flag autopkgtests which have d/t/control along with
     `Testsuite` in d/control as superficial (Closes: #1033103)
   * Bump recommended debhelper compat-level to 14 and change
     experimental level to 15 (Closes: #140006)
     + Fixup testsuite with default debhelper 14 and hard-code to
       lower compat where needed
   * Emit "python3-depends-but-no-python3-helper" regardless of
     debputy or compat 14 as this might mean a missing helper
   * Do not emit "no-versioned-debhelper-prerequisite" when
     `X-DH-Compat` is declared
     + tests (package-uses-x-dh-compat): Adjust to drop FP hint for
       no-versioned-dh
   * Do not emit "package-uses-dh-runit-but-lacks-breaks-substvar"
     when debputy sequencer is used or dh compat is 14 or greater
     + Add test debhelper-dh-runit-but-lacks-breaks-substvar-unrel: to
       validate dh-runit-breaks-substvar against dh 14
   * d/control: Bump debhelper compatibility level to 14
 .
   [ Steev Klimaszewski ]
   * Add profile for ParrotOS
 .
   [ Luca Boccassi ]
   * Add new tag: build-depends-on-dh-sysuser error
 .
   [ Agathe Porte ]
   * tags: udev-rule-in-etc: account for usrmerge
Checksums-Sha1:
 2095a62d21f325686b7013bf4035be99a1bc68c2 3593 lintian_2.137.0.dsc
 93ba8e93a10a3757d2ed28743ee5a8a8e1326461 2025140 lintian_2.137.0.tar.xz
 093fe3c11d69b177945a8f8d2edff85b24525e18 21256 lintian_2.137.0_amd64.buildinfo
Checksums-Sha256:
 a82380127488f9d8b0b9823e12ee9dfcd1b5fe104fe39579375b71029f2f5db0 3593 lintian_2.137.0.dsc
 02775e99806837bec03183d6936eeb03f637a1612e535967f60346d2ce30a5db 2025140 lintian_2.137.0.tar.xz
 68df84ff382035b76b0b7f44e9bce9cbdf6be7bede5cc8774402555c16070ab0 21256 lintian_2.137.0_amd64.buildinfo
Files:
 2aed4afb07b2ba9ae94b76c915845aea 3593 devel optional lintian_2.137.0.dsc
 a919b337315eaec425d9406e74e077d2 2025140 devel optional lintian_2.137.0.tar.xz
 7023c2f6554892f62e57bd8b88e6cf44 21256 devel optional lintian_2.137.0_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iIgEARYKADAWIQSglbZu4JAkvuai8HIqJ5BL1yQ+2gUCaj1fexIcbmlsZXNoQGRl
Ymlhbi5vcmcACgkQKieQS9ckPtrQRgD+Py0A1fCd/ePsmoG0I7T94gIJp2JN2+If
An9GaqAANvsBAO7ZHShHQJNt9lkam2pieEDQ2ZARXxn9dj5gg7jgAWAE
=kbTo
-----END PGP SIGNATURE-----