#1033633 newsboat: ftbfs with -Werror

Package:
newsboat
Source:
newsboat
Description:
text mode rss feed reader with podcast support
Submitter:
Steve Langasek
Date:
2025-09-18 20:39:03 UTC
Severity:
normal
Tags:
#1033633#5
Date:
2023-03-29 06:27:32 UTC
From:
To:
Package: newsboat
Version: 2.21-1.5
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu lunar ubuntu-patch

Hi Nikos,

In Ubuntu, we've found that newsboat fails to build from source in some
environments because passing -Werror -Wall, gcc cannot detect that a
particular pointer won't be used before initialization:

[...]
In member function ‘__dt_base ’,
    inlined from ‘fetch_feed’ at src/ocnewsapi.cpp:288:1:
/usr/include/c++/12/bits/unique_ptr.h:396:24: error: ‘response’ may be used uninitialized [-Werror=maybe-uninitialized]
  396 |           get_deleter()(std::move(__ptr));
      |                        ^
src/ocnewsapi.cpp: In member function ‘fetch_feed’:
src/ocnewsapi.cpp:202:22: note: ‘response’ was declared here
  202 |         json_object* response;
      |                      ^
lto1: all warnings being treated as errors
make[3]: *** [/tmp/cc4iQyn6.mk:218: /tmp/cctiXKcc.ltrans72.ltrans.o] Error 1
[...]

This is probably only an issue when building with LTO enabled as well.

Anyway, it's a false-positive and rather than spending more than 2 seconds
thinking about pointers in C++, I patched the package in Ubuntu to skip this
particular warning flag.  Please see the attached patch for your consideration.

Thanks,

#1033633#10
Date:
2025-09-18 20:37:11 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
newsboat, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1033633@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Germann <bage@debian.org> (supplier of updated newsboat package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 18 Sep 2025 19:57:55 +0200
Source: newsboat
Architecture: source
Version: 2.36-1.2
Distribution: unstable
Urgency: medium
Maintainer: Nikos Tsipinakis <nikos@tsipinakis.com>
Changed-By: Bastian Germann <bage@debian.org>
Closes: 1033633 1114221
Changes:
 newsboat (2.36-1.2) unstable; urgency=medium
 .
   * Non-maintainer upload
   * Work around Curl 8.16.0 curl_proxytype issue (Closes: #1114221)
   * Build with -Wno-error to prevent FTBFS (Closes: #1033633)
Checksums-Sha1:
 f6cfbed34cff5453b21822b70066cf6318d274bf 2838 newsboat_2.36-1.2.dsc
 8507c0e1e4b786fa27d1c7ea77ee76f2a2e2175d 13632 newsboat_2.36-1.2.debian.tar.xz
 569328e40479916b3c9db901793531a2ee8f9645 6793 newsboat_2.36-1.2_source.buildinfo
Checksums-Sha256:
 1c82ae1e6961ec07adb7ccee42edd34f6081d0e1292a848e610b153bedd73f9d 2838 newsboat_2.36-1.2.dsc
 0213856aff80a868bdadafecbab0995017f7db6eb36eb32c0e93ae861aea4391 13632 newsboat_2.36-1.2.debian.tar.xz
 dda107c72e0318f292d81e47b3941766cc29421afb5b7de404278fcccadd834a 6793 newsboat_2.36-1.2_source.buildinfo
Files:
 3d381be1de96a8af719ceed918e6b994 2838 net optional newsboat_2.36-1.2.dsc
 ebacf08557cbd2a0f413df935c6003d2 13632 net optional newsboat_2.36-1.2.debian.tar.xz
 3c2327ab88d28bc594cf8857e5844c0f 6793 net optional newsboat_2.36-1.2_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmjMZCgQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFMhSDACG6ZPfcAQO0uW7TpHD6BTGoQT0BKAA1aGU
S6TPgq3y1vh/9IWcHfYQd5PX5Mf39qV4bBVyhz6qA8ZbGbrBJYCxzd1KsEkVmfS7
FsWXqd6ruSTEMCCR7NoeFwNKmJb4J90pNsKh8I8ZmPqotyhuWm1VrADx0QX+iWuH
1wuiZHm89TkatMMa1EcH9Tt3GhkinSLb7TlfN39hQxnod8QwmtgsAx6kP231bdmr
VRbCfXWR01QziTGIC2BcaTd7PMGSQyT6nfrsXSsgiCGKa4bTN0QBWVromxerSkzq
xHq587Vmrx6KUdJDbY1EEIL7+XnMqGjpihNxURDSzG8aC4/UrJ4bYT6IKmK+GG7b
VDgE6JSCWUHzGXE3lInYedOMUa2U1eKvgMrP0ZwvTkuKDvusEbP+yoIvBMyCwbS7
NxTpjZhrlOubv4QgyXNgex2C+6Gv0CCCvnNI+nitycznQvTwLZkcRR+H86sjTYPm
37YLOuQBD+tEQAnskABfTH6XyQ6GTIE=
=nzD5
-----END PGP SIGNATURE-----