- Package:
- release.debian.org
- Source:
- release.debian.org
- Submitter:
- David Bannon
- Date:
- 2023-04-05 07:45:02 UTC
- Severity:
- normal
- Tags:
Please unblock package tomboy-ng v0.36a [ Reason ] Poor testing on my part lead to the use of bad colors for dark themes with version 0.36 currently in Bookworm. This relates to tomboy-ng's recent move to using Qt5 instead of gtk2 and, perhaps, my own person preference to not use dark themes. V0.36a is now uploaded and my sponsor requested I apply for an unblock. [ Impact ] As several users of the version currently in Testing have advised me, with some dark themes, the existing version might display some text with the same color as the background. Not good. [ Tests ] I have personally tested the proposed new version, 0.36a extensively. Similarly, some testing by end users has also taken place. [ Risks ] All changes relate to text colors. No other application logic has changed. As no package depends on tomboy-ng, effects beyond tomboy-ng approach zero. In every case identified, the 0.36a delivers the same or better user experience. [ Checklist ] [x] all changes are documented in the d/changelog [x] I initiated and reviewed all changes and I approve them [x] attach debdiff against the package in testing [ Other info ] Attached is a debdiff between 0.36 and 0.36a, quite a lot of its content relates to the Lazarus IDE's making inconsequential of changes to po and form files. Of significance is changes to man pages (better description of how to manage it's Qt5 colors) and editbox.pas where the means of determining appropriate colors has been changed. Changes to settings.pas to inform user of non-standard colors and save preferences. Some related minor change to loadnote.pas and mainform.pas Thanks for your consideration, David Bannon unblock tomboy-ng 0.36a
Control: tags -1 moreinfo Why are you removing the old changelog entry? Cheers
Good question Sebastian. Sadly, I don't have a good answer. Seems in my haste to get the important fixes into the app in time, I messed up use of my packaging scripts. (Noting I release tomboy-ng in several other Linux packages, Windows and MacOS.) The changelog 'should' look like this (just updated) - https://github.com/tomboy-notes/tomboy-ng/blob/master/debian/changelog But the one you have is missing transition from 0.35 to 0.36. Future releases will have the missing information. // ------- changelog --------------- 1c1 < tomboy-ng (0.36-1) unstable; urgency=medium --- > tomboy-ng (0.36a-1) unstable; urgency=medium 3,14c3,7 < * Release of new version < * From 0.35 to 0.36 - < * New Feature export as PDF. < * New Feature insert a symbol or accented character. < * Bug fix in column mode of calculator. < * Warn user about setting non mono font. < * All Tomdroid functionality removed. < * A fix for SWYT not finding some text in a brand new note. < * Can set colour of a link, more suitable default. < * Use of TextHint to better indicate EditSearch role. < * Revised note button colors for better dark theme use. < * Please see github for further change details --- > * Release of new version. > * More uniform colors when used with qt5ct. > * Man page added info re colors. > * Indicator that custom colors being used. > * Please see github for further change details. 16c9 < -- David Bannon <tomboy-ng@bannons.id.au> Wed, 22 Feb 2023 20:45:26 +1100 --- > -- David Bannon <tomboy-ng@bannons.id.au> Sun, 19 Mar 2023 10:08:23 +1100 // ----------------------------------------------
I'd appreciate a -2 upload fixing the changelog. As 0.36 removes features, users should know about that. Cheers
Hmm, yes, you are quite correct. The Tomdroid link has been removed and that absolutely should be mentioned in the change log (users have been warned for several releases and it was always 'experimental' but still ...) I have now uploaded a -2 version to Mentors. Attached is the debdiff, fortunately the changelog appears at the top ! You will see a much more conventional progression of changes now. https://mentors.debian.net/package/tomboy-ng/ And, obviously, no changes to other than the changelog ! I will notify my sponsor of this upload. Thanks for your help at a busy time. David
Unblocked Cheers
Great news, thanks Sebastian ! (Hmm, do I close this bug or do you ?) Davo
I closed it with my previous mail. Cheers