#1033890#5
Date:
2023-04-03 14:14:46 UTC
From:
To:
Please unblock package safeeyes

[ Reason ]
The version of safeeyes in testing is very broken: (i) it
does not appear in the notification bar for (at least) KDE/Plasma and
XFCE4, making it impossible to control or defer (bug #1006942, though
for some reason that bug was not recorded as RC); (ii) it fails to
load any plugins with Python 3.11, meaning that it fails to function
correctly (most of the package runs via a plugins mechanism, loading
internal plugins; bug #1033106).

Unfortunately, though, I wasn't thinking clearly when I uploaded, and
the diff is rather bigger than it ought to have been (though the vast
majority of it is translation updates).  I'll explain more below in
the "Other info" section.

[ Impact ]
The package will only lock the screen at the chosen intervals with no
ability to control it, defer it, take account of user idle time....

[ Tests ]
Unfortunately there are no autopkgtests in this package.  I did an NMU
for it recently, but have been happily running a local copy of my code
for several weeks.

[ Risks ]
It's a leaf package, and while the current diff is substantial (see
"Other info" below), the changes are all essentially trivial.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
v  [x] attach debdiff against the package in testing

[ Other info ]
I fixed #1006942 by upgrading to a new upstream version.  Given that
it was targeted for bookworm, I should have cherry-picked the relevant
patch.  If this is deemed too much for bookworm, what would you
suggest to fix it?  Should I perhaps upload a version
2.1.5+really2.1.3-0.1 which only has cherry-picked patches?

To assist, here is a list of all changed files in the debdiff and
comments on them:

safeeyes-2.1.5/debian/changelog
safeeyes-2.1.5/debian/control

  This fixes the dependencies to match the packages currently in
  testing (gir1.2-appindicator3-0.1 is no longer present, and
  gir1.2-notify-0.7 is required for the notifications to work)

safeeyes-2.1.5/debian/patches/series
safeeyes-2.1.5/debian/patches/support-python311.patch

  These introduce a one-line patch for the Python 3.11 bug; I
  haven't included DEP-3 headers in this patch, but could do if you
  would like me to.

safeeyes-2.1.5/.github/FUNDING.yml
safeeyes-2.1.5/.github/ISSUE_TEMPLATE/bug_report.md
safeeyes-2.1.5/.github/ISSUE_TEMPLATE/feature_request.md
safeeyes-2.1.5/.github/ISSUE_TEMPLATE/plugin-request.md
safeeyes-2.1.5/.github/workflows/release.yml
safeeyes-2.1.5/.gitignore

  All of these are in the upstream version but it turns out weren't
  included in the previous Debian version.  None of them are used in the
  build or end up in the binary package.

safeeyes-2.1.5/LICENSE
safeeyes-2.1.5/README.md

  URLs updated to use https rather than http

safeeyes-2.1.5/safeeyes/config/locale/*/LC_MESSAGES/safeeyes.po

  Updated translation files (this accounts for most of the bulk of the
  debdiff)

safeeyes-2.1.5/safeeyes/glade/about_dialog.glade

  URLs changed from http to https, and version number update

safeeyes-2.1.5/safeeyes/__main__.py

  A safety check to prevent crashing in case locale does not support
  bindtextdomain (though why it would not, I don't know)

safeeyes-2.1.5/safeeyes/plugins/donotdisturb/plugin.py

  This is a small bug fix.

safeeyes-2.1.5/safeeyes/plugins/smartpause/dependency_checker.py
safeeyes-2.1.5/safeeyes/plugins/smartpause/plugin.py

  This is new code to support the "sway" desktop environment.

safeeyes-2.1.5/safeeyes/plugins/trayicon/plugin.py

  This is the code which fixes Debian bug #1006942

safeeyes-2.1.5/safeeyes/safeeyes.py

  Updated version number

safeeyes-2.1.5/safeeyes/utility.py

  Support "sawy"; new check for using Wayland

safeeyes-2.1.5/setup.py

  New version number

safeeyes-2.1.5/validate_po.py

  Unused script, not included in final binary package; presumably it
  is used by the developers to check the .po files are OK.

unblock safeeyes/2.1.5-0.1

#1033890#12
Date:
2023-04-06 06:56:19 UTC
From:
To:
Unblocked.