#1034223 powerman: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

Package:
powerman
Source:
powerman
Description:
Centralized Power Distribution Unit (PDU) management
Submitter:
Date:
2023-04-25 17:21:03 UTC
Severity:
normal
Tags:
#1034223#5
Date:
2023-04-11 07:37:27 UTC
From:
To:
Dear Maintainer,

It seems that your package powerman is shipping files (.service, .socket or
.timer) in /usr/lib/systemd/system.

This is not supported by the version of dh_installsystemd/debhelper currently
in unstable and bookworm (See: #1031695). That means that currently your
service might not be enabled at boot and/or started as expected.

With the freeze currently in effect, debhelper will not be fixed for bookworm.

As a result, could you please move these files to /lib/systemd/system instead
so they are properly detected by debhelper?
As soon as debhelper is supporting (not until bookworm+1 aka Trixie) you will
be able to move them back to the newer location.

Note that bookworm is currently in hard freeze, please limit the changes you
are uploading to the ones fixing RC bugs.  Also note that you might have to
request a freeze exception to the release team.
See: https://release.debian.org/testing/freeze_policy.html

Feel free to contact me if you have any questions.

Kind regards,
Laurent Bigonville

The list of packages has been generated with the following command:
apt-file search -x '^/usr/lib/systemd/system/.*\.(service|timer|socket)$'|cut -d: -f1|sort -u

#1034223#10
Date:
2023-04-11 14:42:32 UTC
From:
To:
Hello Laurent Bigonville,
[...]

Note that debian/rules has:

```
override_dh_installinit:
        dh_installinit --no-start --no-enable

override_dh_installsystemd:
        dh_installsystemd --no-start --no-enable
```

So do you agree that the severity of this bug report should be downgraded
(maybe even closed)?

Regards,
Andreas Henriksson

#1034223#15
Date:
2023-04-19 22:03:04 UTC
From:
To:
severity 1034223 important
thanks

On Tue, 11 Apr 2023 16:42:32 +0200 Andreas Henriksson <andreas@fatal.se>
wrote:

 > Hello Laurent Bigonville,
 >
 > On Tue, Apr 11, 2023 at 09:37:27AM +0200, bigon@debian.org wrote:
 > > Package: powerman
 > > Version: 2.3.27-2
 > > Severity: serious
 > > Tags: sid bookworm
 > > User: debhelper@packages.debian.org
 > > Usertags: systemd-files-in-usr-bookworm
 > >
 > > Dear Maintainer,
 > >
 > > It seems that your package powerman is shipping files (.service,
.socket or
 > > .timer) in /usr/lib/systemd/system.
 > >
 > > This is not supported by the version of dh_installsystemd/debhelper
currently
 > > in unstable and bookworm (See: #1031695). That means that currently
your
 > > service might not be enabled at boot and/or started as expected.
 > [...]
 >
 > Note that debian/rules has:
 >
 > ```
 > override_dh_installinit:
 > dh_installinit --no-start --no-enable
 >
 > override_dh_installsystemd:
 > dh_installsystemd --no-start --no-enable
 > ```
 >
 > So do you agree that the severity of this bug report should be downgraded
 > (maybe even closed)?

I think severity can be downgraded (to "important"?), this is still a
problem as systemctl daemon-reload is not called, but at least there
will be surprise after a reboot.

#1034223#22
Date:
2023-04-25 16:52:18 UTC
From:
To:
Laurent Bigonville <bigon@debian.org> (2023-04-20):

It seems simple enough to fix, see attached source debdiff.

This results in the following debdiff on the binary side:

    [The following lists of changes regard files as different if they have
    different names, permissions or owners.]

    Files in second .deb but not in first
    -------------------------------------
    -rwxr-xr-x  root/root   /lib/systemd/system/powerman.service

    Files in first .deb but not in second
    -------------------------------------
    -rwxr-xr-x  root/root   /usr/lib/systemd/system/powerman.service

    No differences were encountered between the conffiles files

    Control files: lines which differ (wdiff format)
    ------------------------------------------------
    Installed-Size: [-500-] {+502+}
    Version: [-2.3.27-2-] {+2.3.27-3+}

    Postinst files: lines which differ (wdiff format)
    -------------------------------------------------
    {+# Automatically added by dh_installsystemd/13.11.4+}
    {+if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then+}
    {+	if deb-systemd-helper debian-installed 'powerman.service'; then+}
    {+		# The following line should be removed in trixie or trixie+1+}
    {+		deb-systemd-helper unmask 'powerman.service' >/dev/null || true+}
    {++}
    {+		if deb-systemd-helper --quiet was-enabled 'powerman.service'; then+}
    {+			# Create new symlinks, if any.+}
    {+			deb-systemd-helper enable 'powerman.service' >/dev/null || true+}
    {+		fi+}
    {+	fi+}
    {++}
    {+	# Update the statefile to add new symlinks (if any), which need to be cleaned+}
    {+	# up on purge. Also remove old symlinks.+}
    {+	deb-systemd-helper update-state 'powerman.service' >/dev/null || true+}
    {+fi+}
    {+# End automatically added section+}

    Postrm files: lines which differ (wdiff format)
    -----------------------------------------------
    {+# Automatically added by dh_installsystemd/13.11.4+}
    {+if [ "$1" = remove ] && [ -d /run/systemd/system ] ; then+}
    {+	systemctl --system daemon-reload >/dev/null || true+}
    {+fi+}
    {+# End automatically added section+}
    {+# Automatically added by dh_installsystemd/13.11.4+}
    {+if [ "$1" = "purge" ]; then+}
    {+	if [ -x "/usr/bin/deb-systemd-helper" ]; then+}
    {+		deb-systemd-helper purge 'powerman.service' >/dev/null || true+}
    {+	fi+}
    {+fi+}
    {+# End automatically added section+}

    Preinst files: lines which differ (wdiff format)
    ------------------------------------------------
    {+# Automatically added by dh_installsystemd/13.11.4+}
    {+if [ -z "${DPKG_ROOT:-}" ] && [ "$1" = upgrade ] && [ -d /run/systemd/system ] ; then+}
    {+	deb-systemd-invoke stop 'powerman.service' >/dev/null || true+}
    {+fi+}
    {+# End automatically added section+}

    No differences were encountered between the prerm files


I've left the following lintian warnings unaddressed (and haven't
touched tmpfiles.d at all):

    W: powerman: executable-not-elf-or-script [lib/systemd/system/powerman.service]
    W: powerman: executable-not-elf-or-script [usr/lib/tmpfiles.d/powerman.conf]
    W: powerman: systemd-service-file-refers-to-obsolete-target syslog.target [lib/systemd/system/powerman.service]


Upload on the way.


Cheers,

#1034223#29
Date:
2023-04-25 17:18:56 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
powerman, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1034223@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cyril Brulebois <kibi@debian.org> (supplier of updated powerman package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Tue, 25 Apr 2023 16:42:32 +0000
Source: powerman
Architecture: source
Version: 2.3.27-3
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Cyril Brulebois <kibi@debian.org>
Closes: 1034223
Changes:
 powerman (2.3.27-3) unstable; urgency=medium
 .
   * QA upload.
   * Ship systemd unit under /lib/systemd/system so that it can get picked
     up by dh_installsystemd. (Closes: #1034223).
Checksums-Sha1:
 0dae1acca09f57d4d25d74f0f25398be75a62eed 2107 powerman_2.3.27-3.dsc
 1c29365b31b425d8b0d4d3ee8aad4ce4a7c49a47 8488 powerman_2.3.27-3.debian.tar.xz
 47ff97fa8c2f872630fd50ebc91c08f2ca25bfa1 6920 powerman_2.3.27-3_source.buildinfo
Checksums-Sha256:
 ce9b8c4cfd1e014f337a0b0a6024813fb774a6cc88ac29aaec00bfab0b324d85 2107 powerman_2.3.27-3.dsc
 0be31323a0837dee4ef2c8081d211e64363679100eabd5daf8136102d880b1f2 8488 powerman_2.3.27-3.debian.tar.xz
 1d7565e4abd729d3965740c00ddad6484dba32cadb730ac88080c002c54b4e1d 6920 powerman_2.3.27-3_source.buildinfo
Files:
 9e1a1a7f75142a5461158720b42d33fd 2107 admin optional powerman_2.3.27-3.dsc
 afc609883a43ab35b774926d2b285ae7 8488 admin optional powerman_2.3.27-3.debian.tar.xz
 ab607edfc878d44c5942ddd9d6ecbe05 6920 admin optional powerman_2.3.27-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmRIBVEQHGtpYmlAZGVi
aWFuLm9yZwAKCRD/kUrwwrNVILPcD/0YVTsjlgVSzX2rZJiYyhprA4NQZgI3UEex
hD7s8GgZ+L1M3k2l+ZClqlzf/Et6vV0RDvwOkS6WYxTMYD1DM1n/+9NtpuwPxJ7e
FqXRHwzX3p5LwTcL0G1TBoyf23qdAepM7UnFmlJedpmjrDE8gIbZKljTm0ybM377
Fm/T9j6fwqc2431Ox6v6VF9zPf8UztmMYFdPVQ73SKQHAHJp7oJFs3+10epm2wJu
+P5kbw/WgR4uC3pffwlniPAiFw2a9uiuoU0JcSl9tdbetqo5iUz5LCLeqBAbANZ8
cLf82pUYi0yGgzjv/O4NTjexeIbpHObTFofVZNgV+1qMIh8FEyn6ghXgf3tEkmPA
+X+sxqNatqHVzf5c9znb0+nef6WZGLjBcLfHTlCClv778VC2wix7pCzI3CUPBTum
omcdv1UdOtA0ZXmSVliqzsCkwRZyDJwhBOBTBMZiFR2gfINDg4wTCqaJy7v7BN0n
q2RebLrQdVYBZc7BVEfEjjG3+lJknctgcnV6UYmgxNCuxP7+4Lsmz8hfs0g6W7SR
W5STrDn28cVWae4zlE8art2XIpnxm/0MMlQydJvvPFkqNPVQLI2xxPse9NQXU5DM
W6KwKQU7BYIg6eRht9qJzxN3DUT7mcLC8v/BaoPc0xsRXdLqFU00qnlfjkohyU6r
xHFEvu2LTg==
=HwHG
-----END PGP SIGNATURE-----