#1034860 console-setup: building the source package is a mess

#1034860#5
Date:
2023-04-25 23:25:51 UTC
From:
To:
Source: console-setup
Severity: important

Hi,

`dpkg-buildpackage -S` is usually sufficient to build a source package,
and having all build dependencies might not even be needed. But for
console-setup, bdfresize and friends are needed because they are called
during clean?!

A source build log is attached.

It also means that build artifacts are included in the source package,
that are nowhere to be found in the git repository, which doesn't make
any sense. And if one dares trying to use `-nc` to dodge the clean
target, the following source debdiff appears:

     Fonts/bdf/legacy14a-double.bdf   |13560 -
     Fonts/bdf/legacy14b-double.bdf   |10235
     Fonts/bdf/legacy14c-double.bdf   |10235
     Fonts/bdf/legacy14d-double.bdf   |10165
     Fonts/bdf/legacy14e-double.bdf   |11355 -
     Fonts/bdf/legacy14f-double.bdf   | 6420
     Fonts/bdf/legacy14g-double.bdf   | 7750
     Fonts/bdf/legacy14h-double.bdf   | 6630
     Fonts/bdf/legacy14i-double.bdf   | 9710
     Fonts/bdf/legacy14j-double.bdf   | 9710
     Fonts/bdf/legacy14k-double.bdf   | 9710
     Fonts/bdf/legacy14l-double.bdf   |10235
     Fonts/bdf/legacy16a-double.bdf   |17994 -
     Fonts/bdf/legacy16b-double.bdf   |13002 -
     Fonts/bdf/legacy16c-double.bdf   |14679 -
     Fonts/bdf/legacy16d-double.bdf   | 9999
     Fonts/bdf/legacy16e-double.bdf   |15771 -
     Fonts/bdf/legacy16f-double.bdf   | 7152
     Fonts/bdf/legacy16g-double.bdf   | 7386
     Fonts/bdf/legacy16h-double.bdf   | 8751
     Fonts/bdf/legacy16i-double.bdf   |10818
     Fonts/bdf/legacy16j-double.bdf   |10623
     Fonts/bdf/legacy16k-double.bdf   |11403 -
     Fonts/bdf/legacy16l-double.bdf   |10818
     Fonts/bdf/legacy16m-double.bdf   |11403 -
     Fonts/bdf/u_vga16-double.bdf     |113095 ----------
     Fonts/bdf/u_vga16_fix-double.bdf | 7173
     Fonts/bdf/unifont.bdf            |1313010 ---------------------------------------------------------------------------------------------------------------------
     Keyboard/KeyboardNames.pl        |  933
     debian/po/templates.pot          |    2
     man/bdf2psf.1.txt                |  147
     man/ckbcomp.1.txt                |  122
     man/console-setup.5.txt          |  331
     man/keyboard.5.txt               |  152
     man/setupcon.1.txt               |  127
     38 files changed, 54 insertions(+), 1700653 deletions(-)


Additionally, clean modifies debian/po/templates.pot which leaves a
modified file in the git tree if the l10n tooling shows a different
behaviour compared to the l10n infrastructure (l10n robot), e.g.
changing line-wrapping in addition to bumping the timestamp:

    diff --git a/debian/po/templates.pot b/debian/po/templates.pot
    index fb1879d..b371406 100644
    --- a/debian/po/templates.pot
    +++ b/debian/po/templates.pot
    @@ -8,7 +8,7 @@ msgid ""
     msgstr ""
     "Project-Id-Version: console-setup\n"
     "Report-Msgid-Bugs-To: console-setup@packages.debian.org\n"
    -"POT-Creation-Date: 2020-10-28 20:01+0000\n"
    +"POT-Creation-Date: 2023-04-25 23:14+0000\n"
     "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
     "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
     "Language-Team: LANGUAGE <LL@li.org>\n"
    @@ -445,9 +445,9 @@ msgstr ""
     #. :sl3:
     #: ../keyboard-configuration.templates:10001
     msgid ""
    -"The default value for the options of the keyboard layout is XKBOPTIONS="
    -"\"${XKBOPTIONS}\".  It is based on the currently defined language/region and "
    -"the settings in /etc/X11/xorg.conf."
    +"The default value for the options of the keyboard layout is "
    +"XKBOPTIONS=\"${XKBOPTIONS}\".  It is based on the currently defined language/"
    +"region and the settings in /etc/X11/xorg.conf."
     msgstr ""

     #. Type: boolean
    @@ -664,8 +664,8 @@ msgstr ""
     #: ../keyboard-configuration.templates:11002
     msgid ""
     "Right Alt or Caps Lock keys are often chosen for ergonomic reasons (in the "
    -"latter case, use the combination Shift+Caps Lock for normal Caps toggle). Alt"
    -"+Shift is also a popular combination; it will however lose its usual "
    +"latter case, use the combination Shift+Caps Lock for normal Caps toggle). "
    +"Alt+Shift is also a popular combination; it will however lose its usual "
     "behavior in Emacs and other programs that use it for specific needs."
     msgstr ""


Looks to me a major Makefile overhaul is overdue!


Cheers,