Hi,

During a rebuild of all packages in testing (bookworm), your package failed
to build on amd64.


Relevant part (hopefully):
The full build log is available from:
http://qa-logs.debian.net/2023/05/17/golang-github-pin-tftp_2.2.0-3_testing.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20230517;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20230517&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Hey folks.
This bug is affecting the gobuster package that I maintain.
I've tested golang-github-pin-tftp locally and everything looks perfect.
It looks like a false positive on the Build.
If anyone can see this by July 1st, it will be important that these
packages are not automatically removed from testing.

Thank you all!

Hi all,

I looked at the results on the reproducible build infrastructure and the
package seems to regularly fail. This may hint that the tests are flaky.
Also autopkgtest is not without failure [2].

Paul

[1]
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/golang-github-pin-tftp.html
[2] https://ci.debian.net/packages/g/golang-github-pin-tftp/

To fix a similar problem with TestSendReceiveSinglePort, #1008412 fixed
by disabling it in debian/patches/single_port_test.go.patch.

The next test after TestSendReceiveSinglePort is
TestSendReceiveSinglePortWithBlockSize, and just
looking at the name it doesn't surprising if it
has the same problem.

cu
Adrian

I tested this package on an amd64 PorterBox and the bug seems to have
been resolved by disabling two tests.
I've attached this diff, feel free to test it and upload it as soon as
possible.

Regards

This doesn't make sense. Could you elaborate why these tests fail and
should be skipped?
Just disabling tests without explanation doesn't make this package less buggy.

I tried to rebuild the package locally, works for me. Tried to run
autopkgtests in GitLab CI: worked [1]. It hints at flaky tests indeed...

I noticed that in Debian we package 2.2.0, however upstream is at
version 3.0.0, with significant changes.

We have only two reverse build-deps: gobuster and ignition.

1) gobuster already uses pin-tftp 3.0

2) ignition seems to use an older version of pin-tftp, but I could
rebuild it with pin-tftp 3.0 successfully

So I'm going to upload version 3.0 of pin-tftp, and I'll check if builds
and autopkgtests succeed with this new version.

Hi Arnaud Rebillout

I'm waiting for this upgrade. After I'll try to upgrade gobuster to
3.6.0 version.

Regards.
Thanks a lot!
-- 
...........................................................................
⢀⣴⠾⠻⢶⣦⠀ Thiago Andrade Marques
⣾⠁⢰⠒⠀⣿⡁ GPG: 4096R/F8CDB08B
⢿⡄⠘⠷⠚⠋⠀ GPG Fingerprint: 1D38 EE3C 624F 955C E1FA  3C85 5A30 3591 F8CD B08B
⠈⠳⣄⠀⠀⠀⠀

On Mon, 18 Sep 2023 09:23:19 -0300 Thiago Andrade <andrade@debian.org>  wrote:
 > I'm waiting for this upgrade. After I'll try to upgrade gobuster to
 > 3.6.0 version.

Hello Thiago,

the new package was uploaded and is now in unstable.

However, after manually triggering the autopkgtests two times, I noticed
that a test failed (2 times, on a different architecture each time, cf
ppc64el and riscv64 logs at [1]). So it still looks like a test is
flaky, or maybe there's a bug in the code. I pinged upstream to see if
they can help [2].

Cheers,

Arnaud

We believe that the bug you reported is fixed in the latest version of
golang-github-pin-tftp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1036256@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Arnaud Rebillout <arnaudr@kali.org> (supplier of updated golang-github-pin-tftp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Mon, 13 Nov 2023 08:02:22 +0700
Source: golang-github-pin-tftp
Architecture: source
Version: 3.1.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed-By: Arnaud Rebillout <arnaudr@kali.org>
Closes: 1036256
Changes:
 golang-github-pin-tftp (3.1.0-1) unstable; urgency=medium
 .
   * Team upload
   * New upstream version 3.1.0 (Closes: #1036256)
Checksums-Sha1:
 e936c7ea28ce86b5654e75de85ec72d90cb605b5 2219 golang-github-pin-tftp_3.1.0-1.dsc
 7a147ab989a4f6a126e7d2b252c9027712a0bffc 20798 golang-github-pin-tftp_3.1.0.orig.tar.gz
 3788ebf0234bf119307bc7884fada4a159c747fb 2576 golang-github-pin-tftp_3.1.0-1.debian.tar.xz
 2752a304c69a6a479ec9d9c37ba8334fe3e41a3d 6267 golang-github-pin-tftp_3.1.0-1_source.buildinfo
Checksums-Sha256:
 9de09c4cacd2bc859d5003c56008988a40456456e9425ba4395de1e9eb19270c 2219 golang-github-pin-tftp_3.1.0-1.dsc
 66f3a2788a6c0ab0bedb0ce2e724d7d8427210072ed5e77d48e7aebc6f5f1e3b 20798 golang-github-pin-tftp_3.1.0.orig.tar.gz
 2b8828b614af5984efe4c63bc85bb007f087f0257d490ebdfb1ef05a5a0b8585 2576 golang-github-pin-tftp_3.1.0-1.debian.tar.xz
 95ea5bd1819f08da769174b052b65d9893e63e11d0f3c4c235920919125858ca 6267 golang-github-pin-tftp_3.1.0-1_source.buildinfo
Files:
 754a8a39e7536730713ad149fec16e1e 2219 golang optional golang-github-pin-tftp_3.1.0-1.dsc
 e9d2f15c71c3b00fdfe4ef1d1f6af2e8 20798 golang optional golang-github-pin-tftp_3.1.0.orig.tar.gz
 ea890fceadea6bdb8214bc5acbc405cd 2576 golang optional golang-github-pin-tftp_3.1.0-1.debian.tar.xz
 8cb7f72f139d229b298d6480b008d20d 6267 golang optional golang-github-pin-tftp_3.1.0-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE0Kl7ndbut+9n4bYs5yXoeRRgAhYFAmVRdoMRHGFybmF1ZHJA
a2FsaS5vcmcACgkQ5yXoeRRgAhbfww/6A3g+rG7N6K8i0tiEAB8ltpsFgsYlbAVr
A/OZcow2bDVfiRdlyMEyC5tdJtPdxUhjfn+0de5/blE11y9O3ZvResuNelp55EjV
euTswth8C21J88t64BTzWolgtwC6Jzka8mBVQBxGftZujVC8et38Y17RG+f+gooL
3nsB/a5nZdBRAdVK056nxKvi0NK4y3cQUwNhG3RUQ+f2veMuJVjC0Xfq8ibmBof5
gugT7V2f/T00TLj4NDdLrWmgmu4FKHdDxSwKw5IWlzRnFc9Xh+MY8smc5nexAbcM
67Z98JVJlGywGBtQVxixXbT9ob/T4LH0MbqVoccJ7FBXx1cRiW2XiwSLTZBZ5s0y
218T3tsUIvbjL9zv7Zh2ceyGZaxcO671E0RZ0n4Dyw5SD63B2PrZbuofHvh42AmN
A9LeqkZXcjHbZCT8xnT4VG7szMcfEKUtxa6X3wz8Qr4PSJwluiwkASGxJUmCiZhP
ew8Rt+HrtvO1YkupTm3tGGn3GdJBaxEiUFizOWtoyX1flBiaAWSSueUchlK8gF2m
Y8BstjIErwbhEjeE0g/PCarwJxxKFyh99H3YA8kqg5tMSdEX96IlraWMRTAY4THF
WYLT9RqyIjXGzD+phudhBNnctqbQYqtVwkpU9DUISmMvrnBwA+xhB3IyQXANpYiq
JIjbtPZnBNg=
=q7tu
-----END PGP SIGNATURE-----