#1037277 advi: reproducible-builds: Embedded build path and usrmerge paths in example Makefile

Package:
src:advi
Source:
src:advi
Submitter:
Vagrant Cascadian
Date:
2024-03-13 09:22:32 UTC
Severity:
normal
Tags:
#1037277#5
Date:
2023-06-10 02:57:15 UTC
From:
To:
The build path and various binary paths are embedded in
/usr/share/doc/advi/manual/pngs/Makefile.gz:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/advi.html

  ACLOCAL·=·${SHELL}·/build/1st/advi-1.10.2/missing·--run·aclocal-1.11
  vs.
  ACLOCAL·=·${SHELL}·/build/2/advi-1.10.2/2nd/missing·--run·aclocal-1.11

  EGREP·=·/bin/grep·-E
  vs.
  EGREP·=·/usr/bin/grep·-E

The attached patch fixes this by removing the example Makefile, which
would have to be regenerated anyways to match the running system.

If removing the example Makefile is not viable, it might be possible to
sanitize the build paths, and add relevent arguments to configure
(e.g. EGREP='/bin/grep -e') to use the specified paths.

According to my local tests, with this patch applied advi should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining advi!

live well,
  vagrant

#1037277#10
Date:
2024-03-12 21:43:39 UTC
From:
To:
severity -1 wishlist
thanks

Dear Maintainer,

Because Debian builds packages from a fixed build path, neither the 'reprotest'
utility in Salsa-CI, nor the Reproducible Builds team's package test
infrastructure for Debian[1] currently check for equivalent binary package
output from differing source package build paths.

This means that your package will pass current reproducibility tests; however
we believe that source code and/or build steps still embed the build path into
the binary package output, making it more difficult than necessary for
independent consumers to check the integrity of binary packages by recompiling
them themselves.

As a result, this bugreport will remain open and be re-assigned the 'wishlist'
severity[2].

For more information about build paths and how they can affect reproducibility,
please refer to: https://reproducible-builds.org/docs/build-path/

Thanks,
James

[1] - https://tests.reproducible-builds.org/debian/reproducible.html

[2] - https://www.debian.org/Bugs/Developer#severities

#1037277#15
Date:
2024-03-12 21:52:57 UTC
From:
To:

#1037277#22
Date:
2024-03-13 09:18:02 UTC
From:
To:
A correction for a mistake in my previous message:

Currently the 'reprotest' job in Salsa-CI does in fact continue to exercise
variations of the build-path, and will fail if it builds binary packages that
contain different contents as a result.