#1038176 criticalmass: Depends on SDL 1.2

#1038176#5
Date:
2023-06-16 11:42:48 UTC
From:
To:
This package has a Depends or Build-Depends on SDL version 1.2, which
is unmaintained upstream.

If possible, please port this package to SDL 2 and close this bug. There
is a migration guide at <https://wiki.libsdl.org/SDL2/MigrationGuide>,
and examples of successful ports from SDL 1.2 to SDL 2 can be found in
the commit history of packages like darkplaces and ioquake3.

If it is not possible to port to SDL 2, please test the package with
libsdl1.2-compat-shim (preferably version 1.2.64 or later), and leave
this bug open to track the package as still using SDL 1.2 APIs.

libsdl1.2-compat-shim is a compatibility layer that provides the SDL 1.2
API/ABI by using SDL 2: it has already replaced the "classic" SDL 1.2
library in some other distributions like Fedora and Arch, and my intention
is to do the same in Debian during the trixie release cycle.

It is *not* necessary to change dependencies from libsdl1.2debian to
libsdl1.2-compat-shim, or from libsdl1.2-dev to libsdl1.2-compat-dev.
My intention is to make a future version of sdl12-compat take over
the old package names, to minimize the changes that are required in
dependent packages.

The interesting scenarios to test with libsdl1.2-compat-shim are:

1. Install libsdl1.2-compat-shim and run the program in an X11 environment,
   such as "GNOME on Xorg" or XFCE.
   ($XDG_RUNTIME_DIR/wayland-* should not exist)
2. Install libsdl1.2-compat-shim and run the program in a Wayland
   environment such as GNOME's default mode, using Xwayland.
   ($XDG_RUNTIME_DIR/wayland-* should exist)
3. Install libsdl1.2-compat-shim and run the program in a Wayland
   environment, but this time with environment variable
   SDL_VIDEODRIVER=wayland so that it uses the native Wayland interface
   (this is not currently the default for SDL 2).
4. Install libsdl1.2-compat-dev and recompile the package.

Note that using libsdl1.2-compat and LD_LIBRARY_PATH is not sufficient if
the package contains programs that are setgid games. See
<https://github.com/libsdl-org/sdl12-compat/blob/main/HOW_TO_TEST_GAMES.md>
for more information.

If any of those fail, please report it as a bug in the
libsdl1.2-compat-shim or libsdl1.2-compat-dev package as appropriate,
with "affects" pointing to the program that is affected.

Thanks,
    smcv

#1038176#14
Date:
2023-07-04 14:03:56 UTC
From:
To:
Hey,

Am 16.06.2023 um 13:42 schrieb Simon McVittie:
In this case I still require the addons libsdl-image1.2-dev and
libsdl-mixer1.2-dev, without criticalmass does not work / build. What to
do here? The package is upstream dead.

#1038176#19
Date:
2023-07-04 14:55:21 UTC
From:
To:
In the short term, please test with libsdl1.2-compat-{shim,dev} and
report any regressions as sdl12-compat bugs, then leave this bug open,
without any changes to the package.

Please *do not* change the dependencies or Build-Depends to point
to sdl12-compat. My plan is that sdl12-compat will take over the
libsdl1.2debian and libsdl1.2-dev package names when we're ready for that
change[1], leaving libsdl1.2-compat-{shim,dev} as transitional packages
which will be removed after trixie.

The long term solution is to port this package to use SDL 2 without a
compatibility layer, which will probably include these replacements:

* libsdl1.2-dev -> libsdl2-dev
* libsdl-image1.2-dev -> libsdl2-image-dev
* libsdl-mixer1.2-dev -> libsdl2-mixer-dev

If the package is dead upstream then that might imply becoming its new
upstream developer, like Fabian Greffrath has recently done for rott
and wolf4sdl.

    smcv

[1] https://bugs.debian.org/1039911,
https://tracker.debian.org/news/1440432/accepted-sdl12-compat-1264-4exp1-source-into-experimental/

#1038176#24
Date:
2023-07-04 15:08:47 UTC
From:
To:
Am 04.07.2023 um 16:55 schrieb Simon McVittie:
The problem is without the mixer and image extension it does not build
at all or should I mix the dependencies (using mixer and image as before
and just switch main sdl to the compat one?)

#1038176#29
Date:
2023-07-04 15:41:33 UTC
From:
To:
It is fine to combine the original libsdl-image1.2 and libsdl-mixer1.2
with sdl12-compat.

    smcv

#1038176#34
Date:
2023-07-06 09:03:52 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
criticalmass, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1038176@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Patrick Matthäi <pmatthaei@debian.org> (supplier of updated criticalmass package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 06 Jul 2023 10:42:20 +0200
Source: criticalmass
Architecture: source
Version: 1:1.0.2-4
Distribution: unstable
Urgency: medium
Maintainer: Patrick Matthäi <pmatthaei@debian.org>
Changed-By: Patrick Matthäi <pmatthaei@debian.org>
Closes: 1038176
Changes:
 criticalmass (1:1.0.2-4) unstable; urgency=medium
 .
   * Bump Standards-Version to 4.6.2.
   * Use libsdl1.2-compat-dev.
     Closes: #1038176
   * Fix lintian warning build-depends-on-obsolete-package.
Checksums-Sha1:
 c7b0e3989bae42408adb72a250efc879690b00f6 1969 criticalmass_1.0.2-4.dsc
 d2d1f35183e9fbed76fd8da2a948745a4c89f20b 5122126 criticalmass_1.0.2.orig.tar.bz2
 7bd816694f5e675938b8c2e16d1630eb6286d94a 10420 criticalmass_1.0.2-4.debian.tar.xz
 5c426c89384cb7a63bcbbc6bd448a8392449785b 6732 criticalmass_1.0.2-4_source.buildinfo
Checksums-Sha256:
 485c15b8c5e595cc3935da87aa0a2e4cc7965e9dc238cc31a7a644ccbb60aff7 1969 criticalmass_1.0.2-4.dsc
 846db2d30d39e559612328594084a7aef980169948b2cfaee9fddec8ffdef724 5122126 criticalmass_1.0.2.orig.tar.bz2
 6055f0acd5a8725fdb9db69b481c07d836a47a670b03a70995eb51dc756308c6 10420 criticalmass_1.0.2-4.debian.tar.xz
 31ab3e76afffc59433251ec1a9c18e65e6fe0a98d0282e3c45e5512987f063ac 6732 criticalmass_1.0.2-4_source.buildinfo
Files:
 a6fb2d0084d85a1abb0266845cea9216 1969 games optional criticalmass_1.0.2-4.dsc
 e2aff114bffa717fb79c82e1dc473ebe 5122126 games optional criticalmass_1.0.2.orig.tar.bz2
 125f9b409300d22981f66f9db303e306 10420 games optional criticalmass_1.0.2-4.debian.tar.xz
 51a7b517aaec49a1ecb7dad0416167c0 6732 games optional criticalmass_1.0.2-4_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEWKA9xYJCWk3IuQ4TEtmwSpDL2OQFAmSmfx8ACgkQEtmwSpDL
2OS9wA//d8iw0tHUg643YLUnYjWhsxfl3RmmbRhweMIXxq8ctGgKgVoMXVZ1f1SG
bn08Dng1+jtgSC1jE9bi/mnTBg+CzGkDBawi7XBydBUDd4Lmxg6U4hgBaz/x2jib
82eBekXQBnNgG+2Yh/I0hNCXXm8ElQVUcrgpFDiFUBfZgOFC0LD26BG/Zst9gLTF
kncrOPvFRTkcrSdUjYp8c68ibrxu8Xvdvoum5/cUFH/DLMMxMf+szKg7Fj13pKRu
nxLMeWBWt6foktaR6Lwg0+XwVnT1t4XSNIVAzaA6M6Cyn2iyam/JvdQ/ldjD70Oo
GwnPUWrCu6MloTGTvJqOLeutktrvAPKZ88bHpSEx32dPzQT6z8Sxp7cz5DLS1s1k
Dm/od1B9Yy6FdApIK/df4Xno6e9itexB9Y+gT67X4p0nANi4c7LaBmMZXgZoBXzl
Z01m/i0fYTtkE8g01q/QVZ7sAEl9r01VRos5InrxlUjTojvO/zQHwv5IOW5+4Il1
P/u7KDrC32ge8Yk+COAvZUAYxB0JPr8A/EyGtNIV85LHnyUukKugbuAAYN0druJh
eWWglDFD2VGRGyVKJDWB8hqhrdLcfqVwB66CYLohVr68mRoYIeNFWhKPg+gn1iqI
dWbW8n9/eWjUTAZSlCtSH+9754+vsMGeL1DXPb4K/LjCx46qdSw=
=Korz
-----END PGP SIGNATURE-----

#1038176#39
Date:
2023-07-06 09:54:05 UTC
From:
To:
Please don't close these bugs unless the package has been ported to use
SDL 2 "natively", as was done in (for example) wolf4sdl.

In the original bug report, I wrote:
...

If you change the (build-)dependency to the -compat- packages, then you
will likely need to change it back after the migration to sdl12-compat
has finished, because they'll become transitional packages.

    smcv

#1038176#50
Date:
2026-01-10 10:09:17 UTC
From:
To:
Es gibt eine Familienspende in Höhe von 1.850.000,00 USD von Cheng Charlie
Saephan. Bitte antworten Sie für weitere Informationen. Denken Sie daran,
Ihrer Familie und den Bedürftigen in Ihrer Umgebung Gutes zu tun.

Dies ist bereits der zweite Versuch, Sie zu erreichen. Bitte antworten Sie
für weitere Details.

#1038176#55
Date:
2026-01-10 10:09:17 UTC
From:
To:
Es gibt eine Familienspende in Höhe von 1.850.000,00 USD von Cheng Charlie
Saephan. Bitte antworten Sie für weitere Informationen. Denken Sie daran,
Ihrer Familie und den Bedürftigen in Ihrer Umgebung Gutes zu tun.

Dies ist bereits der zweite Versuch, Sie zu erreichen. Bitte antworten Sie
für weitere Details.

#1038176#60
Date:
2026-01-10 10:09:17 UTC
From:
To:
Es gibt eine Familienspende in Höhe von 1.850.000,00 USD von Cheng Charlie
Saephan. Bitte antworten Sie für weitere Informationen. Denken Sie daran,
Ihrer Familie und den Bedürftigen in Ihrer Umgebung Gutes zu tun.

Dies ist bereits der zweite Versuch, Sie zu erreichen. Bitte antworten Sie
für weitere Details.

#1038176#67
Date:
2026-02-16 23:43:02 UTC
From:
To:
This has now happened. Could you update the criticalmass and
xime-lib-1.2 Build-Depends from libsdl1.2-compat-dev to libsdl1.2-dev
? But keep this bug open please.

Thank you,
Jeremy Bícha