Dear Maintainer,

src/lib include a few library that are already packaged for debian.

per se it is not a serious bug, but we should try if possible after testing to
use packaged version

The serious bug is due that for instance punycode was not in prefered form of
modification due to being wepackaged (transpiled) in order to be an ES module.

They may be other transpiled package in this subdirectory

Bastien

Am Montag, dem 31.07.2023 um 11:56 +0000 schrieb Bastien Roucariès:

Hello Bastien,

thanks for the report. I have reviewed the src/lib directory and replaced the
embedded Javascript libraries of csstree and js-beautify with Debian's system
libraries. I also added the source file of hsluv to debian/missing-sources and
documented the licenses of these three Javascript libraries in
debian/copyright.

I decided against replacing punycode because punycode.js in ublock-origin looks
like the preferred form for me. The file is not minified and can be edited
without problems. I believe you were referring to hsluv instead. I believe this
issue is fixed in version 1.51.0+dfsg-2 soon.

Regards,

Markus

Am Montag, dem 31.07.2023 um 11:56 +0000 schrieb Bastien Roucariès:

Hello Bastien,

thanks for the report. I have reviewed the src/lib directory and replaced the
embedded Javascript libraries of csstree and js-beautify with Debian's system
libraries. I also added the source file of hsluv to debian/missing-sources and
documented the licenses of these three Javascript libraries in
debian/copyright.

I decided against replacing punycode because punycode.js in ublock-origin looks
like the preferred form for me. The file is not minified and can be edited
without problems. I believe you were referring to hsluv instead. I believe this
issue is fixed in version 1.51.0+dfsg-2 soon.

Regards,

Markus

We believe that the bug you reported is fixed in the latest version of
ublock-origin, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1042757@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Markus Koschany <apo@debian.org> (supplier of updated ublock-origin package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Sat, 19 Aug 2023 01:01:05 +0200
Source: ublock-origin
Architecture: source
Version: 1.51.0+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Mozilla Extension Maintainers <pkg-mozext-maintainers@lists.alioth.debian.org>
Changed-By: Markus Koschany <apo@debian.org>
Closes: 1042757
Changes:
 ublock-origin (1.51.0+dfsg-2) unstable; urgency=medium
 .
   * Replace js-beautify and csstree Javascript libraries with system libraries.
     Document the licenses of js-beautify, csstree and hsluv in debian/copyright.
     Add the missing source file of hsluv.js to debian/missing-sources.
     Thanks to Bastien Roucariès for the report. (Closes: #1042757)
Checksums-Sha1:
 af6b3a70006cb96884334d49e6648b09689a7bd0 2464 ublock-origin_1.51.0+dfsg-2.dsc
 aabc0510187380debff4256485dd30dcb1a66849 42176 ublock-origin_1.51.0+dfsg-2.debian.tar.xz
 7bc73841d6d1c4f37cc6f49e00b0edd9fbe22c73 8720 ublock-origin_1.51.0+dfsg-2_amd64.buildinfo
Checksums-Sha256:
 5b0705c8888038f7e3fbb5a537a41b682f1e3b2654d911cd873c0db2bf4f78c7 2464 ublock-origin_1.51.0+dfsg-2.dsc
 12edaf2a5e10b2e4538dd4a4025087773d25b9af5a24023994f5c80cabdbda03 42176 ublock-origin_1.51.0+dfsg-2.debian.tar.xz
 582081ec9d31b31e353f59a57e79184d80784ebd008aab128f447ce47ab46dd5 8720 ublock-origin_1.51.0+dfsg-2_amd64.buildinfo
Files:
 6199b48be141ce95a87e110d75149090 2464 web optional ublock-origin_1.51.0+dfsg-2.dsc
 73e6e44985122ac4dde9445591a13ac6 42176 web optional ublock-origin_1.51.0+dfsg-2.debian.tar.xz
 b20d90e7ed2dfc06ae6254822d47346c 8720 web optional ublock-origin_1.51.0+dfsg-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQKjBAEBCgCNFiEErPPQiO8y7e9qGoNf2a0UuVE7UeQFAmTf/apfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEFD
RjNEMDg4RUYzMkVERUY2QTFBODM1RkQ5QUQxNEI5NTEzQjUxRTQPHGFwb0BkZWJp
YW4ub3JnAAoJENmtFLlRO1Hkk2UQAKFpu7tw53uBMGjCEKO2klSh5Lozk19PKYw3
wZD2kx95ljhKq9aHgphURMgNwhdDEeih9cyVrU/1F0qFb4o0ZO0iW+ZWcVXTRuTi
3S62NcOrIZyK52l4lrp/K7RaEBIVtIlPfmvNmQ/OFrX0iA7HA+yQoJwEhfMfM0mY
z+C3TlEtIWrmxbVHwadFllnokxP7to4OOVsGcJKGNIUAHeJuZf4hqNz7mpF+CSw7
inV1jU5ighyK489M2jBzkQVTG6DgM2YYEr+lGZo6BwYssbyIl7BIpg8vT/TGwbxW
ir0tg9fTcig5CrFRPqs3/gppfh4tUZusokqpw2A2PzEqW3Q0PqORg7w+gNG9MaRl
WYTkKzghCfK5J6OeYQA7RvtIvoRnyAlRluB+4wrxj32n3AkB7fhWrFd8gZwE6O3s
tXjnX636rrduhRwfVi/zH3GVqFWgwadzNxCa1dS2l+AZ8aZ7JQRKj+ZvDdFenp9a
CX5hMyDjyJ0MgxhJK609g/B0gEQGbndY6+zc68GKL+6yPdYWWMuRuqeCvz329vtq
1LSpVZs0SR2D/P2X7hmG8RqNIgEioSIWi7ioPd0D+ijQqxLVJll5m348h4TiqNgs
4y1f77sb7LCK3TKmU7ICroy/wMjM86vACqBhjXjDnwP+5JQTasdruSwEaM4/rjm4
ErLkk/Vk
=HsFm
-----END PGP SIGNATURE-----

Le vendredi 18 août 2023, 23:16:04 UTC Markus Koschany a écrit :

No unfortunatly this is transpiled aka compiled by webpack
see the first line
export default (function() {

This is make by webpack or rollup that are automated tools. This means that this code is transpiled and I do not know the extend of transpiling.

it may be only the es6 upstream code:
https://sources.debian.org/src/node-punycode/2.2.3-2/scripts/prepublish.js/
or something worst that replace the constant by something else.

if you see the original code here:
https://sources.debian.org/src/node-punycode/2.2.3-2/punycode.js/

you do not see the export default (function() {
line

Javascript is strange you could edit generated file and min.js is not the only problem

Thanks

Bastien

Le vendredi 18 août 2023, 23:16:04 UTC Markus Koschany a écrit :

No unfortunatly this is transpiled aka compiled by webpack
see the first line
export default (function() {

This is make by webpack or rollup that are automated tools. This means that this code is transpiled and I do not know the extend of transpiling.

it may be only the es6 upstream code:
https://sources.debian.org/src/node-punycode/2.2.3-2/scripts/prepublish.js/
or something worst that replace the constant by something else.

if you see the original code here:
https://sources.debian.org/src/node-punycode/2.2.3-2/punycode.js/

you do not see the export default (function() {
line

Javascript is strange you could edit generated file and min.js is not the only problem

Thanks

Bastien

Am Samstag, dem 19.08.2023 um 06:13 +0000 schrieb Bastien Roucariès:

Ok, I see. I don't think this a problem though. This is still reasonably
modifiable and human readable.

Markus