Hi,

When using https://udd.debian.org/patches.cgi, I notice that whenever
the Forwarded field contains anything other than "no", "not-needed",
"yes" or an URL, it gets marked as invalid.

That includes cases where it begins with "yes", but is complemented with
other data, as can be seen by contrasting a search on Debian Sources
about those packages [1] with their respective patch metadata status on
UDD.

In its current form, patches.cgi marks as invalid patches that include
useful information on the Forwarded field, such as the mail address to
which the patch was forwarded, when upstream doesn't have a public
mailing list archive or a web pull/merge request tracker, for example.

According to DEP-3 [2], if the Forwarded field is present, any other
value other than "no" or "not-needed" should be considered valid:

  Any value other than "no" or "not-needed" means that the patch has
  been forwarded upstream. Ideally the value is an URL proving that it
  has been forwarded and where one can find more information about its
  inclusion status.

As such, I think it would be interesting to either propose changes to
DEP-3 or to adhere more closely to it.

Thanks,
David

[1] https://codesearch.debian.net/search?q=file%3Adebian%2Fpatches%2F*.patch+Forwarded%3A+yes+.%2B&literal=0
[2] https://dep-team.pages.debian.net/deps/dep3/

Hi!

Yes, this has been discussed recently, and I've got some notes on
multiple issues with the Patch Guidelines. I'll try to start a
discussion about updating it during this week or so.

Thanks,
Guillem

https://udd.debian.org/patches.cgi?src=chkrootkit&version=0.58b-1

the patches marked "invalid" have been sent upstream by email but, sadly,
there is no upstream bug tracker or url , so no url to include.

it looks like this comes from
https://salsa.debian.org/qa/udd/-/blob/master/rimporters/patches.rb#206-222

line 222 requires that 'Forwarded: yes' be accompanied by a 'Bug' field
(and on line 208 the bug must be http(s) url). This seems stricter than
DEP3 ("Any value other than "no" or "not-needed" means that the patch has
been forwarded upstream. Ideally the value is an URL proving that it has
been forwarded and where one can find more information about its inclusion
status.")

and then
https://salsa.debian.org/qa/udd/-/blob/master/web/patches.cgi i assume
renders these as invalid.

the simplest fix looks.like having line 222 in patches.rb say

pa['forwarded_short'] = 'yes'

(and then modify
https://salsa.debian.org/qa/udd/-/blob/master/web/patches.cgi#194 to only
have the <a> if e[:forwarded_url] is set)

Or patches.rb could allow mailto: in the same way as http(s)?

(either looks quite easy, and i could send a MR -  but i dont know how to
test it)

On Sun, 1 Oct 2023 22:32:54 +0100 Richard Lewis <richard.lewis.debian@googlemail.com> wrote:

Please see https://salsa.debian.org/qa/udd/-/merge_requests/59 for one
approach to fixing this bug

Es gibt eine Familienspende in Höhe von 1.850.000,00 USD von Cheng Charlie
Saephan. Bitte antworten Sie für weitere Informationen. Denken Sie daran,
Ihrer Familie und den Bedürftigen in Ihrer Umgebung Gutes zu tun.

Dies ist bereits der zweite Versuch, Sie zu erreichen. Bitte antworten Sie
für weitere Details.