Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
The full build log is available from:
http://qa-logs.debian.net/2023/08/13/barbican_16.0.0-3_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Hello,

Bug #1043644 in barbican reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/openstack-team/services/barbican/-/commit/585e07d5f0454a0c8f62d22da02bbd9d27e3800b

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1043644

We believe that the bug you reported is fixed in the latest version of
barbican, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1043644@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Goirand <zigo@debian.org> (supplier of updated barbican package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Mon, 14 Aug 2023 11:49:23 +0200
Source: barbican
Architecture: source
Version: 1:16.0.0-4
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenStack <team+openstack@tracker.debian.org>
Changed-By: Thomas Goirand <zigo@debian.org>
Closes: 1043644
Changes:
 barbican (1:16.0.0-4) unstable; urgency=medium
 .
   * Correctly cleans built files (Closes: #1043644).
Checksums-Sha1:
 85f88147f4135a152b78014701cdffec78d935d8 3685 barbican_16.0.0-4.dsc
 443fa10889f8772ab72a0602f3b3cb16facb5e7b 10432 barbican_16.0.0-4.debian.tar.xz
 1bebae1bef102faa1df486003d2ed4b08d9b604d 21884 barbican_16.0.0-4_amd64.buildinfo
Checksums-Sha256:
 77169c41995d94de972777f99395cd4a8ba1d8a6c37be420e319ba822d17a727 3685 barbican_16.0.0-4.dsc
 fb532d95bc11f84a0bb6c746b14c828e667e33e206d2cb753abe2b41c02bdba1 10432 barbican_16.0.0-4.debian.tar.xz
 95ca715579e16d18f51d046f995fab7279052b64005d98d750ad199ba8552bd1 21884 barbican_16.0.0-4_amd64.buildinfo
Files:
 b1a169f824a038e940e65187b7a1202b 3685 net optional barbican_16.0.0-4.dsc
 49229a911985b500cda0ddc8fc039ef9 10432 net optional barbican_16.0.0-4.debian.tar.xz
 7d38d36debe472ef589e37bd3dbafd3f 21884 net optional barbican_16.0.0-4_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoLGp81CJVhMOekJc1BatFaxrQ/4FAmTZ+7oACgkQ1BatFaxr
Q/5TCw/9E4lUKOGtbBy7UDUXV+hSqvvf5b8zDFVI6LhNVTSVjrcRf/4pZ71e8PFg
IeuVqOLB27PfRjvGtPEfYNqKsLy82g2mTSHjuggK7Q6pxF8OIEyQ5ZENopoEeaOP
m9T/TBKST9coDZIE7/8o6UVWWxjyGwUw8lKxu1HVy9MIRKNqr89pZm4p9kCYnJBj
H9L2wOGM0TzL4QRbg/G+QlvWjPb1tbn7DbVYhLnaDQ00RQg3wZzgFoI9thtFCJVg
z7ttmoEhoQY3z4xYU9SwKfwE0Msi1uTxXBqpZm3SFZ/whpdyPqhclcPCIY+NvTOW
9EDk+NZc2L1KkxF9M6hQsO/WObSD6hsNfhjqZ74jBzySHbPRVjeegqq7rQqGIbtC
zavdj/yiFxQLcf99Q/sX8fQqUHuwhKDUx6TR8sipxjvEAapwANCPjeTXzKx4Oo+Y
aIMiTN4tobKRnVWsXoKfabETDPXPYYRKH5ScPzFi7wCi1Nql9PwD5GXbIe4TFn/J
n/yFVK1gCHx7ASjdhB0W+n5u40suapGpldA4P70M5CJu+yMxKSC23e7f6I4IiqBM
7Fq+yvaYtTHHHUl1RFl9KbImTJMNIg/cWRNVd3iq1g4a0h5yRuX9/l7TjAIV95s2
OZ6k/aNiqAaAuCaft8VtvqMwjoQ1NWBNy1L9sC5FIYQCtSf0lSk=
=Kbot
-----END PGP SIGNATURE-----

found 1043644 1:20.0.0-3
tags 1043644 patch
thanks

Hello.

In the next days/weeks I plan to reopen bugs like this one, because
either they were not properly fixed, or they were but the fix is not
effective anymore.

Fortunately many of the affected packages are cut by the same pattern,
so I hope that the following explanations will apply to many of them
as well.

When I try to build the source of barbican after a binary build, this
is what I get currently:

dpkg-source: info: local changes detected, the modified files are:
 barbican/.pybuild/cpython3_3.13/.pydistutils.cfg
 barbican/.pybuild/cpython3_3.14/.pydistutils.cfg
 barbican/AUTHORS
 barbican/ChangeLog
 barbican/etc/barbican/barbican.conf


The package is using debhelper and dh-python, which already know how
to clean those .pybuild directories, but it's not working here because
debian/rules is like this:

override_dh_auto_clean:
        rm -f debian/*.init debian/*.service debian/*.upstart
        rm -rf build
        rm -rf barbican.sqlite debian/po debian/barbican-api.templates debian/barbican-common.templates
        rm -f debian/barbican-api.postinst debian/barbican-api.config debian/barbican-common.postinst debian/barbican-common.config debian/barbican-common.postrm
        find $(CURDIR) -type f -iname '*.pyc' -delete || true
        find $(CURDIR) -type d -iname __pycache__ -exec rm -rf {} \; || true
        rm -rf *.egg-info
        rm -f doc/source/_static/barbican.conf.sample doc/source/_static/barbican.policy.yaml.sample

which does not include the default dh_auto_clean anywhere.

I'm attaching a patch which fixes all the issues in the way I believe
it makes most sense, using the default dh_auto_clean "as is", as it
already takes care of removing *.pyc, __pycache__ and the .pybuild
directories, and moving everything else to debian/clean, which is a
lot easier to update, as you don't have to use "rm -f" or "rm -rf".

Thanks.

We believe that the bug you reported is fixed in the latest version of
barbican, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1043644@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Goirand <zigo@debian.org> (supplier of updated barbican package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Wed, 21 Jan 2026 13:52:50 +0100
Source: barbican
Architecture: source
Version: 1:21.0.0-4
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenStack <team+openstack@tracker.debian.org>
Changed-By: Thomas Goirand <zigo@debian.org>
Closes: 1043644
Changes:
 barbican (1:21.0.0-4) unstable; urgency=medium
 .
   * Correct d/rules clean (Closes: #1043644).
Checksums-Sha1:
 f8a446c26ad94736031be7374d6b3b090d52649d 3596 barbican_21.0.0-4.dsc
 d224153d1a6ef29d96361fb4529df92a56b38dac 11004 barbican_21.0.0-4.debian.tar.xz
 78828cd5608338137abfc86dc92047a758381fd9 23133 barbican_21.0.0-4_amd64.buildinfo
Checksums-Sha256:
 acec4ace4aab5ccd6f82c44ec51227fb5e3d69d1179073cf0946b516f4dafd56 3596 barbican_21.0.0-4.dsc
 b4d73a7e9f4b05972c57450be39221f8a7b0cfa9a0dc7d76117d9f75f3118f46 11004 barbican_21.0.0-4.debian.tar.xz
 02c489e0be6d4c0388dcb2055370e782f1dc27217268e21d4ab50a87feda88d7 23133 barbican_21.0.0-4_amd64.buildinfo
Files:
 ea5653ff8cd679b3f8518cff5ad11105 3596 net optional barbican_21.0.0-4.dsc
 30abe900149c43cf85d03ddf3717b329 11004 net optional barbican_21.0.0-4.debian.tar.xz
 3e419702823d05f93c4bae5863c13abc 23133 net optional barbican_21.0.0-4_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEoLGp81CJVhMOekJc1BatFaxrQ/4FAmlymAcACgkQ1BatFaxr
Q/7Qcg//ZkVZkLamW2PqYB33o9ZtiuZE8gYiLTi7+69IneUWdyAk2nRufewm9YJT
qqOAkknC2if+stCkvGDyr84t71U4dNFoEMbjPwcDCyCaDRGeJUyzQYyCh/pqzcYS
1U0xG/+Vm5sUzo8nYuTgiYBTAwUTJ6ViFzRknRyeKVlB2zHD15hp5jhEXnBu8awa
GD0sSWxit3WCzij6nJGI5s3rD4XpkBqwv/02w6P604TuDs/e/j9iJTygiJxGX2yU
8uknh/UMYdSS4It2uzCR3cd0gTYpTeyZKFvkRz2sb9bZmoeRuDdXAnxktk13achm
g2/YObWhLg1uW4oSwQoO6i+xfcZzkpmFG2L8Pu2M0FgpS4lj9RJ6sVX7An5EXU/b
pgQD9iYaOyRj1ZIvX0x46RVQJmJx4/LejazSU5wLagUT3y7d16yMgNCN7Ii0kodU
BebKZsUzTbXelsd+xE7JoYpSiANRtUOtzFMnElAXiROU/E3StEgPV6GUNTTM11eu
WoZFEP5P0t6XRJ7v5DCJirXleJ+xMI9Ps4ZDsAKG5PRbV5h5GdDhEG4TpPI9wX3Y
yjWL1TZT7fHurN0cPzm6Z+8EgZFebGsSbiLKEwxN1GP7aAdIIaGdnggm0DKLUMuN
42zTEcyJB2pbgcGPn6RZfVX/9VxtEY6MbpVueYBbBVDN6mvpweg=
=i+zF
-----END PGP SIGNATURE-----