Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
The full build log is available from:
http://qa-logs.debian.net/2023/08/13/openntpd_6.2p3-4.2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Can this still be reproduced with 6.8p1-1 in Debian/unstable?

Martin-Éric

With openntpd 6.8p1-2, I can succesfully perform (dpkg-buildpackage ;
dpkg-buildpackage -S) but this only succeeds because dpkg-source
ignores deletion of all libtool files.

To me, the fact that dh_autoreconf doesn't restore the files it
updated at the end of the build remains a problem.

Martin-Éric

Version: 1:6.8p1-1

The problem is indeed fixed.

Well, I think dpkg-source does the right thing here.

If the files are regenerated during the build, then it's ok to remove
them before the build, but then it's also ok to ignore their deletion.

Some people would even say that those files removed at the beginning
do not really belong to the source code, but there is still some value
in not repackaging the orig.tar.gz because that way we can check that
it's exactly the same as provided by upstream (i.e. "pristine source").


I'm closing the bug because what it was reported (i.e. "ftbfs source
after successful build") is fixed, and I'm tracking this category of
bugs here using the usertag from Lucas:

https://bugs.debian.org/cgi-bin/pkgreport.cgi?users=lucas@debian.org;tag=ftbfs-source-after-build

If you really think there is still a problem, I humbly request that
you report it in another bug without the usertag to keep the above
usertag correct.

However, I honestly can tell you that removing files that are
regenerated during build and ignoring their deletion is completely
standard practice, and therefore I recommend that you consider the
problem solved for all purposes.

Thanks.