Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
The full build log is available from:
http://qa-logs.debian.net/2023/08/13/yggdrasil_0.4.7-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

FYI, this is caused by the existence of a 'clean' script in the top
level directory that prevents the clean target in d/rules from calling
out to debhelper (and thus allowing debhelper to actually clean up after
itself).

root@hm90:/yggdrasil-0.5.8# cat clean
#!/bin/sh
git clean -dxf
root@hm90:/yggdrasil-0.5.8#

root@hm90:/yggdrasil-0.5.8# ./debian/rules clean
make: 'clean' is up to date.
root@hm90:/yggdrasil-0.5.8# rm clean
root@hm90:/yggdrasil-0.5.8# ./debian/rules clean
dh clean --builddirectory=_build --buildsystem=golang --with=golang
    dh_auto_clean -O--builddirectory=_build -O--buildsystem=golang
    dh_autoreconf_clean -O--builddirectory=_build -O--buildsystem=golang
    dh_clean -O--builddirectory=_build -O--buildsystem=golang
root@hm90:/yggdrasil-0.5.8#

I don't know your gbp workflow, but a quick 'quilt new clean.patch;
quilt add clean; rm clean; quilt refresh;' allows 'dpkg-buildpackge -S'
to successfully build a source package after having built a binary package.

tags 1046091 pending
tags 1048863 pending
thanks

Hello.

I've commited fixes for these bugs in salsa, but I will not
make any team upload because I see "Invalidated by built-using" here:

https://tracker.debian.org/pkg/nncp
https://tracker.debian.org/pkg/yggdrasil

and I'm not sure how serious is that.

( Maybe yet another upload is precisely what they need? )

Thanks.

Hi Santiago,

Thank you for the fixes.  Currently these aren't transitioning because
quic had an incompatible change and thus it isn't transitioning until
the other packages that use it are fixed (I already fixed these two).

I'll happily make a new upload once syncthing, etc. are straightened
out -- or feel free to do so yourself if you like.

- John

BTW: These two packages have a funny feature: They contain a file
called "build", and for that reason the standard Salsa CI pipeline
(which I tested privately) does not work. Would you be willing to
switch to the standard salsa-ci.yml after this is fixed?

(I still have to report it properly...)

Thanks.

The salsa-ci.yml for all this is a mystery to me, so absolutely.  Feel
free to change it.

- John

https://salsa.debian.org/salsa-ci-team/pipeline/-/issues/521

When/if they fix that, I will be able to switch to the standard
salsa-ci.yml and make several pending team uploads.

(I recently found yet another package in debian-med with the same
problem, so I realized it was about time to report this...)

Thanks.

Whoa, that is a good find.  Thank you!

- John

Hi.

I finally did the two planned team uploads.

Note: Since you told me it was ok for you, I've switched to the
"standard" salsa-ci.yml, but I've temporarily changed the
"CI/CD configuration file" setting in Salsa CI to this value:

recipes/debian.yml@sanvila/pipeline

for both nncp and yggdrasil. This tells Salsa to use the fork in my
personal namespace where I've fixed the bug regarding files called
"build". As soon as they accept the MR, I'll change the setting to the
intended standard value:

debian/salsa-ci.yml

Thanks.

We believe that the bug you reported is fixed in the latest version of
yggdrasil, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1046091@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Santiago Vila <sanvila@debian.org> (supplier of updated yggdrasil package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Mon, 24 Nov 2025 17:20:00 +0100
Source: yggdrasil
Architecture: source
Version: 0.5.12-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed-By: Santiago Vila <sanvila@debian.org>
Closes: 1046091
Changes:
 yggdrasil (0.5.12-5) unstable; urgency=medium
 .
   * Team upload.
   * Fix clean target. Closes: #1046091.
   * Switch to the standard debian/salsa-ci.yml.
   * Drop "Rules-Requires-Root: no" (default).
   * Drop "Priority: optional" (default).
   * Update standards-version.
Checksums-Sha1:
 c31efe0d78ee419c3d8d8bdef71dae05dfe54279 2651 yggdrasil_0.5.12-5.dsc
 676cdba93161c0abeaa54ca9895d43b1370aa1d1 12228 yggdrasil_0.5.12-5.debian.tar.xz
 75a58e46813fa25da7ff6b5edb9b23d0ca6a26e2 11611 yggdrasil_0.5.12-5_source.buildinfo
Checksums-Sha256:
 7f896910a0fd42d2dd6d6252a7d95217dc4ee273dd2529ffb9d928dcb8d914d9 2651 yggdrasil_0.5.12-5.dsc
 684866b3a10ea3db89c25cd3a116d2d99ca6604ff1be090e55b8e82db39522cd 12228 yggdrasil_0.5.12-5.debian.tar.xz
 92b3ae9a36c247851854f7a0c0433c0cb04991f20dd3c7bf3f0567c264c8ad35 11611 yggdrasil_0.5.12-5_source.buildinfo
Files:
 929f99f670f60cc8510055403801c8b7 2651 golang optional yggdrasil_0.5.12-5.dsc
 1bf620637c60cf28c39c9df6bebcfd7b 12228 golang optional yggdrasil_0.5.12-5.debian.tar.xz
 e46db1af27f6a7f69aa07727c4efb1fb 11611 golang optional yggdrasil_0.5.12-5_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEE1Uw7+v+wQt44LaXXQc5/C58bizIFAmkkiucACgkQQc5/C58b
izLowQf9FmC4jhU/b/FwCWRi4qGVXH72lTdVRdM6z0sVXqGDClxpBnt3NQmbp4y/
QX5D4m5mpqbYmpEdcPpDbi4K8TlVqXhdS+bktNzqoyEBwQ6/s4aee2aaehJnNpxC
8gTqYfq39UX7H4mAAwQLzzYqTo3NNDeVOnD4M1bz7LEEfaLP5lhm7ZLyDW3hlWJz
qKdTR0TGCNMRwKgwqGgl5ta6G7fPlvA+cwED6as57b8uBJvSusJI5tu2nXUYtQ6Z
lcrBiZavJrTNHUsoqLIIhFXkUesUvXpH9M4hWzy8DG6JMW4TdVHLOs5EsX67Mg+d
N/RXkUA0VNxwIy4+oU5nhoZg56/26g==
=gJXj
-----END PGP SIGNATURE-----