Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
The full build log is available from:
http://qa-logs.debian.net/2023/08/13/rocblas_5.5.1+dfsg-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Hello,

Bug #1046971 in rocblas reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/rocm-team/rocblas/-/commit/1847dd6b15d78df5fd1918d64f20da2210d2613b
------------------------------------------------------------------------
Fix ftbfs-source-after-build

By removing the built documentation and generated test data in the
'clean' target, and by ignoring __pycache__ directories (wherever
they are).

Closes: #1046971
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1046971

We believe that the bug you reported is fixed in the latest version of
rocblas, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1046971@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Kastner <ckk@debian.org> (supplier of updated rocblas package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 17 Aug 2023 20:11:43 +0200
Source: rocblas
Architecture: source
Version: 5.5.1+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
Changed-By: Christian Kastner <ckk@debian.org>
Closes: 1046971
Changes:
 rocblas (5.5.1+dfsg-2) unstable; urgency=medium
 .
   * Upload to unstable.
   * Fix ftbfs-source-after-build. (Closes: #1046971)
Checksums-Sha1:
 df37ac76aab59e4a224458208fb50c27fdac541b 3102 rocblas_5.5.1+dfsg-2.dsc
 3f8b811d3293cb7686bdf3cbeb1cd0bc96172b4d 367148 rocblas_5.5.1+dfsg-2.debian.tar.xz
 28248f7df9c911e56f96d92a7136b046c761053c 6655 rocblas_5.5.1+dfsg-2_source.buildinfo
Checksums-Sha256:
 03d5186e0825e370f817e77183d8f6f848bd6064d0f12a2614c725e51572f5ec 3102 rocblas_5.5.1+dfsg-2.dsc
 e70da11c758f8bff84aeea8cb0fe7c6704b6d2c7b92c5769e30c5d76b839d2f5 367148 rocblas_5.5.1+dfsg-2.debian.tar.xz
 290d011b5397de7f39fa32484695df000b8654acf88b281b65523e1bdc3c9a6a 6655 rocblas_5.5.1+dfsg-2_source.buildinfo
Files:
 b5a026bbf3abc61230614602c26a5c0a 3102 devel optional rocblas_5.5.1+dfsg-2.dsc
 a6f825092b15f7b072920c0d3f519327 367148 devel optional rocblas_5.5.1+dfsg-2.debian.tar.xz
 fc72a66e1715009a34e9f24bd210f1ac 6655 devel optional rocblas_5.5.1+dfsg-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEQZ9+mkfDq5UZ8bCjOZU6N95Os2sFAmTeZRgPHGNra0BkZWJp
YW4ub3JnAAoJEDmVOjfeTrNr950QAKgZZgHPOEFJb6FT7fhc8a5y7u8a7dIpCTkw
pBfjBzofrgM1drYndJBfrD/HnfLcNLnD9pNh8CPiRQ8nSjzcu2ufQAaKOQzNTzQF
zeecKmz0ac7+/3oa8miflQqiXoCy10bruaAn8iO45+DZEuJXKkeSP1SWFw4PAQmX
V+iosi23kQa78GWuEDL4Ap+6bpFgBSqYkXF0Chc7SCk0mE1GVXy5v311UcPupXSa
UTqSoasn3ofoHCbXOFpeYVvUHXlIUhFcuPVVVoh9elzOUHqIOCsNAHORlytEdljc
H5/uB2PPNBEzRXbr6489LueIgkbJW7p3NJEwbG/1oRKw+IEo06pK4ZkAEbhNfap1
20HR70iWc5foZiOs88/z+ZA5RDp6Ftss8z7otr4MQD5wCg1tFdqU1QcJLrWIsuN1
h6GNmJckd0z2dCTRvop1woXzd2b3BlhZnCj9tLZ/3pDxRQNBCQD3yi1ocoHyJDfy
mVKbvF6vj1H8VrCXaUU8xi4ZNFHsA+Lq4xEuHiKVaVZiQMutK7ynwLxbjb+q+m7M
lFnBSMAhTXs8EZgsHYXSSVeQvegoHf984AK4dxgB1CrUNIdDYB7ArMzXg1u1C8jk
sm6KNpP+cjBcdGduiPw87evYI9NG85RqnmGiTkGsaZjiUC3Wyz9ewOlEurCswj6K
M1iBNiC5
=5GBl
-----END PGP SIGNATURE-----

tags 1046971 patch
severity 1046971 normal
thanks

Hello. The current build log when trying to build source after binary
build is now like this:

dpkg-source: error: cannot represent change to build/html/[many-different-files]
dpkg-source: error: cannot represent change to build/html/[many-different-files]
[...]
dpkg-source: error: cannot represent change to rocblas_gtest.data: binary file contents changed
dpkg-source: error: add rocblas_gtest.data in debian/source/include-binaries if you want to store the modified binary in the debian tarball


I've tested the attached patch and it seems to fix the problem.
Comparing with the previous debian/clean file, the differences are:

html/                          -> this is no longer needed
build/html/                    -> now needed
rocblas_gtest.data             -> now needed
clients/common/__pycache__/    -> removing the whole directory seems better than only rocblas_gentest.py


The file docs/conf.py is a little bit special. It does not show in the
build log in my usual autobuilder setup, but it does when I test the
change interactively, and apparently the build process modifies the
file in this way:

--- rocblas-6.4.4.orig/docs/conf.py
+++ rocblas-6.4.4/docs/conf.py
@@ -37,3 +37,8 @@ external_projects_remote_branch = ""

 for sphinx_var in ROCmDocs.SPHINX_VARS:
     globals()[sphinx_var] = getattr(docs_core, sphinx_var)
+
+# Force version in header
+html_context = {
+    'docs_header_version': 'Debian Build 7.1.1'
+}

We can't just remove the file because it's required to build the
package, but in this case we can ignore the changes using an
additional extend-diff-ignore regexp in debian/source/options.

(Of course, it would be better if docs/conf.py was not modified during
the build, but I don't know how to do that. For now the attached patch
allows building the source after a binary build).

Thanks.

Hello,

indeed it's probably rocm-docs-build that is modifying conf.py
I didn t find any convenient way to pass this header to sphinx.
I will do so rocm-docs-build restore the conf.py file after doc build,
since this issue will appear in many package using rocm-docs-build
this should be considered as a rocm-docs-core bug

regards