Dear Maintainer,

dh-cargo currently only provides the configure(), test(), clean() and install()
methods. As a consequence, building a package requires calling dh_auto_test,
which is a noop when DEB_BUILD_OPTIONS include "nocheck"[1].

This causes problems when packaging applications (i.e. not crates), as it then
leads to build failures in this specific case (see #1050769[2] for example).

As a consequence, it would be helpful to split the current test() method into
build() and test() so dh_auto_build can be used to build the package, and
dh_auto_test can be used only for executing tests (building those in the
process if needed).

Regards,
Arnaud

[1] https://salsa.debian.org/debian/debhelper/-/blob/main/dh_auto_test#L58
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050769

Control: tags 1050769 +patch

No, greetd needs to build itself correctly regardless of whether there
are helper functions available.

The 2 most common types of projects using dh-cargo are
1) Rust crates which are shipped as uncompiled source code
2) Rust apps which have their own build system, usually meson

In both those cases, dh_auto_build works correctly already.

greetd doesn't fall into those cases so needs to implement the build
and install steps itself. It already handles the install. And I've
submitted a merge proposal for it to handle the build.

https://salsa.debian.org/debian/greetd/-/merge_requests/4

Thank you,
Jeremy Bícha

Quack,

Sorry for the lag, I really lacked time and energy recently but I'll try
to upload a fix soon.

You're right and I did not realize nocheck would be used for real in
this package. I never saw this as a perfect solution but until debcargo
implements what's needed that seemed fine.
to maintain the build steps and have to update the calls and flags when
cargo or any other piece of tooling changes.
Maybe that won't change often but that's still silly to implement that
in each and every leaf package and as a consequence there's no unified
policy.
Unfortunately I do not have the bandwidth to propose debcargo changes.

So I guess I'll apply the patch you kindly provided but I'm thinking
about handing over the maintainership of wlgreet and greetd to people
who really have time to do it properly, or… maybe comaint.

Anyway, thanks for the report and patch everyone.
\_o<