#1053587 simple-revision-control: Fails when importing legacy RCS files with "description" content #1053587
- Package:
- simple-revision-control
- Source:
- simple-revision-control
- Submitter:
- RW Penney
- Date:
- 2024-02-23 09:30:03 UTC
- Severity:
- normal
- Tags:
Dear Maintainer, When using simple-revision-control to import RCS histories, it appears unable to handle RCS files that include a non-empty "description" field. This seems to be because the "src" application treats this field as JSON, which may be inconsistent with the RCS file format, as well as the format used by the RCS tools currently in bookworm. An example scenario is as follows: $ mkdir RCS $ echo "Interesting content" > file0.txt $ ci -i -t-"A tiny file for testing" -m"Initial commit" file0.txt RCS/file0.txt,v <-- file0.txt initial revision: 1.1 done $ echo "Fascinating content" > file1.txt $ ci -i -t-"" -m"Initial commit" file1.txt RCS/file1.txt,v <-- file1.txt initial revision: 1.1 done $ src srcify $ src log file0.txt = file0.txt =========================================================================================================== src: legacy data A tiny file for testing in description field src: fatal exception in popen_or_die. $ src log file1.txt = file1.txt =========================================================================================================== 1 | 2023-10-07T05:14:35Z | trunk Initial commit ----------------------------------------------------------------------------------------------------------------------- It appears that current upstream versions of simple-revision-control do not make any use of a JSON parser, and minor changes to a try/except block near line 448 of /usr/bin/src will resolve this issue. Without such a change it appears to be impossible to make simple-revision-control usable with legacy RCS histories.
We believe that the bug you reported is fixed in the latest version of simple-revision-control, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1053587@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Fukui Daichi <a.dog.will.talk@akane.waseda.jp> (supplier of updated simple-revision-control package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) Format: 1.8 Date: Sun, 18 Feb 2024 04:26:30 +0000 Source: simple-revision-control Architecture: source Version: 1.33-1 Distribution: unstable Urgency: medium Maintainer: Fukui Daichi <a.dog.will.talk@akane.waseda.jp> Changed-By: Fukui Daichi <a.dog.will.talk@akane.waseda.jp> Closes: 1053587 Changes: simple-revision-control (1.33-1) unstable; urgency=medium . * New upstream version 1.33 (Closes: #1053587) * d/control: Set new maintainer * d/control: Update dh compat version * d/control: Add Rules-Requires-Root field no * d/copyright: Add more authors * d/rules: Adapt to file name change * d/watch: Update url to source * d/control: Update standards version Checksums-Sha1: bb3d53ed296b48715c46a6da4c47e7841757325e 2026 simple-revision-control_1.33-1.dsc 34c0baaed85fefd891c3a1e8a1de4a0cc3417db1 70794 simple-revision-control_1.33.orig.tar.gz b183aa40b48b79056368a257e6ebdf4914d2ef0c 3380 simple-revision-control_1.33-1.debian.tar.xz 4afbe86c06215ffa642389bdf89a072ae2c71fd5 7808 simple-revision-control_1.33-1_source.buildinfo Checksums-Sha256: 68f6b13ee6411237953ab40ab50d40b33277ccdf58183344f12b1701f60d7edf 2026 simple-revision-control_1.33-1.dsc ff4e1b7d0f9e0f770fb3c09c47e576443beeedbc411be7ff73da63fba7ec67fd 70794 simple-revision-control_1.33.orig.tar.gz ed9db013f058b2f9e5c7d7c1139a1ffc1c3a6c9f7913dd75e70e20029c9381aa 3380 simple-revision-control_1.33-1.debian.tar.xz 8a4fe7aa073edbbfe2f3ce4b0964102801a3d0effb451582f079f3bea91aff4e 7808 simple-revision-control_1.33-1_source.buildinfo Files: 6da514908086c2ade21e31eff000cf05 2026 vcs optional simple-revision-control_1.33-1.dsc 13dc1d1f74dcfa9ed56e6847bfca8fa7 70794 vcs optional simple-revision-control_1.33.orig.tar.gz be2d12cab6a589152285d24f7cfc4fe0 3380 vcs optional simple-revision-control_1.33-1.debian.tar.xz 1c2810dd6844220bd9013c59f8e740ee 7808 vcs optional simple-revision-control_1.33-1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEJxPAbeqAQUJk+aVWnvZsLSMVu3wFAmXRk/0ACgkQnvZsLSMV u3xCow//azltmLbY9YVrM/hfu62nduga6G44PuZLIwH7YufrieQsBUa3ErcgkM+n Kql1P5ueU37QmN/FwaZ+hYyK76DM9OtdyiDud2e+7ugA4qlJpf+2RUOj/Dbx8uy+ Zsa0VVie9nSgDPVCVmcaxc+guq0VO35I8kO8MQEsWbfuOY+u/bRlkH15oVZtVJgV tSxtTEQ/Gc0NwJZOreRuP/zRjGpwvx7rRs+gI5IX1ebOBsO2+YFm8NmlUy6quoUw hS+b2vD1vYM/jIH1TTB60X52l0OV7orZ7od8si9CQRazIlqRBVZBo1JaqFUewd2F ATj0bAB/eXPzMxQO83+c0kXQjViHU0kK/GyNo0KJZA9W7MUBQPyu/yDapD0K+9SG S3xD+/i9X5piTje7E14HMGVJWCqFmfeRkIUbECB8y5YyMmw9bnIsgdwuHxJt5fZF mPXamEWPkDIBYiq8JQFW3otp63UkVHqJrj+2cg77rTLUryZQzTwk2v//+Zpbzr7n cUl7JxCZWTHPv4LgLZYuzmgRIFN1RfIfLy47vvuBbJfO/hNR5k5RNOpkxcYFBnnI FjJh/axnUfu/yST+ysmx5WV7c1AyX+4QkGoBKkhD3pXbOG8dCTMBGmC5GEwI+za9 XtF53qd9dV6ShtpzPoJVnIabo00XwIRYYhNADbsEAZ2r/wDjck0= =j9eL -----END PGP SIGNATURE-----
Hello Penney, The bug you reported is fixed with the following upstream commit: https://gitlab.com/esr/src/-/commit/9917f118882fa57b7ae171cd4a27fce0c59f54f7 That commit is included in the latest package 1.33-1. Best, Fukui