#1054137 apt: let dh_installsystemd choose the location of units

Package:
src:apt
Source:
src:apt
Submitter:
Helmut Grohne
Date:
2024-02-20 19:09:04 UTC
Severity:
normal
Tags:
#1054137#5
Date:
2023-10-17 14:36:19 UTC
From:
To:
We want to move aliased files from / to /usr to finalize the /usr-merge
transition via DEP17. apt is involved, because it install systemd units.
It currently hard codes their location to /lib/systemd/system. Rather
than moving them to /usr directly, I recommend using dh_installsystemd,
because backports will automatically revert back to the previous
location honouring the file move moratorium in bookworm. I'm attaching a
patch for your convenience. Once dh_installsystemd is updated and apt
binNMUed, it will have no files left in aliased locations.

Helmut

#1054137#10
Date:
2024-01-09 17:46:14 UTC
From:
To:
Dear APT Maintainers,

On Tue, Oct 17, 2023 at 04:36:19PM +0200, Helmut Grohne wrote:
[Move systemd files to /usr]

Could I ask you to apply this patch some time soon, please?

debhelper is already changed, so dh_installsystemd will already
install into /usr.

Thanks,
Chris

#1054137#15
Date:
2024-01-09 18:49:48 UTC
From:
To:
No, the patch is currently not in an actionable state to my
knowledge, we spend a couple hours trying to sort things out
in October or so but didn't get anywhere.

And there's urgent RC bug fixing in python-apt I
do need to finish up first before I can wrap my head around
this again.

#1054137#20
Date:
2024-01-09 18:53:20 UTC
From:
To:
FWIW, I'm more inclined to move the files to /usr manually, that
avoids all the risky business we identified trying to whack
dh_installsystemd into shape to install that successfully.

I could do that before the time_t transition, presumably next
Monday.

#1054137#23
Date:
2024-01-09 18:58:16 UTC
From:
To:
Hi,

Quoting Chris Hofstaedtler (2024-01-09 18:46:14)

this bug affects my package mmdebstrap. For your convenience, I created a MR on
salsa:

https://salsa.debian.org/apt-team/apt/-/merge_requests/318

Thanks!

cheers, josch

#1054137#30
Date:
2024-01-19 22:08:25 UTC
From:
To:
Hi Julian

On Tue, 9 Jan 2024 19:53:20 +0100 Julian Andres Klode <jak@debian.org> wrote:

Could you be more specific here?
Where and how and why exactly did you need to override dh_installsystemd?

dh_installsystemd should be the primary interface for installing debian
specific unit files (and handling upstream provided unit files) and we'd
like to improve it if possible.

Regards,
Michael

#1054137#33
Date:
2024-02-20 18:23:38 UTC
From:
To:
Hello,

Bug #1054137 in apt reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/apt-team/apt/-/commit/e3ba17fa7a60aa5cd699b69adf3989319935c917
------------------------------------------------------------------------
Move systemd units to /usr/lib

Closes: #1054137
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1054137

#1054137#40
Date:
2024-02-20 19:04:08 UTC
From:
To:
We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1054137@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julian Andres Klode <jak@debian.org> (supplier of updated apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Tue, 20 Feb 2024 19:38:02 +0100
Source: apt
Architecture: source
Version: 2.7.12
Distribution: unstable
Urgency: medium
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Julian Andres Klode <jak@debian.org>
Closes: 827785 1054137
Changes:
 apt (2.7.12) unstable; urgency=medium
 .
   [ Kenyon Ralph ]
   * apt-key: remove carriage returns from armored keyrings before dearmoring
 .
   [ наб ]
   * apt.8: summarise remaining verbs (Closes: #827785)
 .
   [ Adam Saponara ]
   * Prevent infinite loop in `ReadConfigFile`
 .
   [ Gábor Németh ]
   * Typos in integration tests
   * Document 'dist-clean'
 .
   [ Wesley Schwengle ]
   * Configure the amount of kernels to keep
   * Fix bug where ./git-clang-format.sh errors incorrectly
   * Add documentation of autoremove to apt.conf (5)
 .
   [ Julian Andres Klode ]
   * Bump Ubuntu apt-key deprecation notice to 24.04
   * Modernize standard library includes
   * Automatically enable snapshots where supported
   * test-snapshot: Fix a test case
   * Move systemd units to /usr/lib (Closes: #1054137)
Checksums-Sha1:
 0348c478946d054ee98e7239aa780391ee35e855 2935 apt_2.7.12.dsc
 9cbf273c3e7b6c3f366491103fa9fe2a8bba52d0 2350828 apt_2.7.12.tar.xz
 bb1d70854ba66576987d9b4f66267b49791bcea6 7947 apt_2.7.12_source.buildinfo
Checksums-Sha256:
 2ca5e44c888a1e485ccd5ef0d3a653f718c6615d499c38c6696fad978f6c03dd 2935 apt_2.7.12.dsc
 e46d166b5fc887c2d9bca7add7e0ccda547b962b762e1272a08c0426baa99caf 2350828 apt_2.7.12.tar.xz
 6ee511dd8c39919a5e02aebf96a452331e4fc5b80d34892ac6602722dced9105 7947 apt_2.7.12_source.buildinfo
Files:
 480e09ae847d62ec15abf1d96dc52d09 2935 admin required apt_2.7.12.dsc
 449dc774c1bb3e4a6abd534b7070d8c3 2350828 admin required apt_2.7.12.tar.xz
 515034fd0b372c605546ab0f1a4c3e36 7947 admin required apt_2.7.12_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEET7WIqEwt3nmnTHeHb6RY3R2wP3EFAmXU8loPHGpha0BkZWJp
YW4ub3JnAAoJEG+kWN0dsD9xoW0QAIJfJBd/jZYpcoXbUS+aIEtj56F0tfyMbFSl
yyI8/0bAMpY6ARpYk7FnwYHXe8NxpM3lfOxnhuWerqd5ofaJvkAD62uoo/EjHSPG
LQvZHwe+/yv8Vvb4H6DYcFxQ1ILQx4XxVS2snGXyesJpgGdc9px7cVnhHdnyoUhA
uA2ujwHg74grnf7hds4RCrm7yNcJIEwnOjr+ObIBslnsvK7m6I8/EdAe8+YQtiYn
5ypvFC7f3aoX7DiSVYiPtHNF/nHyVQwExrutjKhkaieqdM9HLonIJUgqnwhYzrck
uQCaf4265sIhI8mEuHKFdtKpcLQILYziQCnIn2oHuwz7FXEQ7dVvL3W53Y/VOI+F
+hksZtVcs+LzWce61ncN/SwuCDqT+DnUeot8LDIaXi2orSWS1/Fs4tUK9Hgn0fOQ
NWkFbmOGzQb4QlzDKG2YvsWRtTCx20C0IlAWSkSE9rVrpNCUaVtZdkwZH6F4guTE
IQ5CXrLdDHEiDnxjHprdW6JKjX0wER6ZAWjPHNtdvnvfCjZIOzD2VBZJEeoV2Ox+
aEddulEVHsFmHu9NFDsnCUQc6MAmr5Lq/vhEXo1jLSKRFMC+RH49mgeXQnSP0Ewx
LAkBpq7xPXhz6MyCR9wrkjsvZ3Ta74epQM5+Mac9LpwTniRv6iGZMbFu17U65f+x
xzsZJpDB
=pE6m
-----END PGP SIGNATURE-----