- Package:
- src:python-mpd
- Source:
- src:python-mpd
- Submitter:
- Matthias Klose
- Date:
- 2024-07-31 13:00:03 UTC
- Severity:
- normal
- Tags:
python-mpd's autopkg tests fail with Python 3.12:
[...]
248s ======================================================================
248s ERROR: test_idle_timeout (mpd_test.TestAsyncioMPD.test_idle_timeout)
248s ----------------------------------------------------------------------
248s Traceback (most recent call last):
248s File "/tmp/autopkgtest.zX0vrh/autopkgtest_tmp/mpd_test.py", line
1590, in test_idle_timeout
248s self._await(self._test_idle_timeout())
248s File "/tmp/autopkgtest.zX0vrh/autopkgtest_tmp/mpd_test.py", line
1304, in _await
248s return self.loop.run_until_complete(future)
248s ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
248s File "/usr/lib/python3.12/asyncio/base_events.py", line 684, in
run_until_complete
248s return future.result()
248s ^^^^^^^^^^^^^^^
248s File "/tmp/autopkgtest.zX0vrh/autopkgtest_tmp/mpd_test.py", line
1585, in _test_idle_timeout
248s await self.client.currentsong()
248s ^^^^^^^^^^^^^^^^^^^^^^^^^
248s File "/usr/lib/python3/dist-packages/mpd/asyncio.py", line 532, in f
248s raise ConnectionError("Can not send command to disconnected
client")
248s mpd.base.ConnectionError: Can not send command to disconnected client
248s
248s ----------------------------------------------------------------------
248s Ran 78 tests in 7.018s
248s
248s FAILED (errors=1)
248s + failed=1
Control: forwarded -1 https://github.com/Mic92/python-mpd2/issues/214
Control: tags -1 + upstream help
Fedora opened an equivalent bug upstream. No fix is currently known -
patches would be very much appreciated.
Thanks,
smcv
Control: retitle -1 python-mpd asyncio tests fail with Python 3.12
Control: severity -1 important
It looks as though the failing tests are for python-mpd's asyncio
interface, which is not actually used by any Debian package yet. In the
3.1.0-2 upload, I've marked those tests to be skipped, which mitigates
the bug.
It's still a valid bug, just not RC any more. If anyone is interested in
fixing the asyncio interface (or the test - it's not clear which one is
wrong), please revert d/p/Skip-asyncio-unit-tests-in-Python-3.12.patch
locally.
3.1.0-2 also sets up the package to run tests for all supported Python
versions at build time, which should make the failure with 3.12 easier
to reproduce: it will become a build failure, not just an autopkgtest
failure.
Thanks,
smcv
Control: retitle -1 python-mpd: mpd_test.TestAsyncioMPD.test_noresponse fails with Python 3.12
Control: severity -1 minor
Control: forwarded -1 https://github.com/Mic92/python-mpd2/issues/234
These failing tests were mostly fixed upstream in 3.1.1.
There is one failing test remaining, which is not run by default. In Debian
we previously tried to run it as part of the autopkgtest, but now we do not.
If any contributor is interested in fixing this, please run the test suite
with RUN_SLOW_TESTS=1 in the environment, and send any fixes upstream.
I do not intend to prioritize this work myself. I don't think it has a
significant impact on the quality of Debian, because nothing in Debian
seems to use the affected asyncio interface.
smcv