Hi

A new version of `devscripts` removed its dependency on `fakeroot`.
After this, the pkg-js-tools's autopkgtests started failing with errors
like:

759s Can't exec "fakeroot": No such file or directory at
/usr/share/perl5/Dpkg/IPC.pm line 312.
759s dh_eslint.t: error: unable to execute fakeroot dh_auto_install
--buildsystem=nodejs: No such file or directory
759s dh_eslint.t: error: fakeroot dh_auto_install --buildsystem=nodejs
subprocess returned exit status 25


https://ci.debian.net/packages/p/pkg-js-tools/testing/amd64/41355085/#L12525

This implies that `pkg-js-tools` was missing a (test) dependency on
`fakeroot`.  Looking a bit deeper into the tests, I think the `fakeroot`
usage is unnecessary. Example from dh_badfilesfield.t:

spawn(

     exec       => [ 'fakeroot', 'dh_auto_install', '...' ],

     wait_child => 1

);


Generally, `dh_auto_install` (nor any other `debhelper` tool) does not
require `fakeroot` and should be runnable without it assuming the
underlying build system is ready for it (which is generally should be
these days).  You *may* need to set `DEB_RULES_REQUIRES_ROOT=no` to
avoid triggering a safety check inside debhelper.

I would recommend that you remove all uses of `fakeroot` where possible
instead of just blindly adding the depends.

Best regards,
Niels

Hello,

Bug #1059565 in pkg-js-tools reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/js-team/pkg-js-tools/-/commit/d2518ba16b3d87582c25cafc8a8a52c179310e06
Closes: #1059565
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1059565

We believe that the bug you reported is fixed in the latest version of
pkg-js-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1059565@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yadd <yadd@debian.org> (supplier of updated pkg-js-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 28 Dec 2023 17:54:01 +0400
Source: pkg-js-tools
Built-For-Profiles: nocheck
Architecture: source
Version: 0.15.16
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>
Changed-By: Yadd <yadd@debian.org>
Closes: 1059565
Changes:
 pkg-js-tools (0.15.16) unstable; urgency=medium
 .
   * pkgjs-run: keep arguments after --
   * debhelper:
     + add esbuild in webpack (to generate pkg-js.lock)
   * Update standards version to 4.6.2, no changes needed.
   * Update test dependencies: replace devscripts by fakeroot
     (Closes: #1059565)
Checksums-Sha1:
 a6f8c1d1a2fdf06ed0ed3c0677d6cbd972556bea 2708 pkg-js-tools_0.15.16.dsc
 79cde952c01cd77c75e3705cdf3c2cdd2140a27c 87736 pkg-js-tools_0.15.16.tar.xz
Checksums-Sha256:
 071fa85474c48c890edfd3e2cb6eb3076965e99ff0126fc0712f43e884586f56 2708 pkg-js-tools_0.15.16.dsc
 da5139e1bc43f605c2eccebba25283e6a8f496c2b775eac99c8b8b046b94baa5 87736 pkg-js-tools_0.15.16.tar.xz
Files:
 9806da4322ae4564c2d58cbfaedb05d4 2708 devel optional pkg-js-tools_0.15.16.dsc
 284c34b7939d9e39eab922f66462b348 87736 devel optional pkg-js-tools_0.15.16.tar.xz
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAmWNfjUACgkQ9tdMp8mZ
7ukCYQ/+JVbut91MOnLGhXWd4Eb2rFe89rGHiatUE1rqDIrWaue7gQZoqHje5QdF
KDTe4yNmp4l6JV7Dagzq11P4RZ+pEftK4y2QPqQZyYBq1hQu6bSWqC8b3a95oHj0
o5T/TNdqfWUlol4GxgHTYHdbFY/9kPaM8sD6BMRqv1TuM6FS3j/B1zwH/k3KdygI
hXpJgc5V1jmaMY60jYYImhFtiAaDlEr/9HVjC7Ht6bKu7bunD3xfbGz7WSiyFPuH
+I7WhvZtaU3lmVSJgCsSwhwCsEOjkBBeA9Du5djW7P62jArqUoaD48AYvVtlP6vB
LlPASw2o+sC+Yp5Fu+mbUfeoh6xdDmnzDad5NLW65lhYkrN+a1nkle5UiKIH2MMs
cpeFbsVJmuswzAuIgrlibnqk5hzDDngEyCzuvXELO7+PG5ljF3s6ByAavlSsjE8z
Iv9qfY1x7oLrrV+aNkC58h1wvh3oNu9OzY0Yt/gQ5bb0O/ZK5OY1+xkEN0xRFj8w
Td54irh6QpwBqr+1GPPXGFV0SVM4sHEfyWo6CHr9CHYFfGRoYRRdwh59MgWtY6d5
fxxEopVlabSIGtySSrdV1U7/BPwBL+zxSoVuyE2ZA4DmyTDacfKfvXznRwSfo15Q
5DR4rUs2755Eu9WJpxYwgarAOzQ7ElzhcSW0vcYSBBn/jFXFdf4=
=ey3l
-----END PGP SIGNATURE-----

We believe that the bug you reported is fixed in the latest version of
pkg-js-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1059565@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yadd <yadd@debian.org> (supplier of updated pkg-js-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
Format: 1.8
Date: Thu, 28 Dec 2023 19:36:34 +0400
Source: pkg-js-tools
Architecture: source
Version: 0.15.17
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>
Changed-By: Yadd <yadd@debian.org>
Closes: 1059565
Changes:
 pkg-js-tools (0.15.17) unstable; urgency=medium
 .
   * Drop test dependency to fakeroot by using Rules-Require-Root:no.
     Thanks to Niels Thykier! (Closes: #1059565)
Checksums-Sha1:
 4ff69da550a6dbbe9cc916bbdcd9c9927c168c53 2677 pkg-js-tools_0.15.17.dsc
 4c99363e70a18554691275e1c3e2e1e1a1863f09 87776 pkg-js-tools_0.15.17.tar.xz
Checksums-Sha256:
 ca16bb1d9c3bf49191dbc55eba9da9f9b2b7946a32f7f530e07a57f68662ac02 2677 pkg-js-tools_0.15.17.dsc
 33e192d78068a48e05155330003eb4c5f9063e8c58a989a5ec6e5997ff88efb5 87776 pkg-js-tools_0.15.17.tar.xz
Files:
 3de6ff6ed098d0c8798b3bcce76b76c8 2677 devel optional pkg-js-tools_0.15.17.dsc
 09cbc5aeed4de8e59e6adf9edd2c122c 87776 devel optional pkg-js-tools_0.15.17.tar.xz
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAmWNllkACgkQ9tdMp8mZ
7ulMnQ//R7O6NC7tFNwe7Q0OPIwhAhSVRD3LfNp9t2+TY0E91MeJZG2nrqJpfKV0
V3riyInOaOZ3ta+PP6rJvKwzq+L7noj6fUdETb5GpaE+Qlq3LR9O9NGtUwhafh0f
i6Np2SukBWDkuCzM3OwU0nqQdVHjWbnqvSE42YJOOJWPKAg+zZeWXGNet7MsX0ME
tQ6W60vmz96NjTI4Irh4oKAUTECLCpM2UpQ+9xHNDPL9DPwt04Ohx7gazF6/y0Ut
wYAct1CAsYspD5r6R5jwarXO0OKmGVOrBDZ3AsANMALgW32u0WIXuQYHSPca7H7R
W1vRp/f3oZDDao+chJeuvi3V9bswLRvkJWiT8RXxC4hfuKV82099y5cBvryK1/Ps
XrGkDKFg0AI5yOqw0j1WTTv/TG/q575cozDyIlsQzDx5JGwcxDbugp58sP40dUJe
WU5GmPV68dYMgPHBU0rDY1CBBENToV97zmYQu3rttvmKpOS27ymGqMcZD76mDgJC
lgSuDh5TAQu9i8o4gjPKCZ9GWTxsugZ67oboBZLW3HVNq7u/ZmAUo5OG+yHIaB5h
7O9RQRFHxQlYo1/woa4d0iGIHZL3f3KD9VnV14/w5k5CvG6iaZyPld0m4emc57WF
Kcv36Y47wDoPcOshfYg9IHvj+WXyUNpJj/uC/c1Yk/SCBoUGMc8=
=8Oay
-----END PGP SIGNATURE-----