#1061620 autopkgtest: Ignores multiple comma-separated values in Testsuite

Package:
autodep8
Source:
autodep8
Submitter:
Jérémy Lal
Date:
2025-01-08 10:09:02 UTC
Severity:
normal
Tags:
#1061620#5
Date:
2024-01-27 13:41:49 UTC
From:
To:
Having in debian/control:
Testsuite: autopkgtest-pkg-python, autopkgtest-pkg-pybuild

tests two different things, and having both is nice.

However it seems autopkgtest doesn't consider the field can have multiple values,
it only runs one of them - or actually it might fallback to a default test,
because it doesn't recognize the field value.

Code concerned is in lib/testdesc.py

This won't run:
https://sources.debian.org/src/python-keycloak/3.3.0+dfsg-2/debian/control/?hl=30#L30
#1061620#10
Date:
2024-01-27 14:41:02 UTC
From:
To:
Hi Jérémy,

Ack.

Indeed, autopkgtest doesn't look at d/control at all. Both
autopkgtest-pkg-python and autopkgtest-pkg-pybuild are things that
autodep8 deals with and it needs to do the right thing. Reassigning.

Paul
#1061620#19
Date:
2024-01-27 15:05:32 UTC
From:
To:
Hi,

This seems to be problematic (note the "^" and "$" in the expression):

detect_by_control_field() {
   local pkgtype="$1"
   [ -f debian/control ] &&
     grep-dctrl --quiet \
     -F XS-Testsuite,Testsuite \
     -r "^autopkgtest-pkg-$packagetype\$" debian/control
}

Paul
#1061620#22
Date:
2024-01-28 16:51:45 UTC
From:
To:
Hello,

Bug #1061620 in autodep8 reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/ci-team/autodep8/-/commit/b67c905629a444058fd02bd8717bc8fc2e7d12e7
------------------------------------------------------------------------
Add support for multiple autopkgtest-pkg-$TYPE in Testsuite:

Those must be passed as a comma-separated list, e.g.:

    Testsuite: autopkgtest-pkg-foo, autopkgtest-pkg-bar

Closes: #1061620
Gbp-Dch: full
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1061620
#1061620#29
Date:
2024-01-28 16:53:51 UTC
From:
To:
Control: forwarded -1 https://salsa.debian.org/ci-team/autodep8/-/merge_requests/33

Fair enough. I have a proposed fix for this here:

https://salsa.debian.org/ci-team/autodep8/-/merge_requests/33
#1061620#34
Date:
2024-12-04 18:36:30 UTC
From:
To:
Hello,

Bug #1061620 in autodep8 reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/ci-team/autodep8/-/commit/1e9feea24d7958bead67439f61b78c557b5ca22c
------------------------------------------------------------------------
Add support for multiple autopkgtest-pkg-$TYPE in Testsuite:

Those must be passed as a comma-separated list, e.g.:

    Testsuite: autopkgtest-pkg-foo, autopkgtest-pkg-bar

Closes: #1061620
Gbp-Dch: full
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1061620